mirrors/rust-lightning
1
0
Fork 0
mirror of https://github.com/lightningdevkit/rust-lightning.git synced 2025-02-25 07:17:40 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1208 from TheBlueMatt/2021-12-less-force-close

Browse source 
Reduce force-closures with user fee estimators which round poorly
This commit is contained in:
Matt Corallo 2021-12-07 20:11:47 +00:00 • committed by GitHub
commit cd4dc39a8c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lightning/src/ln/channel.rs
View file

@ -862,8 +862,12 @@ impl<Signer: Sign> Channel<Signer> {
where F::Target: FeeEstimator where F::Target: FeeEstimator
{ {
let lower_limit = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background); let lower_limit = fee_estimator.get_est_sat_per_1000_weight(ConfirmationTarget::Background);
if feerate_per_kw < lower_limit { // Some fee estimators round up to the next full sat/vbyte (ie 250 sats per kw), causing
return Err(ChannelError::Close(format!("Peer's feerate much too low. Actual: {}. Our expected lower limit: {}", feerate_per_kw, lower_limit))); // occasional issues with feerate disagreements between an initiator that wants a feerate
// of 1.1 sat/vbyte and a receiver that wants 1.1 rounded up to 2. Thus, we always add 250
// sat/kw before the comparison here.
if feerate_per_kw + 250 < lower_limit {
return Err(ChannelError::Close(format!("Peer's feerate much too low. Actual: {}. Our expected lower limit: {} (- 250)", feerate_per_kw, lower_limit)));
} }
// We only bound the fee updates on the upper side to prevent completely absurd feerates, // We only bound the fee updates on the upper side to prevent completely absurd feerates,
// always accepting up to 25 sat/vByte or 10x our fee estimator's "High Priority" fee. // always accepting up to 25 sat/vByte or 10x our fee estimator's "High Priority" fee.