mirrors/rust-lightning
1
0
Fork 0
mirror of https://github.com/lightningdevkit/rust-lightning.git synced 2025-02-24 23:08:36 +01:00
Code Issues Projects Releases Packages Wiki Activity

Drop unreachable underflow-handling block in route calculation

Browse source 
See comment in the removed block, note that the subsequent
subtraction will underflow if the block would otherwise have been
reached.
This commit is contained in:
Matt Corallo 2021-03-27 18:16:38 -04:00
parent 4c75437262
commit bb62420b0f
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lightning/src/routing/router.rs
View file

@ -979,11 +979,6 @@ pub fn get_route<L: Deref>(our_node_id: &PublicKey, network: &NetworkGraph, paye
let mut spent_on_hop_msat = value_contribution_msat;
let next_hops_fee_msat = payment_hop.next_hops_fee_msat;
spent_on_hop_msat += next_hops_fee_msat;
if *channel_liquidity_available_msat < spent_on_hop_msat {
// This should not happen because we do recompute fees right before,
// trying to avoid cases when a hop is not usable due to the fee situation.
break 'path_construction;
}
if spent_on_hop_msat == *channel_liquidity_available_msat {
// If this path used all of this channel's available liquidity, we know
// this path will not be selected again in the next loop iteration.