mirrors/rust-lightning
1
0
Fork 0
mirror of https://github.com/lightningdevkit/rust-lightning.git synced 2025-02-25 15:20:24 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove unnecessary todo

Browse source 
The ChannelMonitor already monitors the chain for counterparties
revealing preimages, and will give the HTLCSources back to the
ChannelManager for claiming. Thus it's unnecessary for the ChannelManager
to monitor these HTLCs itself.

See is_resolving_htlc_output:
- if the counterparty broadcasted and then claimed one of the HTLCs we
  offered them, line 2015 is where the ChannelMonitor gives the ChannelManager
  the HTLC source
- if we broadcasted and they claimed an HTLC we offered them, line 2025 is
  where the ChannelMonitor gives the ChannelManager the HTLC source
This commit is contained in:
Valentine Wallace 2020-11-06 13:30:15 -05:00
parent 9c7c3b9921
commit 8e7b29160b
No known key found for this signature in database
GPG key ID: F88EC43B95E601B8
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lightning/src/ln/channel.rs
View file

@ -4017,12 +4017,6 @@ impl<ChanSigner: ChannelKeys> Channel<ChanSigner> {
} }
} }
for _htlc in self.pending_outbound_htlcs.drain(..) {
//TODO: Do something with the remaining HTLCs
//(we need to have the ChannelManager monitor them so we can claim the inbound HTLCs
//which correspond)
}
self.channel_state = ChannelState::ShutdownComplete as u32; self.channel_state = ChannelState::ShutdownComplete as u32;
self.update_time_counter += 1; self.update_time_counter += 1;
self.latest_monitor_update_id += 1; self.latest_monitor_update_id += 1;