mirrors/rust-lightning
1
0
Fork 0
mirror of https://github.com/lightningdevkit/rust-lightning.git synced 2025-01-19 05:43:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Replace lightning-block-sync test that depended on foo.com

Browse Source 
Our tests should generally not rely on internet access, and should
not rely on the behavior of any given remote server. However, one
of the `endpoint_tests` in `lightning-block-sync::http` relied on
`foo.com` resolving to a single socket address, which both might
change in the future and makes our tests fail without internet.
This commit is contained in:
Matt Corallo 2023-10-09 03:24:54 +00:00
parent eea19de198
commit 631f989fb5
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lightning-block-sync/src/http.rs
View File

@ -511,21 +511,19 @@ mod endpoint_tests {
#[test]
fn convert_to_socket_addrs() {
let endpoint = HttpEndpoint::for_host("foo.com".into());
let endpoint = HttpEndpoint::for_host("localhost".into());
let host = endpoint.host();
let port = endpoint.port();
use std::net::ToSocketAddrs;
match (&endpoint).to_socket_addrs() {
Err(e) => panic!("Unexpected error: {:?}", e),
Ok(mut socket_addrs) => {
match socket_addrs.next() {
None => panic!("Expected socket address"),
Some(addr) => {
assert_eq!(addr, (host, port).to_socket_addrs().unwrap().next().unwrap());
assert!(socket_addrs.next().is_none());
}
Ok(socket_addrs) => {
let mut std_addrs = (host, port).to_socket_addrs().unwrap();
for addr in socket_addrs {
assert_eq!(addr, std_addrs.next().unwrap());
}
assert!(std_addrs.next().is_none());
}
}
}