mirrors/rust-lightning
1
0
Fork 0
mirror of https://github.com/lightningdevkit/rust-lightning.git synced 2025-03-10 21:36:17 +01:00
Code Issues Projects Releases Packages Wiki Activity

Log additional details when ignoring first hops

Browse source 
Users are often confused when we fail to find a route due to some
requirements on the first hop are not being met. While we now take note
and log such candidates, we still previously required users to check
additional details to figure out why exactly the router refused to route
over a particular first hop.

Here, we add additional TRACE logging, in particular for
`ChannelDetails::next_outbound_htlc_limit_msat` and
`ChannelDetails::next_outbound_htlc_minimum_msat` when they are
relevant.
This commit is contained in:
Elias Rohrer 2023-12-04 15:39:13 +01:00
parent ac06a6a2f6
commit 52ecce9e28
No known key found for this signature in database
GPG key ID: 36153082BDF676FD
1 changed files with 43 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
lightning/src/routing/router.rs
View file

@ -1795,12 +1795,12 @@ where L::Target: Logger {
let payment_failed_on_this_channel = scid_opt.map_or(false, let payment_failed_on_this_channel = scid_opt.map_or(false,
|scid| payment_params.previously_failed_channels.contains(&scid)); |scid| payment_params.previously_failed_channels.contains(&scid));
let should_log_candidate = match $candidate { let (should_log_candidate, first_hop_details) = match $candidate {
CandidateRouteHop::FirstHop { .. } => true, CandidateRouteHop::FirstHop { details } => (true, Some(details)),
CandidateRouteHop::PrivateHop { .. } => true, CandidateRouteHop::PrivateHop { .. } => (true, None),
CandidateRouteHop::Blinded { .. } => true, CandidateRouteHop::Blinded { .. } => (true, None),
CandidateRouteHop::OneHopBlinded { .. } => true, CandidateRouteHop::OneHopBlinded { .. } => (true, None),
_ => false, _ => (false, None),
}; };
// If HTLC minimum is larger than the amount we're going to transfer, we shouldn't // If HTLC minimum is larger than the amount we're going to transfer, we shouldn't
@ -1810,6 +1810,13 @@ where L::Target: Logger {
if !contributes_sufficient_value { if !contributes_sufficient_value {
if should_log_candidate { if should_log_candidate {
log_trace!(logger, "Ignoring {} due to insufficient value contribution.", LoggedCandidateHop(&$candidate)); log_trace!(logger, "Ignoring {} due to insufficient value contribution.", LoggedCandidateHop(&$candidate));
if let Some(details) = first_hop_details {
log_trace!(logger,
"First hop candidate next_outbound_htlc_limit_msat: {}",
details.next_outbound_htlc_limit_msat,
);
}
} }
num_ignored_value_contribution += 1; num_ignored_value_contribution += 1;
} else if exceeds_max_path_length { } else if exceeds_max_path_length {
@ -1820,6 +1827,14 @@ where L::Target: Logger {
} else if exceeds_cltv_delta_limit { } else if exceeds_cltv_delta_limit {
if should_log_candidate { if should_log_candidate {
log_trace!(logger, "Ignoring {} due to exceeding CLTV delta limit.", LoggedCandidateHop(&$candidate)); log_trace!(logger, "Ignoring {} due to exceeding CLTV delta limit.", LoggedCandidateHop(&$candidate));
if let Some(_) = first_hop_details {
log_trace!(logger,
"First hop candidate cltv_expiry_delta: {}. Limit: {}",
hop_total_cltv_delta,
max_total_cltv_expiry_delta,
);
}
} }
num_ignored_cltv_delta_limit += 1; num_ignored_cltv_delta_limit += 1;
} else if payment_failed_on_this_channel { } else if payment_failed_on_this_channel {
@ -1832,6 +1847,13 @@ where L::Target: Logger {
log_trace!(logger, log_trace!(logger,
"Ignoring {} to avoid overpaying to meet htlc_minimum_msat limit.", "Ignoring {} to avoid overpaying to meet htlc_minimum_msat limit.",
LoggedCandidateHop(&$candidate)); LoggedCandidateHop(&$candidate));
if let Some(details) = first_hop_details {
log_trace!(logger,
"First hop candidate next_outbound_htlc_minimum_msat: {}",
details.next_outbound_htlc_minimum_msat,
);
}
} }
num_ignored_avoid_overpayment += 1; num_ignored_avoid_overpayment += 1;
hit_minimum_limit = true; hit_minimum_limit = true;
@ -1893,6 +1915,14 @@ where L::Target: Logger {
if total_fee_msat > max_total_routing_fee_msat { if total_fee_msat > max_total_routing_fee_msat {
if should_log_candidate { if should_log_candidate {
log_trace!(logger, "Ignoring {} due to exceeding max total routing fee limit.", LoggedCandidateHop(&$candidate)); log_trace!(logger, "Ignoring {} due to exceeding max total routing fee limit.", LoggedCandidateHop(&$candidate));
if let Some(_) = first_hop_details {
log_trace!(logger,
"First hop candidate routing fee: {}. Limit: {}",
total_fee_msat,
max_total_routing_fee_msat,
);
}
} }
num_ignored_total_fee_limit += 1; num_ignored_total_fee_limit += 1;
} else { } else {
@ -1988,6 +2018,13 @@ where L::Target: Logger {
log_trace!(logger, log_trace!(logger,
"Ignoring {} due to its htlc_minimum_msat limit.", "Ignoring {} due to its htlc_minimum_msat limit.",
LoggedCandidateHop(&$candidate)); LoggedCandidateHop(&$candidate));
if let Some(details) = first_hop_details {
log_trace!(logger,
"First hop candidate next_outbound_htlc_minimum_msat: {}",
details.next_outbound_htlc_minimum_msat,
);
}
} }
num_ignored_htlc_minimum_msat_limit += 1; num_ignored_htlc_minimum_msat_limit += 1;
} }