mirrors/rust-lightning
1
0
Fork 0
mirror of https://github.com/lightningdevkit/rust-lightning.git synced 2025-03-03 18:47:47 +01:00
Code Issues Projects Releases Packages Wiki Activity

Bump MSRV to 1.30.0

Browse source 
We wanted to bump to 1.29 to continue to support mrustc bootstrapping, but on 1.29
there's a bug preventing us from compiling the lightning package only, thus parts
of lightning-net-tokio cause a compilation error.

The advantage of bumping the MSRV is an improved borrow checker which should
enable improved code quality, and not having jump through weird hoops sometimes
to get 1.22 working.
This commit is contained in:
Valentine Wallace 2020-08-19 15:35:37 -04:00
parent d0b4f521e1
commit 0ac5697bb8
No known key found for this signature in database
GPG key ID: F88EC43B95E601B8
3 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/build.yml vendored
View file

@ -8,8 +8,8 @@ jobs:
matrix: matrix:
toolchain: [ stable, toolchain: [ stable,
beta, beta,
# 1.22.0 is MSRV for rust-lightning in general: # 1.30.0 is MSRV for Rust-Lightning
1.22.0, 1.30.0,
# 1.34.2 is Debian stable # 1.34.2 is Debian stable
1.34.2, 1.34.2,
# 1.39.0 is MSRV for lightning-net-tokio and generates coverage # 1.39.0 is MSRV for lightning-net-tokio and generates coverage

4
.travis.yml
View file

@ -2,8 +2,8 @@ language: rust
rust: rust:
- stable - stable
- beta - beta
# 1.22.0 is MSRV for rust-lightning in general: # 1.30.0 is MSRV for rust-lightning in general:
- 1.22.0 - 1.30.0
# 1.34.2 is Debian stable # 1.34.2 is Debian stable
- 1.34.2 - 1.34.2
# 1.39.0 is MSRV for lightning-net-tokio and generates coverage # 1.39.0 is MSRV for lightning-net-tokio and generates coverage

3
CONTRIBUTING.md
View file

@ -50,7 +50,8 @@ be covered by functional tests.
When refactoring, structure your PR to make it easy to review and don't When refactoring, structure your PR to make it easy to review and don't
hestitate to split it into multiple small, focused PRs. hestitate to split it into multiple small, focused PRs.
The Minimal Supported Rust Version is 1.22.0 (enforced by our Travis). The Minimal Supported Rust Version is 1.30.0 (enforced by our Travis and
GitHub Actions).
Commits should cover both the issue fixed and the solution's rationale. Commits should cover both the issue fixed and the solution's rationale.
These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind. These [guidelines](https://chris.beams.io/posts/git-commit/) should be kept in mind.