mirrors/rust-lightning
1
0
Fork 0
mirror of https://github.com/lightningdevkit/rust-lightning.git synced 2025-02-24 15:02:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Use a smaller bit for UnknownFeature

Browse source 
When testing Bolt12Invoice unknown require feature handling, a large
feature bit can cause SendError::TooBigPacket when creating an onion
message. Use a smaller feature bit for UnknownFeature, which also has
the added benefit of reducing test output.
This commit is contained in:
Jeffrey Czyz 2024-07-31 15:12:40 -05:00
parent e4ca166e62
commit 05db67b5c3
No known key found for this signature in database
GPG key ID: 912EF12EA67705F5
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lightning-types/src/features.rs
View file

@ -567,7 +567,7 @@ mod sealed {
#[cfg(any(test, feature = "_test_utils"))]
define_feature!(
123456789,
12345,
UnknownFeature,
[
NodeContext,
@ -1117,7 +1117,7 @@ mod tests {
features.set_unknown_feature_required();
assert!(features.requires_unknown_bits());
assert!(features.supports_unknown_bits());
assert_eq!(features.required_unknown_bits_from(&ChannelFeatures::empty()), vec![123456788]);
assert_eq!(features.required_unknown_bits_from(&ChannelFeatures::empty()), vec![12344]);
let mut features = ChannelFeatures::empty();
features.set_unknown_feature_optional();
@ -1127,17 +1127,17 @@ mod tests {
let mut features = ChannelFeatures::empty();
features.set_unknown_feature_required();
features.set_custom_bit(123456786).unwrap();
features.set_custom_bit(12346).unwrap();
assert!(features.requires_unknown_bits());
assert!(features.supports_unknown_bits());
assert_eq!(
features.required_unknown_bits_from(&ChannelFeatures::empty()),
vec![123456786, 123456788]
vec![12344, 12346]
);
let mut limiter = ChannelFeatures::empty();
limiter.set_unknown_feature_optional();
assert_eq!(features.required_unknown_bits_from(&limiter), vec![123456786]);
assert_eq!(features.required_unknown_bits_from(&limiter), vec![12346]);
}
#[test]