RTL install fix (#3739)

* c-lightning-REST update to 0.10.2, fmt
* rtl: npm insatll with --legacy-peer-deps
* purge c-lightning-REST as well with RTL

CHANGES.md

@@ -14,7 +14,7 @@
 - Update: Bitcoin Core v24.0.1 [details](https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes/release-notes-24.0.1.md)
 - Update: LND v0.16.0-beta [details](https://github.com/lightningnetwork/lnd/releases/tag/v0.16.0-beta)
 - Update: Core Lightning v23.02 [details](https://github.com/ElementsProject/lightning/releases/tag/v23.02)
-- Update: C-lightningREST v0.10.1 [details](https://github.com/Ride-The-Lightning/c-lightning-REST/releases/tag/v0.10.1)
+- Update: C-lightningREST v0.10.2 [details](https://github.com/Ride-The-Lightning/c-lightning-REST/releases/tag/v0.10.2)
 - Update: Electrum Server in Rust (electrs) v0.9.11 [details](https://github.com/romanz/electrs/blob/master/RELEASE-NOTES.md#0911-jan-5-2023)
 - Update: Lightning Terminal v0.8.6-alpha [details](https://github.com/lightninglabs/lightning-terminal/releases/tag/v0.8.6-alpha)
 - Update: RTL v0.13.6 with update option [details](https://github.com/Ride-The-Lightning/RTL/releases/tag/v0.13.6)

home.admin/config.scripts/bonus.rtl.sh

@@ -162,7 +162,7 @@ if [ "$1" = "install" ]; then
   # install
   echo "# Running npm install ..."
   export NG_CLI_ANALYTICS=false
-  sudo -u rtl npm install --omit=dev
+  sudo -u rtl npm install --omit=dev --legacy-peer-deps
   if ! [ $? -eq 0 ]; then
     echo "# FAIL - npm install did not run correctly - deleting code and exit"
     sudo rm -r /home/rtl/RTL
@@ -251,7 +251,7 @@ if [ "$1" = "1" ] || [ "$1" = "on" ]; then
   fi
 
   echo "# Updating Firewall"
-  sudo ufw allow ${RTLHTTP} comment "${systemdService} HTTP"
+  sudo ufw allow "${RTLHTTP}" comment "${systemdService} HTTP"
   sudo ufw allow $((RTLHTTP + 1)) comment "${systemdService} HTTPS"
   echo
 
@@ -546,17 +546,17 @@ if [ "$1" = "0" ] || [ "$1" = "off" ]; then
 
   # only if 'purge' is an additional parameter (other instances/services might need this)
   if [ "$(echo "$@" | grep -c purge)" -gt 0 ]; then
-    home/admin/config.scripts/bonus.rtl.sh uninstall
+    /home/admin/config.scripts/bonus.rtl.sh uninstall
     if [ $LNTYPE = cl ]; then
-      /home/admin/config.scripts/cl.rest.sh off ${CHAIN}
+      /home/admin/config.scripts/cl.rest.sh off ${CHAIN} purge
     fi
     echo "# Delete all configs"
     sudo rm -rf /mnt/hdd/app-data/rtl
   fi
 
   # close ports on firewall
-  sudo ufw deny "${RTLHTTP}"
-  sudo ufw deny $((RTLHTTP + 1))
+  sudo ufw delete allow "${RTLHTTP}"
+  sudo ufw delete allow $((RTLHTTP + 1))
 
   # needed for API/WebUI as signal that install ran thru
   echo "result='OK'"
@@ -589,7 +589,7 @@ if [ "$1" = "update" ]; then
       # https://github.com/Ride-The-Lightning/RTL#or-update-existing-dependencies
       echo "# Running npm install ..."
       export NG_CLI_ANALYTICS=false
-      sudo -u rtl npm install --omit=dev
+      sudo -u rtl npm install --omit=dev --legacy-peer-deps
       if ! [ $? -eq 0 ]; then
         echo "# FAIL - npm install did not run correctly - deleting code and exit"
         sudo rm -r /home/rtl/RTL
@@ -605,7 +605,7 @@ if [ "$1" = "update" ]; then
     sudo -u rtl git pull -p
     echo "# Running npm install ..."
     export NG_CLI_ANALYTICS=false
-    sudo -u rtl npm install --only=prod --logLevel warn
+    sudo -u rtl npm install --omit=dev --legacy-peer-deps
     if ! [ $? -eq 0 ]; then
       echo "# FAIL - npm install did not run correctly - deleting code and exit"
       sudo rm -r /home/rtl/RTL
@@ -615,7 +615,7 @@ if [ "$1" = "update" ]; then
       echo
     fi
     currentRTLcommit=$(
-      cd /home/rtl/RTL
+      cd /home/rtl/RTL || exit 1
       git describe --tags
     )
     echo "# Updated RTL to $currentRTLcommit"

home.admin/config.scripts/cl.rest.sh

@@ -1,7 +1,7 @@
 #!/bin/bash
 
 # https://github.com/Ride-The-Lightning/c-lightning-REST/releases/
-CLRESTVERSION="v0.10.1"
+CLRESTVERSION="v0.10.2"
 
 # help
 if [ $# -eq 0 ] || [ "$1" = "-h" ] || [ "$1" = "--help" ]; then
@@ -163,7 +163,7 @@ if [ "$1" = on ]; then
     \"RPCCOMMANDS\": [\"*\"]
 }" | sudo -u bitcoin tee ./${CLNETWORK}/cl-rest-config.json
 
-  # copy clrest to a CLNETWORK subdor to make parallel networks possible
+  # copy clrest to a CLNETWORK subdir to make parallel networks possible
   sudo -u bitcoin mkdir /home/bitcoin/c-lightning-REST/${CLNETWORK}
   sudo -u bitcoin cp -r /home/bitcoin/c-lightning-REST/* \
     /home/bitcoin/c-lightning-REST/${CLNETWORK}