From e84ec7dd8673f97463dd8ace062670c82b143088 Mon Sep 17 00:00:00 2001 From: softsimon Date: Fri, 20 Mar 2020 02:07:12 +0700 Subject: [PATCH] Fixed sorting issue that caused the median calculation bug. --- backend/src/api/blocks.ts | 1 - backend/src/api/mempool-blocks.ts | 7 ++----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/backend/src/api/blocks.ts b/backend/src/api/blocks.ts index 7ee902a69..f93c89c77 100644 --- a/backend/src/api/blocks.ts +++ b/backend/src/api/blocks.ts @@ -92,7 +92,6 @@ class Blocks { private median(numbers: number[]) { let medianNr = 0; const numsLen = numbers.length; - numbers.sort(); if (numsLen % 2 === 0) { medianNr = (numbers[numsLen / 2 - 1] + numbers[numsLen / 2]) / 2; } else { diff --git a/backend/src/api/mempool-blocks.ts b/backend/src/api/mempool-blocks.ts index ec6fa3cb2..a142d50da 100644 --- a/backend/src/api/mempool-blocks.ts +++ b/backend/src/api/mempool-blocks.ts @@ -47,16 +47,14 @@ class MempoolBlocks { } private dataToMempoolBlocks(transactions: TransactionExtended[], blockSize: number, blockVSize: number, blocksIndex: number): MempoolBlock { - let rangeLength = 3; + let rangeLength = 4; if (blocksIndex === 0) { rangeLength = 8; } if (transactions.length > 4000) { - rangeLength = 5; + rangeLength = 6; } else if (transactions.length > 10000) { rangeLength = 8; - } else if (transactions.length > 25000) { - rangeLength = 10; } return { blockSize: blockSize, @@ -71,7 +69,6 @@ class MempoolBlocks { private median(numbers: number[]) { let medianNr = 0; const numsLen = numbers.length; - numbers.sort(); if (numsLen % 2 === 0) { medianNr = (numbers[numsLen / 2 - 1] + numbers[numsLen / 2]) / 2; } else {