mirrors/mempool
1
0
Fork 0
mirror of https://github.com/mempool/mempool.git synced 2025-02-24 06:47:52 +01:00
Code Issues Projects Releases Wiki Activity

Send 404 when accessing non existing mining pool

Browse source
This commit is contained in:
nymkappa 2022-03-30 16:27:17 +09:00
parent 796db0de4b
commit ccafe4a066
No known key found for this signature in database
GPG key ID: E155910B16E8BD04
2 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
backend/src/repositories/PoolsRepository.ts
View file

@ -80,7 +80,7 @@ class PoolsRepository {
/** /**
* Get mining pool statistics for one pool * Get mining pool statistics for one pool
*/ */
public async $getPool(slug: string): Promise<PoolTag> { public async $getPool(slug: string): Promise<PoolTag | null> {
const query = ` const query = `
SELECT * SELECT *
FROM pools FROM pools
@ -93,6 +93,11 @@ class PoolsRepository {
const [rows] = await connection.query(query, [slug]); const [rows] = await connection.query(query, [slug]);
connection.release(); connection.release();
if (rows.length < 1) {
logger.debug(`$getPool(): slug ${slug} does not match any known pool`);
return null;
}
rows[0].regexes = JSON.parse(rows[0].regexes); rows[0].regexes = JSON.parse(rows[0].regexes);
rows[0].addresses = JSON.parse(rows[0].addresses); rows[0].addresses = JSON.parse(rows[0].addresses);

18
backend/src/routes.ts
View file

@ -545,7 +545,11 @@ class Routes {
res.setHeader('Expires', new Date(Date.now() + 1000 * 60).toUTCString()); res.setHeader('Expires', new Date(Date.now() + 1000 * 60).toUTCString());
res.json(stats); res.json(stats);
} catch (e) { } catch (e) {
res.status(500).send(e instanceof Error ? e.message : e); if (e instanceof Error && e.message.indexOf('This mining pool does not exist') > -1) {
res.status(404).send(e.message);
} else {
res.status(500).send(e instanceof Error ? e.message : e);
}
} }
} }
@ -560,7 +564,11 @@ class Routes {
res.setHeader('Expires', new Date(Date.now() + 1000 * 60).toUTCString()); res.setHeader('Expires', new Date(Date.now() + 1000 * 60).toUTCString());
res.json(poolBlocks); res.json(poolBlocks);
} catch (e) { } catch (e) {
res.status(500).send(e instanceof Error ? e.message : e); if (e instanceof Error && e.message.indexOf('This mining pool does not exist') > -1) {
res.status(404).send(e.message);
} else {
res.status(500).send(e instanceof Error ? e.message : e);
}
} }
} }
@ -616,7 +624,11 @@ class Routes {
hashrates: hashrates, hashrates: hashrates,
}); });
} catch (e) { } catch (e) {
res.status(500).send(e instanceof Error ? e.message : e); if (e instanceof Error && e.message.indexOf('This mining pool does not exist') > -1) {
res.status(404).send(e.message);
} else {
res.status(500).send(e instanceof Error ? e.message : e);
}
} }
} }