From 5914d99283dd82cf3b9b2d5d360992ab7f744210 Mon Sep 17 00:00:00 2001
From: softsimon <softsimon@protonmail.com>
Date: Mon, 5 Apr 2021 23:45:47 +0400
Subject: [PATCH] Bugfix: Ancestors are not able to increase fee of descendants
 fixes #426

---
 backend/src/api/common.ts                                    | 5 +++--
 .../app/components/transaction/transaction.component.html    | 5 +----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/backend/src/api/common.ts b/backend/src/api/common.ts
index 130e0205d..dd3d84e48 100644
--- a/backend/src/api/common.ts
+++ b/backend/src/api/common.ts
@@ -81,9 +81,10 @@ export class Common {
 
   static setRelativesAndGetCpfpInfo(tx: TransactionExtended, memPool: { [txid: string]: TransactionExtended }): CpfpInfo {
     const parents = this.findAllParents(tx, memPool);
+    const lowerFeeParents = parents.filter((parent) => parent.feePerVsize < tx.feePerVsize);
 
-    let totalWeight = tx.weight + parents.reduce((prev, val) => prev + val.weight, 0);
-    let totalFees = tx.fee + parents.reduce((prev, val) => prev + val.fee, 0);
+    let totalWeight = tx.weight + lowerFeeParents.reduce((prev, val) => prev + val.weight, 0);
+    let totalFees = tx.fee + lowerFeeParents.reduce((prev, val) => prev + val.fee, 0);
 
     tx.ancestors = parents
       .map((t) => {
diff --git a/frontend/src/app/components/transaction/transaction.component.html b/frontend/src/app/components/transaction/transaction.component.html
index bf0f9a3c3..d80c6c1d0 100644
--- a/frontend/src/app/components/transaction/transaction.component.html
+++ b/frontend/src/app/components/transaction/transaction.component.html
@@ -177,10 +177,7 @@
                 </td>
                 <td class="d-none d-lg-table-cell">{{ cpfpTx.weight / 4 | vbytes: 2 }}</td>
                 <td>{{ roundToOneDecimal(cpfpTx) | number : '1.1-1' }} <span i18n="shared.sat-vbyte|sat/vB">sat/vB</span></td>
-                <td class="d-none d-lg-table-cell"><fa-icon *ngIf="roundToOneDecimal(cpfpTx) > tx.feePerVsize; else arrowDown" class="arrow-green" [icon]="['fas', 'angle-double-up']" [fixedWidth]="true"></fa-icon></td>
-                <ng-template #arrowDown>
-                  <fa-icon *ngIf="roundToOneDecimal(cpfpTx) !== tx.feePerVsize" class="arrow-red" [icon]="['fas', 'angle-double-down']" [fixedWidth]="true"></fa-icon>
-                </ng-template>
+                <td class="d-none d-lg-table-cell"><fa-icon *ngIf="roundToOneDecimal(cpfpTx) < tx.feePerVsize" class="arrow-red" [icon]="['fas', 'angle-double-down']" [fixedWidth]="true"></fa-icon></td>
               </tr>
             </ng-template>
           </tbody>