From 3801f988ba9e612c9619aeb65d0290a95c9647b0 Mon Sep 17 00:00:00 2001
From: nymkappa <vialjoris@hotmail.com>
Date: Fri, 2 Sep 2022 16:17:48 +0200
Subject: [PATCH] Show '-' when value is not defined in channel page

---
 .../channel/channel-box/channel-box.component.html  | 10 +++++-----
 .../app/shared/components/sats/sats.component.html  | 13 ++++++++-----
 .../app/shared/components/sats/sats.component.ts    |  1 +
 3 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/frontend/src/app/lightning/channel/channel-box/channel-box.component.html b/frontend/src/app/lightning/channel/channel-box/channel-box.component.html
index 30d1a3585..8b486eff5 100644
--- a/frontend/src/app/lightning/channel/channel-box/channel-box.component.html
+++ b/frontend/src/app/lightning/channel/channel-box/channel-box.component.html
@@ -19,31 +19,31 @@
         <tr>
           <td i18n="address.total-sent">Fee rate</td>
           <td>
-            {{ channel.fee_rate }} <span class="symbol">ppm ({{ channel.fee_rate / 10000 | number }}%)</span>
+            {{ channel.fee_rate ?? '-' }} <span class="symbol">ppm ({{ channel.fee_rate / 10000 | number }}%)</span>
           </td>
         </tr>
         <tr>
           <td i18n="address.total-sent">Base fee</td>
           <td>
-            <app-sats [satoshis]="channel.base_fee_mtokens / 1000" digitsInfo="1.0-2"></app-sats>
+            <app-sats [valueOverride]="!channel.base_fee_mtokens ? '- ' : undefined" [satoshis]="channel.base_fee_mtokens / 1000" digitsInfo="1.0-2"></app-sats>
           </td>
         </tr>
         <tr>
           <td i18n="address.total-sent">Min HTLC</td>
           <td>
-            <app-sats [satoshis]="channel.min_htlc_mtokens / 1000"></app-sats>
+            <app-sats [valueOverride]="!channel.min_htlc_mtokens ? '- ' : undefined" [satoshis]="channel.min_htlc_mtokens / 1000"></app-sats>
           </td>
         </tr>
         <tr>
           <td i18n="address.total-sent">Max HTLC</td>
           <td>
-            <app-sats [satoshis]="channel.max_htlc_mtokens / 1000"></app-sats>
+            <app-sats [valueOverride]="!channel.max_htlc_mtokens ? '- ' : undefined" [satoshis]="channel.max_htlc_mtokens / 1000"></app-sats>
           </td>
         </tr>
         <tr>
           <td i18n="address.total-sent">Timelock delta</td>
           <td>
-            <ng-container *ngTemplateOutlet="blocksPlural; context: {$implicit: channel.cltv_delta }"></ng-container>
+            <ng-container *ngTemplateOutlet="blocksPlural; context: {$implicit: channel.cltv_delta ?? '-' }"></ng-container>
           </td>
         </tr>
       </tbody>
diff --git a/frontend/src/app/shared/components/sats/sats.component.html b/frontend/src/app/shared/components/sats/sats.component.html
index a648cdfcb..dada43692 100644
--- a/frontend/src/app/shared/components/sats/sats.component.html
+++ b/frontend/src/app/shared/components/sats/sats.component.html
@@ -1,5 +1,8 @@
-&lrm;{{ addPlus && satoshis >= 0 ? '+' : '' }}{{ satoshis | number : digitsInfo }}
-<span class="symbol"><ng-template [ngIf]="network === 'liquid'">L-</ng-template>
-<ng-template [ngIf]="network === 'liquidtestnet'">tL-</ng-template>
-<ng-template [ngIf]="network === 'testnet'">t-</ng-template>
-<ng-template [ngIf]="network === 'signet'">s-</ng-template>sats</span>
+<span *ngIf="valueOverride !== undefined">{{ valueOverride }}</span>
+<span *ngIf="valueOverride === undefined">&lrm;{{ addPlus && satoshis >= 0 ? '+' : '' }}{{ satoshis | number : digitsInfo }}</span>
+<span class="symbol">
+  <ng-template [ngIf]="network === 'liquid'">L-</ng-template>
+  <ng-template [ngIf]="network === 'liquidtestnet'">tL-</ng-template>
+  <ng-template [ngIf]="network === 'testnet'">t-</ng-template>
+  <ng-template [ngIf]="network === 'signet'">s-</ng-template>sats
+</span>
\ No newline at end of file
diff --git a/frontend/src/app/shared/components/sats/sats.component.ts b/frontend/src/app/shared/components/sats/sats.component.ts
index d9801d249..39be66ecd 100644
--- a/frontend/src/app/shared/components/sats/sats.component.ts
+++ b/frontend/src/app/shared/components/sats/sats.component.ts
@@ -11,6 +11,7 @@ export class SatsComponent implements OnInit {
   @Input() satoshis: number;
   @Input() digitsInfo = '1.0-0';
   @Input() addPlus = false;
+  @Input() valueOverride: string | undefined = undefined;
 
   network = '';
   stateSubscription: Subscription;