mirror of
https://github.com/lightningnetwork/lnd.git
synced 2024-11-19 09:53:54 +01:00
d6d9ec6aa5
Previously the invoice registry wasn't aware of replayed htlcs. This was dealt with by keeping the invoice accept/settle logic idempotent, so that a replay wouldn't have an effect. This mechanism has two limitations: 1. No accurate tracking of the total amount paid to an invoice. The total amount couldn't just be increased with every htlc received, because it could be a replay which would lead to counting the htlc amount multiple times. Therefore the total amount was set to the amount of the first htlc that was received, even though there may have been multiple htlcs paying to the invoice. 2. Impossible to check htlc expiry consistently for hodl invoices. When an htlc is new, its expiry needs to be checked against the invoice cltv delta. But for a replay, that check must be skipped. The htlc was accepted in time, the invoice was moved to the accepted state and a replay some blocks later shouldn't lead to that htlc being cancelled. Because the invoice registry couldn't recognize replays, it stopped checking htlc expiry heights when the invoice reached the accepted state. This prevents hold htlcs from being cancelled after a restart. But unfortunately this also caused additional htlcs to be accepted on an already accepted invoice without their expiry being checked. In this commit, the invoice registry starts to persistently track htlcs so that replays can be recognized. For replays, an htlc resolution action is returned early. This fixes both limitations mentioned above. |
||
|---|---|---|
| .. | ||
| briefcase_test.go | ||
| briefcase.go | ||
| chain_arbitrator_test.go | ||
| chain_arbitrator.go | ||
| chain_watcher_test.go | ||
| chain_watcher.go | ||
| channel_arbitrator_test.go | ||
| channel_arbitrator.go | ||
| commit_sweep_resolver.go | ||
| contract_resolvers.go | ||
| htlc_incoming_contest_resolver.go | ||
| htlc_incoming_resolver_test.go | ||
| htlc_outgoing_contest_resolver.go | ||
| htlc_success_resolver.go | ||
| htlc_timeout_resolver_test.go | ||
| htlc_timeout_resolver.go | ||
| interfaces.go | ||
| log.go | ||
| mock_registry_test.go | ||
| utils_test.go | ||