Oliver Gugger
bdda2aa059
docs+github+scripts: remove submodule update check
...
Because we want to avoid local replace directives (as they make it easy
to screw up things for external applications that use lnd as a library
without us noticing), we're going to switch over to a new process.
See section "Use of Golang submodules" in the code contribution
guideline.
2022-03-22 14:17:26 +01:00
Oliver Gugger
04bbbea9a7
Merge pull request #6228 from guggero/contribution-guidelines
...
docs: rewrite and regroup formatting rules [skip ci]
2022-02-03 10:02:02 +01:00
Neil-LL
b398d64393
Tiny Formatting Change
2022-02-02 16:14:42 +02:00
Oliver Gugger
b667f7a89c
docs: rewrite and regroup formatting rules [skip ci]
2022-02-02 15:11:43 +01:00
Oliver Gugger
3c324ad058
docs: remove protobuf compilation section from guidelines
...
Since we're now enforcing the formatting of the protobuf files through a
CI step, this explicit mention in the docs is no longer needed.
2022-02-02 15:10:24 +01:00
positiveblue
d2143bd40f
docs: add guidelines for func declarations [skip ci]
2022-02-01 08:31:19 -08:00
carla
0f8d314ee7
github: simplify PR template and add more sections [skip ci]
2022-01-28 09:50:02 +02:00
Dimitris Apostolou
530a2059e5
multi: Fix typos [skip ci]
2022-01-24 12:19:02 +02:00
3nprob
258c1987e8
docs: Fix broken link to lnd_test.go
2022-01-11 14:08:19 +01:00
Naveen
4de2ec1264
docs: sign your git commits [skip-ci]
...
https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2014-May/005877.html
2022-01-11 14:08:18 +01:00
Elle Mouton
b829be133a
docs: add review bot commands to guidelines [skip ci]
...
Add the review bot commands to the contribution guidelines so that we
can link to these commands from the bots readme.
2021-12-15 10:36:36 +02:00
Olaoluwa Osuntokun
26169e8e16
Merge pull request #5627 from Zero-1729/patch-3
...
trivial: minor grammar and typo fix [skip ci]
2021-08-30 19:23:43 -07:00
yyforyongyu
81df01acca
docs: explicitly set line wrap rules for error messages [skip ci]
2021-08-16 11:48:33 +08:00
Abubakar Nur Khalil
e70349644b
trivial: minor grammar and typo fix [skip ci]
2021-08-13 03:36:40 +01:00
Oliver Gugger
07fa98fca5
Merge pull request #5614 from yyforyongyu/skip-release-note
...
trivial: skip release note for trivial fixes
2021-08-11 11:50:15 +02:00
Olaoluwa Osuntokun
85e3dd3e45
docs: add release notes to PR checklist and contributor guidelines
2021-08-10 15:56:17 -07:00
yyforyongyu
b64f413718
trivial: skip release note for trivial fixes [skip ci]
2021-08-11 00:17:10 +08:00
Oliver Gugger
dd749fe580
lnrpc: update grpc-gateway library to v2
2021-07-27 13:09:59 +02:00
Zero-1729
712643e2aa
docs: minor fixes to contribution guidelines
2021-07-20 14:58:45 +01:00
Oliver Gugger
9642012643
docs: clean up code contribution guideline syntax
2021-01-22 09:14:12 +01:00
Oliver Gugger
2c634bfaf3
docs: unify code and shell cmd blocks
2021-01-22 09:14:09 +01:00
Joost Jager
d1e049fa68
docs: describe log levels
2020-06-12 11:22:35 +02:00
Oliver Gugger
ce4591437b
docs: link to lnrpc README, remove json_name
2020-05-08 14:34:03 +02:00
Sebastian Falbesoner
11638845e4
docs: fix tab size (8 spaces) in contribution guidelines
2020-05-01 20:25:53 +02:00
Vignesh Karthikeyan
2520d0a996
Fix Formatting of *Wrong*
...
There is a spacing issues, and thus a formatting
issue, in the file, code_contribution_guidelines.md
2019-10-19 16:48:32 +05:30
Wilmer Paulino
73791e15a1
Merge pull request #2830 from philippgille/feature/update-contribution-checklist
...
docs: update contribution checklist
2019-04-05 15:46:34 -07:00
Philipp Gille
dd3f48eda5
docs: update contribution checklist
...
- Update Go version 1.11 to 1.12
- Fix broken link in GitHub PR template
- Fix inconsistent number of spaces after checkbox
- Add proper link to "Ideal Git Commit structure"
2019-03-24 11:37:57 +01:00
Philipp Gillé
8b568296df
docs: fix typo
2019-03-23 17:03:40 +01:00
Olaoluwa Osuntokun
9cda05ee8a
docs: add new section to contribution guidelines for go mod replace
...
In this commit, we add a new section to the code contribution guidelines
explaining how to use `go mod replace`. This will be a common procedure
for any developer that needs to make a change in any of our sister
projects, so it's nice to have this outlined in a single place.
2019-01-17 16:50:06 -08:00
Olaoluwa Osuntokun
af306e2360
docs: expand contributor checklist w/ commit structure
2018-12-19 17:02:25 -08:00
Olaoluwa Osuntokun
49da4a60aa
docs: update contribution guidelines with new merge commit policy
2018-12-18 20:59:58 -08:00
Olaoluwa Osuntokun
a76affae91
docs: replace golint with make lint in contributor guidelines
2018-12-18 20:59:56 -08:00
Olaoluwa Osuntokun
0d5eef4f30
docs: in contributor guidelines, use make check not go test
2018-12-18 20:59:54 -08:00
Olaoluwa Osuntokun
ce39910f96
docs: add section in contribution guidelines describing fixup commits
2018-12-18 20:59:53 -08:00
Olaoluwa Osuntokun
d1571badaf
docs: add section in contribution guidelines for unique lnd code style
2018-12-18 20:59:52 -08:00
Olaoluwa Osuntokun
0dc9b35a1a
docs: add section in testing pointing towards Makefile docs
2018-12-18 20:59:51 -08:00
Olaoluwa Osuntokun
516a48741f
docs: update contribution guidelines to add section on commit structure
2018-12-18 20:59:46 -08:00
Olaoluwa Osuntokun
e6c22d658d
docs: update contribution guidelines to reference latest version of Go
...
with '#' will be ignored, and an empty message aborts the commit.
2018-11-28 20:13:50 -08:00
Carlos Garcia Ortiz
0f03120a46
Docs: code_contribution_guidelines change link
2018-11-27 10:20:06 +01:00
Oliver Gugger
45ccace41c
docs: add line wrap to contribution checklist
2018-05-07 19:21:03 +03:00
yohei okada
7a50097dec
docs: update Go version to 1.9 in Contribution Checklist ( #1095 )
...
According to install.md, the minimum version of Go supported at the
moment is 1.9, so update the Go version referenced in Contribution
Checklist to 1.9 as well.
2018-04-17 18:58:46 -07:00
yohei okada
bd631a43bb
docs: Update old link to networkHarness framework ( #919 )
2018-03-22 12:42:11 -07:00
practicalswift
a93736d21e
multi: comprehensive typo fixes across all packages
2018-02-06 19:11:11 -08:00
Wilmer Paulino
e2af9a6897
docs: clarify how to generate protobuf definitions
2018-01-07 01:54:28 -05:00
hackerrdave
ad40207126
provide formatting for lnd references
2018-01-03 11:39:35 +01:00
Dimitris Tsapakidis
9c145d4071
docs: fix typos
...
Multiple typos fixed in 4 documents.
2017-12-02 18:59:11 -08:00
Olaoluwa Osuntokun
2b411051e1
docs: update contribution guidelines with newest proto repos
2017-08-22 00:53:43 -07:00
Olaoluwa Osuntokun
424ccccc2f
docs: correct mistake in protoc version used
2017-06-07 16:52:58 -07:00
Marty Jones
18052f9f19
multi: various formatting fixes after changes to Github flavored markdown
2017-03-27 16:20:31 -07:00
Olaoluwa Osuntokun
b4fff97d14
docs: specify protoc version and json_name usage
2017-02-27 21:04:52 -06:00
