4 commits

Author	SHA1	Message	Date
Keagan McClelland	61191a576d	peer: make PingManager.Stop infallible	2024-05-21 13:29:31 -07:00
Olaoluwa Osuntokun	185119f5c3	peer: refactor main event loop for ping handler ... The error was never used as the init couldn't return an error, so we do away with that. We also modify the main event loop dispatch to more closely match other areas of the codebase.	2024-01-22 18:20:30 -08:00
Olaoluwa Osuntokun	b5cbeb4ad7	peer: make PingManager disconnect call async ... In this commit, we make all calls to disconnect after a ping/pong violation is detected in the `PingManager` async. We do this to avoid circular waiting that may occur if the disconnect call back ends up waiting on the peer goroutine to be torn down. If this happens, then the peer goroutine will be blocked on the ping manager fully tearing down, which is blocked on the peer disconnect succeeding. This is a similar class of issue we've delt with recently as pertains to the peer and the server: sync all back execution must not lead to a circular waiting loop. Fixes #8379	2024-01-22 18:20:23 -08:00
Keagan McClelland	99226e37ef	peer: Add machinery to track the state and validity of remote pongs ... This commit refactors some of the bookkeeping around the ping logic inside of the Brontide. If the pong response is noncompliant with the spec or if it times out, we disconnect from the peer.	2023-10-19 09:26:45 -07:00