From f96866915b0770532d606cccfc0bcc1c3c209aa4 Mon Sep 17 00:00:00 2001 From: positiveblue Date: Mon, 8 Aug 2022 10:11:06 -0700 Subject: [PATCH] feature: remove `ScidAliasOptional` dependency on `ExplicitChannelTypeOptional` The [spec](https://github.com/lightning/bolts/blob/master/09-features.md) does not specify a dependency between `ScidAliasOptional` (47) and `ExplicitChannelTypeOptional` (45). This bug lead to some connectivity issues with peers not setting the 45 feature bit while setting the 47. The issue [6802](https://github.com/lightningnetwork/lnd/issues/6802) is an example of this. --- feature/deps.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/feature/deps.go b/feature/deps.go index 542732eba..8e1d8ac09 100644 --- a/feature/deps.go +++ b/feature/deps.go @@ -72,9 +72,6 @@ var deps = depDesc{ lnwire.KeysendOptional: { lnwire.TLVOnionPayloadOptional: {}, }, - lnwire.ScidAliasOptional: { - lnwire.ExplicitChannelTypeOptional: {}, - }, lnwire.ZeroConfOptional: { lnwire.ScidAliasOptional: {}, },