mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2024-11-19 01:43:16 +01:00
Code Issues Projects Releases Wiki Activity

chainntnfs: stop lnd when received witness stack is empty

Browse Source 
This commit uses `Criticalf` to gracefully stop `lnd` when the received
witness data is empty.
This commit is contained in:
yyforyongyu 2023-08-18 17:59:47 +08:00
parent 28c3c835bf
commit ee883c332f
No known key found for this signature in database
GPG Key ID: 9BCD95C4FF296868
2 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
chainntnfs/mempool.go
View File

@ -223,11 +223,19 @@ func (m *MempoolNotifier) findRelevantInputs(tx *btcutil.Tx) (inputsWithTx,
}
watchedInputs[*op] = details
// Sanity check the witness stack. If it's not empty, continue
// to next iteration.
if details.HasSpenderWitness() {
continue
}
// Return an error if the witness data is not present in the
// spending transaction.
if !details.HasSpenderWitness() {
return nil, ErrEmptyWitnessStack
}
Log.Criticalf("Found spending tx for outpoint=%v in mempool, "+
"but the transaction %v does not have witness",
op, details.SpendingTx.TxHash())
return nil, ErrEmptyWitnessStack
}
return watchedInputs, nil

9
chainntnfs/txnotifier.go
View File

@ -1305,10 +1305,13 @@ func (n *TxNotifier) updateSpendDetails(spendRequest SpendRequest,
// Return an error if the witness data is not present in the spending
// transaction.
//
// TODO(yy): maybe we should do a panic here instead to inform the user
// to reindex the bitcoind since it's critical error?
// panic("Please re-index your bitcoind...")
// NOTE: if the witness stack is empty, we will do a critical log which
// shuts down the node.
if !details.HasSpenderWitness() {
Log.Criticalf("Found spending tx for outpoint=%v, but the "+
"transaction %v does not have witness",
spendRequest.OutPoint, details.SpendingTx.TxHash())
return ErrEmptyWitnessStack
}