mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-02-23 22:46:40 +01:00
Code Issues Projects Releases Wiki Activity

itest: fix testOpenChannelUpdateFeePolicy

Browse source 
This commit fixes a misuse of `ht.Subtest`, where the nodes should
always be created inside the subtest.
This commit is contained in:
yyforyongyu 2024-10-29 16:00:04 +08:00
parent 010a4f1571
commit e7310ff1b6
No known key found for this signature in database
GPG key ID: 9BCD95C4FF296868
1 changed files with 12 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
itest/lnd_open_channel_test.go
View file

@ -238,19 +238,22 @@ func testOpenChannelUpdateFeePolicy(ht *lntest.HarnessTest) {
MaxHtlcMsat: defaultMaxHtlc,
}
// In this basic test, we'll need a third node, Carol, so we can forward
// a payment through the channel we'll open with the different fee
// policies.
alice := ht.NewNodeWithCoins("Alice", nil)
bob := ht.NewNode("Bob", nil)
carol := ht.NewNode("Carol", nil)
nodes := []*node.HarnessNode{alice, bob, carol}
runTestCase := func(ht *lntest.HarnessTest,
chanParams lntest.OpenChannelParams,
alicePolicy, bobPolicy *lnrpc.RoutingPolicy) {
// In this basic test, we'll need a third node, Carol, so we
// can forward a payment through the channel we'll open with
// the different fee policies.
alice := ht.NewNodeWithCoins("Alice", nil)
bob := ht.NewNode("Bob", nil)
carol := ht.NewNodeWithCoins("Carol", nil)
ht.EnsureConnected(alice, bob)
ht.EnsureConnected(alice, carol)
nodes := []*node.HarnessNode{alice, bob, carol}
// Create a channel Alice->Bob.
chanPoint := ht.OpenChannel(alice, bob, chanParams)
@ -287,19 +290,6 @@ func testOpenChannelUpdateFeePolicy(ht *lntest.HarnessTest) {
for i, feeScenario := range feeScenarios {
ht.Run(fmt.Sprintf("%d", i), func(t *testing.T) {
st := ht.Subtest(t)
st.EnsureConnected(alice, bob)
st.RestartNode(carol)
// Because we're using ht.Subtest(), we need to restart
// any node we have to refresh its runtime context.
// Otherwise, we'll get a "context canceled" error on
// RPC calls.
st.EnsureConnected(alice, carol)
// Send Carol enough coins to be able to open a channel
// to Alice.
st.FundCoins(btcutil.SatoshiPerBitcoin, carol)
runTestCase(
st, feeScenario,