From e547d2192069c6ebc07cd12e37deae1232ae6392 Mon Sep 17 00:00:00 2001
From: Elle Mouton <elle.mouton@gmail.com>
Date: Wed, 30 Oct 2024 13:23:18 +0200
Subject: [PATCH] multi: update log file max num and size defaults

---
 build/config.go                            | 4 ++--
 docs/release-notes/release-notes-0.19.0.md | 4 +++-
 sample-lnd.conf                            | 8 ++++----
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/build/config.go b/build/config.go
index e26168f80..fd3b01a94 100644
--- a/build/config.go
+++ b/build/config.go
@@ -15,10 +15,10 @@ const (
 
 	// DefaultMaxLogFiles is the default maximum number of log files to
 	// keep.
-	DefaultMaxLogFiles = 3
+	DefaultMaxLogFiles = 10
 
 	// DefaultMaxLogFileSize is the default maximum log file size in MB.
-	DefaultMaxLogFileSize = 10
+	DefaultMaxLogFileSize = 20
 )
 
 // LogConfig holds logging configuration options.
diff --git a/docs/release-notes/release-notes-0.19.0.md b/docs/release-notes/release-notes-0.19.0.md
index afba099e8..0e960bec8 100644
--- a/docs/release-notes/release-notes-0.19.0.md
+++ b/docs/release-notes/release-notes-0.19.0.md
@@ -94,7 +94,9 @@
   options to the `logging` config namespace under new `--logging.file.max-files` 
   and `--logging.files.max-file-size` options. The old options (`--maxlogfiles` 
   and `--maxlogfilesize`) will still work but deprecation notices have been 
-  added and they will be removed in a future release.
+  added and they will be removed in a future release. The defaults values for 
+  these options have also been increased from max 3 log files to 10 and from 
+  max 10 MB to 20 MB. 
  
 ## Breaking Changes
 ## Performance Improvements
diff --git a/sample-lnd.conf b/sample-lnd.conf
index 66a97b70f..6d64603e8 100644
--- a/sample-lnd.conf
+++ b/sample-lnd.conf
@@ -33,11 +33,11 @@
 ; DEPRECATED: Use logging.file.max-files instead.
 ; Number of logfiles that the log rotation should keep. Setting it to 0 disables
 ; deletion of old log files.
-; maxlogfiles=3
+; maxlogfiles=10
 ;
 ; DEPRECATED: Use logging.file.max-file-size instead.
 ; Max log file size in MB before it is rotated.
-; maxlogfilesize=10
+; maxlogfilesize=20
 
 ; Time after which an RPCAcceptor will time out and return false if
 ; it hasn't yet received a response.
@@ -990,10 +990,10 @@
 
 ; Number of log files that the log rotation should keep. Setting
 ; it to 0 disables deletion of old log files.
-; logging.file.max-files=3
+; logging.file.max-files=10
 
 ; Max log file size in MB before it is rotated.
-; logging.file.max-file-size=10
+; logging.file.max-file-size=20
 
 ; Compression algorithm to use when rotating logs.
 ; Default: