mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-02-24 06:47:44 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #7337 from yyforyongyu/fix-unit-test

Browse source 
bitcoindnotify: fix subtest closure in unit tests
This commit is contained in:
Oliver Gugger 2023-01-19 14:54:25 +01:00 • committed by GitHub
commit b5bf658780
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 30 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
chainntnfs/bitcoindnotify/bitcoind_test.go
View file

@ -105,8 +105,15 @@ func syncNotifierWithMiner(t *testing.T, notifier *BitcoindNotifier,
// TestHistoricalConfDetailsTxIndex ensures that we correctly retrieve // TestHistoricalConfDetailsTxIndex ensures that we correctly retrieve
// historical confirmation details using the backend node's txindex. // historical confirmation details using the backend node's txindex.
func TestHistoricalConfDetailsTxIndex(t *testing.T) { func TestHistoricalConfDetailsTxIndex(t *testing.T) {
testHistoricalConfDetailsTxIndex(t, true) t.Run("txindex enabled", func(st *testing.T) {
testHistoricalConfDetailsTxIndex(t, false) st.Parallel()
testHistoricalConfDetailsTxIndex(st, true)
})
t.Run("txindex disabled", func(st *testing.T) {
st.Parallel()
testHistoricalConfDetailsTxIndex(st, false)
})
} }
func testHistoricalConfDetailsTxIndex(t *testing.T, rpcPolling bool) { func testHistoricalConfDetailsTxIndex(t *testing.T, rpcPolling bool) {
@ -193,8 +200,15 @@ func testHistoricalConfDetailsTxIndex(t *testing.T, rpcPolling bool) {
// historical confirmation details using the set of fallback methods when the // historical confirmation details using the set of fallback methods when the
// backend node's txindex is disabled. // backend node's txindex is disabled.
func TestHistoricalConfDetailsNoTxIndex(t *testing.T) { func TestHistoricalConfDetailsNoTxIndex(t *testing.T) {
testHistoricalConfDetailsNoTxIndex(t, true) t.Run("txindex enabled", func(st *testing.T) {
testHistoricalConfDetailsNoTxIndex(t, false) st.Parallel()
testHistoricalConfDetailsNoTxIndex(st, true)
})
t.Run("txindex disabled", func(st *testing.T) {
st.Parallel()
testHistoricalConfDetailsNoTxIndex(st, false)
})
} }
func testHistoricalConfDetailsNoTxIndex(t *testing.T, rpcpolling bool) { func testHistoricalConfDetailsNoTxIndex(t *testing.T, rpcpolling bool) {

11
chainntnfs/test/bitcoind/bitcoind_test.go
View file

@ -12,6 +12,13 @@ import (
// TestInterfaces executes the generic notifier test suite against a bitcoind // TestInterfaces executes the generic notifier test suite against a bitcoind
// powered chain notifier. // powered chain notifier.
func TestInterfaces(t *testing.T) { func TestInterfaces(t *testing.T) {
chainntnfstest.TestInterfaces(t, "bitcoind") t.Run("bitcoind", func(st *testing.T) {
chainntnfstest.TestInterfaces(t, "bitcoind-rpc-polling") st.Parallel()
chainntnfstest.TestInterfaces(st, "bitcoind")
})
t.Run("bitcoind rpc polling", func(st *testing.T) {
st.Parallel()
chainntnfstest.TestInterfaces(st, "bitcoind-rpc-polling")
})
} }

3
docs/release-notes/release-notes-0.16.0.md
View file

@ -301,6 +301,9 @@ data.
refactored](https://github.com/lightningnetwork/lnd/pull/7174) to allow the refactored](https://github.com/lightningnetwork/lnd/pull/7174) to allow the
usage of new payment statuses. usage of new payment statuses.
* [Fixed a test closure](https://github.com/lightningnetwork/lnd/pull/7337)
issue found in `bitcoindnotify/bitcoind_test.go`.
## Watchtowers ## Watchtowers
* [Create a towerID-to-sessionID index in the wtclient DB to improve the * [Create a towerID-to-sessionID index in the wtclient DB to improve the