From eba49115998e765351a61d020c5b2b4fc381298d Mon Sep 17 00:00:00 2001 From: ziggie Date: Mon, 1 Apr 2024 20:00:54 +0100 Subject: [PATCH 1/2] lnd: fix sweepall argument call. maxFeeRate and feePerKw were switched in CraftSweepAllTx. --- rpcserver.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rpcserver.go b/rpcserver.go index 9c27b9343..ace0b70ff 100644 --- a/rpcserver.go +++ b/rpcserver.go @@ -1310,7 +1310,7 @@ func (r *rpcServer) SendCoins(ctx context.Context, // pay to the change address created above if we needed to // reserve any value, the rest will go to targetAddr. sweepTxPkg, err := sweep.CraftSweepAllTx( - maxFeeRate, feePerKw, uint32(bestHeight), nil, + feePerKw, maxFeeRate, uint32(bestHeight), nil, targetAddr, wallet, wallet, wallet.WalletController, r.server.cc.Signer, minConfs, ) @@ -1363,7 +1363,7 @@ func (r *rpcServer) SendCoins(ctx context.Context, } sweepTxPkg, err = sweep.CraftSweepAllTx( - maxFeeRate, feePerKw, uint32(bestHeight), + feePerKw, maxFeeRate, uint32(bestHeight), outputs, targetAddr, wallet, wallet, wallet.WalletController, r.server.cc.Signer, minConfs, From b019657d19c4f9dca0b8a862d4942bb206dbe66c Mon Sep 17 00:00:00 2001 From: ziggie Date: Mon, 1 Apr 2024 20:05:28 +0100 Subject: [PATCH 2/2] docs: add release-notes. --- docs/release-notes/release-notes-0.18.0.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/release-notes/release-notes-0.18.0.md b/docs/release-notes/release-notes-0.18.0.md index 6f13bb41c..f3413e963 100644 --- a/docs/release-notes/release-notes-0.18.0.md +++ b/docs/release-notes/release-notes-0.18.0.md @@ -109,6 +109,9 @@ * [Removed](https://github.com/lightningnetwork/lnd/pull/8577) some unreachable code +[Fixed](https://github.com/lightningnetwork/lnd/pull/8609) fixed a function +call where arguments were swapped. + # New Features ## Functional Enhancements