mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-03-04 09:48:19 +01:00
Code Issues Projects Releases Wiki Activity

test: fix double close channel bug by removing wait in lightningNode.stop()

Browse source 
This commit fixes a panic bug caused by two calls to a process’
cmd.Wait() method. If two nodes incurred a fatal error as soon as they
were created, then both the goroutine detected to recovering the stderr
data and the defer statement would case a double channel close due to
the simultaneous calls to Wait().
This commit is contained in:
Olaoluwa Osuntokun 2016-10-23 19:22:43 -07:00
parent 517255fdb1
commit a7b7f4f272
No known key found for this signature in database
GPG key ID: 9CC5B105D03521A2
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
networktest.go
View file

@ -260,8 +260,6 @@ func (l *lightningNode) stop() error {
return nil return nil
} }
defer l.cmd.Wait()
if runtime.GOOS == "windows" { if runtime.GOOS == "windows" {
return l.cmd.Process.Signal(os.Kill) return l.cmd.Process.Signal(os.Kill)
} }