From 7af85d44fd167e3fca8e25484119037ef9cc606a Mon Sep 17 00:00:00 2001 From: CharlieZKSmith Date: Mon, 9 Sep 2024 00:12:47 -0700 Subject: [PATCH 1/2] commands: update interactive input in create command description --- cmd/commands/cmd_walletunlocker.go | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/cmd/commands/cmd_walletunlocker.go b/cmd/commands/cmd_walletunlocker.go index 844b48f3d..a0a286047 100644 --- a/cmd/commands/cmd_walletunlocker.go +++ b/cmd/commands/cmd_walletunlocker.go @@ -34,17 +34,16 @@ var createCommand = cli.Command{ Usage: "Initialize a wallet when starting lnd for the first time.", Description: ` The create command is used to initialize an lnd wallet from scratch for - the very first time. This is interactive command with one required - argument (the password), and one optional argument (the mnemonic - passphrase). + the very first time. This is an interactive command with one required + input (the password), and one optional input (the mnemonic passphrase). - The first argument (the password) is required and MUST be greater than - 8 characters. This will be used to encrypt the wallet within lnd. This + The first input (the password) is required and MUST be greater than 8 + characters. This will be used to encrypt the wallet within lnd. This MUST be remembered as it will be required to fully start up the daemon. - The second argument is an optional 24-word mnemonic derived from BIP - 39. If provided, then the internal wallet will use the seed derived - from this mnemonic to generate all keys. + The second input is an optional 24-word mnemonic derived from BIP 39. + If provided, then the internal wallet will use the seed derived from + this mnemonic to generate all keys. This command returns a 24-word seed in the scenario that NO mnemonic was provided by the user. This should be written down as it can be used From 000e3381b101c0a8d696a3d26b602e59e950e15f Mon Sep 17 00:00:00 2001 From: CharlieZKSmith Date: Tue, 10 Sep 2024 21:32:26 -0700 Subject: [PATCH 2/2] docs: add release notes --- docs/release-notes/release-notes-0.19.0.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/release-notes/release-notes-0.19.0.md b/docs/release-notes/release-notes-0.19.0.md index 869e23511..919d25aa4 100644 --- a/docs/release-notes/release-notes-0.19.0.md +++ b/docs/release-notes/release-notes-0.19.0.md @@ -55,7 +55,12 @@ ## Tooling and Documentation +* [Improved `lncli create` command help text](https://github.com/lightningnetwork/lnd/pull/9077) + by replacing the word `argument` with `input` in the command description, + clarifying that the command requires interactive inputs rather than arguments. + # Contributors (Alphabetical Order) +* CharlieZKSmith * Pins * Ziggie