From a2cb3da1458fa7563b5ccf94489933f5f552edae Mon Sep 17 00:00:00 2001 From: Keagan McClelland Date: Mon, 20 Nov 2023 14:48:26 -0700 Subject: [PATCH] meta: update PR template to remind contributors about lncli docs --- .github/pull_request_template.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 21f3fa92d..6520dcfd6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -14,6 +14,7 @@ Steps for reviewers to follow to test the change. - [ ] The change obeys the [Code Documentation and Commenting](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#CodeDocumentation) guidelines, and lines wrap at 80. - [ ] Commits follow the [Ideal Git Commit Structure](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#IdealGitCommitStructure). - [ ] Any new logging statements use an appropriate subsystem and logging level. +- [ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file. - [ ] [There is a change description in the release notes](https://github.com/lightningnetwork/lnd/tree/master/docs/release-notes), or `[skip ci]` in the commit message for small changes. -📝 Please see our [Contribution Guidelines](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md) for further guidance. \ No newline at end of file +📝 Please see our [Contribution Guidelines](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md) for further guidance.