lnwallet: don't re-use sign descriptor

Fixes an issue where re-using a sign descriptor in a loop carried over
signing information from one call to the next, which caused the remote
signing issue.

lnwallet/chanfunding/wallet_assembler.go

@@ -110,13 +110,12 @@ func (f *FullIntent) CompileFundingTx(extraInputs []*wire.TxIn,
 	prevOutFetcher := NewSegWitV0DualFundingPrevOutputFetcher(
 		f.coinSource, extraInputs,
 	)
+	sigHashes := txscript.NewTxSigHashes(fundingTx, prevOutFetcher)
+	for i, txIn := range fundingTx.TxIn {
 		signDesc := input.SignDescriptor{
-		SigHashes: txscript.NewTxSigHashes(
-			fundingTx, prevOutFetcher,
-		),
+			SigHashes:         sigHashes,
 			PrevOutputFetcher: prevOutFetcher,
 		}
-	for i, txIn := range fundingTx.TxIn {
 		// We can only sign this input if it's ours, so we'll ask the
 		// coin source if it can map this outpoint into a coin we own.
 		// If not, then we'll continue as it isn't our input.