mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-01-19 05:45:21 +01:00
Code Issues Projects Releases Wiki Activity

sqldb: reset out of scope containers on potential ExecTx retry

Browse Source 
As SQL serializaton errors can lead to transaction retries we need to
ensure that we reset any out of scope containers where we accumulate
results. Otherwise partial data from a previously executed transacton
retry may be returned along with the latest result.
This commit is contained in:
Andras Banki-Horvath 2024-03-27 17:55:00 +01:00
parent b76f733a9e
commit a1a7982646
No known key found for this signature in database
GPG Key ID: 80E5375C094198D8
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/release-notes/release-notes-0.18.0.md
View File

@ -401,6 +401,9 @@ bitcoin peers' feefilter values into account](https://github.com/lightningnetwor
start](https://github.com/lightningnetwork/lnd/pull/8568) if native SQL is
enabled but the channeldb already has any KV invoices stored.
* [Fix a bug](https://github.com/lightningnetwork/lnd/pull/8595) when retrying
SQL InvoiceDB transactions due to database errors.
## Code Health
* [Remove database pointers](https://github.com/lightningnetwork/lnd/pull/8117)

6
sqldb/invoices.go
View File

@ -611,10 +611,11 @@ func (i *InvoiceStore) LookupInvoice(ctx context.Context,
func (i *InvoiceStore) FetchPendingInvoices(ctx context.Context) (
map[lntypes.Hash]invpkg.Invoice, error) {
invoices := make(map[lntypes.Hash]invpkg.Invoice)
var invoices map[lntypes.Hash]invpkg.Invoice
readTxOpt := NewInvoiceQueryReadTx()
err := i.db.ExecTx(ctx, &readTxOpt, func(db InvoiceQueries) error {
invoices = make(map[lntypes.Hash]invpkg.Invoice)
limit := queryPaginationLimit
return queryWithLimit(func(offset int) (int, error) {
@ -671,6 +672,7 @@ func (i *InvoiceStore) InvoicesSettledSince(ctx context.Context, idx uint64) (
readTxOpt := NewInvoiceQueryReadTx()
err := i.db.ExecTx(ctx, &readTxOpt, func(db InvoiceQueries) error {
invoices = nil
settleIdx := idx
limit := queryPaginationLimit
@ -784,6 +786,7 @@ func (i *InvoiceStore) InvoicesAddedSince(ctx context.Context, idx uint64) (
readTxOpt := NewInvoiceQueryReadTx()
err := i.db.ExecTx(ctx, &readTxOpt, func(db InvoiceQueries) error {
result = nil
addIdx := idx
limit := queryPaginationLimit
@ -840,6 +843,7 @@ func (i *InvoiceStore) QueryInvoices(ctx context.Context,
readTxOpt := NewInvoiceQueryReadTx()
err := i.db.ExecTx(ctx, &readTxOpt, func(db InvoiceQueries) error {
invoices = nil
limit := queryPaginationLimit
return queryWithLimit(func(offset int) (int, error) {