Merge pull request #7039 from TonyGiorgio/sync-7034

Remove ErrSynchronizingChain

docs/release-notes/release-notes-0.16.0.md

@@ -119,6 +119,9 @@ https://github.com/lightningnetwork/lnd/pull/6963/)
 
 * [Stop handling peer warning messages as errors](https://github.com/lightningnetwork/lnd/pull/6840)
 
+* [Stop sending a synchronizing error on the wire when out of
+  sync](https://github.com/lightningnetwork/lnd/pull/7039).
+
 ## `lncli`
 * [Add an `insecure` flag to skip tls auth as well as a `metadata` string slice
   flag](https://github.com/lightningnetwork/lnd/pull/6818) that allows the

funding/manager.go

@@ -1306,9 +1306,10 @@ func (f *Manager) handleFundingOpen(peer lnpeer.Peer,
 		if err != nil {
 			log.Errorf("unable to query wallet: %v", err)
 		}
+		err := errors.New("Synchronizing blockchain")
 		f.failFundingFlow(
 			peer, msg.PendingChannelID,
-			lnwire.ErrSynchronizingChain,
+			err,
 		)
 		return
 	}

lnwire/error.go

@@ -15,15 +15,10 @@ const (
 	// active pending channels exceeds their maximum policy limit.
 	ErrMaxPendingChannels FundingError = 1
 
-	// ErrSynchronizingChain is returned by a remote peer that receives a
-	// channel update or a funding request while it's still syncing to the
-	// latest state of the blockchain.
-	ErrSynchronizingChain FundingError = 2
-
 	// ErrChanTooLarge is returned by a remote peer that receives a
 	// FundingOpen request for a channel that is above their current
 	// soft-limit.
-	ErrChanTooLarge FundingError = 3
+	ErrChanTooLarge FundingError = 2
 )
 
 // String returns a human readable version of the target FundingError.
@@ -31,8 +26,6 @@ func (e FundingError) String() string {
 	switch e {
 	case ErrMaxPendingChannels:
 		return "Number of pending channels exceed maximum"
-	case ErrSynchronizingChain:
-		return "Synchronizing blockchain"
 	case ErrChanTooLarge:
 		return "channel too large"
 	default: