From 028fc86e5c2af3777c852e90a09cf0b4fa4f6a65 Mon Sep 17 00:00:00 2001 From: Olaoluwa Osuntokun Date: Tue, 19 Oct 2021 17:39:57 -0700 Subject: [PATCH 1/2] lnwire: switch chan_type feature to bits 44/45 We were using an older feature bit that was just "selected". This commit has us use the feature bit officially included in the spec. See https://github.com/lightningnetwork/lightning-rfc/pull/906 --- lnwire/features.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lnwire/features.go b/lnwire/features.go index 98202841f..9a7440dbf 100644 --- a/lnwire/features.go +++ b/lnwire/features.go @@ -145,19 +145,15 @@ const ( // negotiation methods. With this bit, there is no longer a "default" // implicit channel commitment type, allowing a connection to // open/maintain types of several channels over its lifetime. - // - // TODO: Decide on actual feature bit value. - ExplicitChannelTypeRequired = 2020 + ExplicitChannelTypeRequired = 44 // ExplicitChannelTypeOptional is an optional bit that denotes that a // connection established with this node is to use explicit channel // commitment types for negotiation instead of the existing implicit // negotiation methods. With this bit, there is no longer a "default" // implicit channel commitment type, allowing a connection to - // open/maintain types of several channels over its lifetime. - // // TODO: Decide on actual feature bit value. - ExplicitChannelTypeOptional = 2021 + ExplicitChannelTypeOptional = 45 // maxAllowedSize is a maximum allowed size of feature vector. // From 287871401ab622760f281b481eb0703ab7e00374 Mon Sep 17 00:00:00 2001 From: Olaoluwa Osuntokun Date: Tue, 19 Oct 2021 18:25:45 -0700 Subject: [PATCH 2/2] docs/release-notes: add section for propr chan type feature bit --- docs/release-notes/release-notes-0.14.0.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/release-notes/release-notes-0.14.0.md b/docs/release-notes/release-notes-0.14.0.md index 60238fa57..6470d87f8 100644 --- a/docs/release-notes/release-notes-0.14.0.md +++ b/docs/release-notes/release-notes-0.14.0.md @@ -101,7 +101,9 @@ need to be kept in memory. initiator to signal their desired channel type to use with the remote peer. If the remote peer supports said channel type and agrees, the previous implicit negotiation based on the shared set of feature bits is bypassed, and the -proposed channel type is used. +proposed channel type is used. [Feature bits 44/45 are used to +signal](https://github.com/lightningnetwork/lnd/pull/5874) this new feature. + ## RPC Server