mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-03-13 11:09:23 +01:00
Code Issues Projects Releases Wiki Activity

Merge pull request #7780 from ziggie1984/max_local_csv

Browse source 
Change defaultMaxLocalCSVDelay to protect user from high delays
This commit is contained in:
Oliver Gugger 2023-06-29 20:52:26 +02:00 • committed by GitHub
commit 5c5ce1f707
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
config.go
View file

@ -175,9 +175,10 @@ const (
defaultRemoteMaxHtlcs = 483 defaultRemoteMaxHtlcs = 483
// defaultMaxLocalCSVDelay is the maximum delay we accept on our // defaultMaxLocalCSVDelay is the maximum delay we accept on our
// commitment output. // commitment output. The local csv delay maximum is now equal to
// TODO(halseth): find a more scientific choice of value. // the remote csv delay maximum we require for the remote commitment
defaultMaxLocalCSVDelay = 10000 // transaction.
defaultMaxLocalCSVDelay = 2016
// defaultChannelCommitInterval is the default maximum time between // defaultChannelCommitInterval is the default maximum time between
// receiving a channel state update and signing a new commitment. // receiving a channel state update and signing a new commitment.

4
docs/release-notes/release-notes-0.17.0.md
View file

@ -39,6 +39,10 @@ package](https://github.com/lightningnetwork/lnd/pull/7356)
* [HTLC serialization updated](https://github.com/lightningnetwork/lnd/pull/7710) * [HTLC serialization updated](https://github.com/lightningnetwork/lnd/pull/7710)
to allow storing extra data transmitted in TLVs. to allow storing extra data transmitted in TLVs.
* [MaxLocalCSVDelay now has a default value of 2016. It is still possible to
override this value with the config option --maxlocaldelay for those who rely
on the old value of 10000](https://github.com/lightningnetwork/lnd/pull/7780).
## RPC ## RPC
* [SendOutputs](https://github.com/lightningnetwork/lnd/pull/7631) now adheres * [SendOutputs](https://github.com/lightningnetwork/lnd/pull/7631) now adheres

2
funding/manager_test.go
View file

@ -59,7 +59,7 @@ const (
// defaultMaxLocalCSVDelay is the maximum delay we accept on our // defaultMaxLocalCSVDelay is the maximum delay we accept on our
// commitment output. // commitment output.
defaultMaxLocalCSVDelay = 10000 defaultMaxLocalCSVDelay = 2016
) )
var ( var (