mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2024-11-19 09:53:54 +01:00
Code Issues Projects Releases Wiki Activity

lntest: use errgroup for node startup

Browse Source 
This commit fixes a nil pointer issue when a node fails to start up.
Because require.NoErrorf() doesn't abort a test immediately if run
inside a goroutine, this lead to the test continuing with nil node
references which lead to a panic later on.
This commit is contained in:
Oliver Gugger 2021-09-29 10:12:25 +02:00
parent 410606b082
commit 5aeb728f80
No known key found for this signature in database
GPG Key ID: 8E4256593F177720
1 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
lntest/harness.go
View File

@ -28,6 +28,7 @@ import (
"github.com/lightningnetwork/lnd/lnwallet/chainfee"
"github.com/lightningnetwork/lnd/lnwire"
"github.com/stretchr/testify/require"
"golang.org/x/sync/errgroup"
"google.golang.org/grpc/grpclog"
)
@ -163,17 +164,22 @@ func (n *NetworkHarness) SetUp(t *testing.T,
// Start the initial seeder nodes within the test network, then connect
// their respective RPC clients.
var wg sync.WaitGroup
wg.Add(2)
go func() {
defer wg.Done()
n.Alice = n.NewNode(t, "Alice", lndArgs)
}()
go func() {
defer wg.Done()
n.Bob = n.NewNode(t, "Bob", lndArgs)
}()
wg.Wait()
eg := errgroup.Group{}
eg.Go(func() error {
var err error
n.Alice, err = n.newNode(
"Alice", lndArgs, false, nil, n.dbBackend, true,
)
return err
})
eg.Go(func() error {
var err error
n.Bob, err = n.newNode(
"Bob", lndArgs, false, nil, n.dbBackend, true,
)
return err
})
require.NoError(t, eg.Wait())
// First, make a connection between the two nodes. This will wait until
// both nodes are fully started since the Connect RPC is guarded behind