diff --git a/peer.go b/peer.go index 677d147db..9456a770d 100644 --- a/peer.go +++ b/peer.go @@ -958,9 +958,9 @@ func (p *peer) readHandler() { p.Disconnect(err) }) - // Initialize our negotiated gossip sync method before reading - // messages off the wire. When using gossip queries, this ensures - // a gossip syncer is active by the time query messages arrive. + // Initialize our negotiated gossip sync method before reading messages + // off the wire. When using gossip queries, this ensures a gossip + // syncer is active by the time query messages arrive. // // TODO(conner): have peer store gossip syncer directly and bypass // gossiper? @@ -2146,18 +2146,21 @@ func (p *peer) WipeChannel(chanPoint *wire.OutPoint) error { // handleInitMsg handles the incoming init message which contains global and // local features vectors. If feature vectors are incompatible then disconnect. func (p *peer) handleInitMsg(msg *lnwire.Init) error { - p.remoteLocalFeatures = lnwire.NewFeatureVector(msg.LocalFeatures, - lnwire.LocalFeatures) - p.remoteGlobalFeatures = lnwire.NewFeatureVector(msg.GlobalFeatures, - lnwire.GlobalFeatures) + p.remoteLocalFeatures = lnwire.NewFeatureVector( + msg.LocalFeatures, lnwire.LocalFeatures, + ) + p.remoteGlobalFeatures = lnwire.NewFeatureVector( + msg.GlobalFeatures, lnwire.GlobalFeatures, + ) + // Now that we have their features loaded, we'll ensure that they + // didn't set any required bits that we don't know of. unknownLocalFeatures := p.remoteLocalFeatures.UnknownRequiredFeatures() if len(unknownLocalFeatures) > 0 { err := fmt.Errorf("Peer set unknown local feature bits: %v", unknownLocalFeatures) return err } - unknownGlobalFeatures := p.remoteGlobalFeatures.UnknownRequiredFeatures() if len(unknownGlobalFeatures) > 0 { err := fmt.Errorf("Peer set unknown global feature bits: %v", @@ -2165,6 +2168,13 @@ func (p *peer) handleInitMsg(msg *lnwire.Init) error { return err } + // Now that we know we understand their requirements, we'll check to + // see if they don't support anything that we deem to be mandatory. + switch { + case !p.remoteLocalFeatures.HasFeature(lnwire.DataLossProtectRequired): + return fmt.Errorf("data loss protection required") + } + return nil } diff --git a/server.go b/server.go index 70a8fa440..dacc54ec5 100644 --- a/server.go +++ b/server.go @@ -2370,7 +2370,7 @@ func (s *server) peerConnected(conn net.Conn, connReq *connmgr.ConnReq, // We'll signal that we understand the data loss protection feature, // and also that we support the new gossip query features. - localFeatures.Set(lnwire.DataLossProtectOptional) + localFeatures.Set(lnwire.DataLossProtectRequired) localFeatures.Set(lnwire.GossipQueriesOptional) // Now that we've established a connection, create a peer, and it to