mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-03-09 16:04:38 +01:00
Code Issues Projects Releases Wiki Activity

itest: remove time.Sleep before closing channels

Browse source 
Remove an old TODO, which has been fixed with the `NoWait` flag for coop
close.
This commit is contained in:
yyforyongyu 2025-03-06 09:11:13 +08:00
parent ec7c36fd6a
commit 4755eff0a8
No known key found for this signature in database
GPG key ID: 9BCD95C4FF296868
1 changed files with 0 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
itest/lnd_funding_test.go
View file

@ -4,7 +4,6 @@ import (
"context" "context"
"fmt" "fmt"
"testing" "testing"
"time"
"github.com/btcsuite/btcd/btcutil" "github.com/btcsuite/btcd/btcutil"
"github.com/btcsuite/btcd/chaincfg/chainhash" "github.com/btcsuite/btcd/chaincfg/chainhash"
@ -559,17 +558,6 @@ func runChannelFundingInputTypes(ht *lntest.HarnessTest, alice,
checkChannelBalance(carol, carolLocalBalance, 0, 0, 0) checkChannelBalance(carol, carolLocalBalance, 0, 0, 0)
checkChannelBalance(alice, 0, carolLocalBalance, 0, 0) checkChannelBalance(alice, 0, carolLocalBalance, 0, 0)
// TODO(yy): remove the sleep once the following bug is fixed.
//
// We may get the error `unable to gracefully close channel
// while peer is offline (try force closing it instead):
// channel link not found`. This happens because the channel
// link hasn't been added yet but we now proceed to closing the
// channel. We may need to revisit how the channel open event
// is created and make sure the event is only sent after all
// relevant states have been updated.
time.Sleep(2 * time.Second)
// Now that we're done with the test, the channel can be closed. // Now that we're done with the test, the channel can be closed.
ht.CloseChannel(carol, chanPoint) ht.CloseChannel(carol, chanPoint)
@ -685,14 +673,6 @@ func runExternalFundingScriptEnforced(ht *lntest.HarnessTest) {
// HTLCs. // HTLCs.
ht.AssertInvoiceSettled(dave, resp.PaymentAddr) ht.AssertInvoiceSettled(dave, resp.PaymentAddr)
// TODO(yy): remove the sleep once the following bug is fixed.
// When the invoice is reported settled, the commitment dance is not
// yet finished, which can cause an error when closing the channel,
// saying there's active HTLCs. We need to investigate this issue and
// reverse the order to, first finish the commitment dance, then report
// the invoice as settled.
time.Sleep(2 * time.Second)
// Next we'll try but this time with Dave (the responder) as the // Next we'll try but this time with Dave (the responder) as the
// initiator. This time the channel should be closed as normal. // initiator. This time the channel should be closed as normal.
ht.CloseChannel(dave, chanPoint2) ht.CloseChannel(dave, chanPoint2)
@ -845,14 +825,6 @@ func runExternalFundingTaproot(ht *lntest.HarnessTest) {
// HTLCs. // HTLCs.
ht.AssertInvoiceSettled(dave, resp.PaymentAddr) ht.AssertInvoiceSettled(dave, resp.PaymentAddr)
// TODO(yy): remove the sleep once the following bug is fixed.
// When the invoice is reported settled, the commitment dance is not
// yet finished, which can cause an error when closing the channel,
// saying there's active HTLCs. We need to investigate this issue and
// reverse the order to, first finish the commitment dance, then report
// the invoice as settled.
time.Sleep(2 * time.Second)
// Next we'll try but this time with Dave (the responder) as the // Next we'll try but this time with Dave (the responder) as the
// initiator. This time the channel should be closed as normal. // initiator. This time the channel should be closed as normal.
ht.CloseChannel(dave, chanPoint2) ht.CloseChannel(dave, chanPoint2)