Merge pull request #5697 from arshbot/export-selectHopHints

invoicesrpc: expose selectHopHints
This commit is contained in:
Oliver Gugger 2021-09-08 10:27:36 +02:00 committed by GitHub
commit 4337116bce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions

View file

@ -152,6 +152,10 @@ you.
into projects that are compiled to WASM binaries. [That problem was fixed by
guarding those syscalls with build tags](https://github.com/lightningnetwork/lnd/pull/5526).
* The only way to retrieve hophints for a given node was to create an invoice
with the `addInvoice` rpc interface. However, now the function has been
[exposed in the go package `invoicesrpc`](https://github.com/lightningnetwork/lnd/pull/5697).
## Code Health
### Code cleanup, refactor, typo fixes
@ -265,6 +269,7 @@ change](https://github.com/lightningnetwork/lnd/pull/5613).
* de6df1re
* ErikEk
* Eugene Siegel
* Harsha Goli
* Martin Habovstiak
* Oliver Gugger
* Wilmer Paulino

View file

@ -391,7 +391,7 @@ func AddInvoice(ctx context.Context, cfg *AddInvoiceConfig,
// We'll restrict the number of individual route hints
// to 20 to avoid creating overly large invoices.
numMaxHophints := 20 - len(forcedHints)
hopHints := selectHopHints(
hopHints := SelectHopHints(
amtMSat, cfg, filteredChannels, numMaxHophints,
)
@ -553,12 +553,12 @@ func addHopHint(hopHints *[]func(*zpay32.Invoice),
)
}
// selectHopHints will select up to numMaxHophints from the set of passed open
// SelectHopHints will select up to numMaxHophints from the set of passed open
// channels. The set of hop hints will be returned as a slice of functional
// options that'll append the route hint to the set of all route hints.
//
// TODO(roasbeef): do proper sub-set sum max hints usually << numChans
func selectHopHints(amtMSat lnwire.MilliSatoshi, cfg *AddInvoiceConfig,
func SelectHopHints(amtMSat lnwire.MilliSatoshi, cfg *AddInvoiceConfig,
openChannels []*channeldb.OpenChannel,
numMaxHophints int) []func(*zpay32.Invoice) {