Merge pull request #7306 from YusukeShimizu/docs-invoice-default-expiry

Docs invoice default expiry
This commit is contained in:
Oliver Gugger 2023-01-12 10:29:07 +01:00 committed by GitHub
commit 3dd9e04b8b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 14 additions and 11 deletions

View File

@ -57,8 +57,8 @@ var addInvoiceCommand = cli.Command{
cli.Int64Flag{
Name: "expiry",
Usage: "the invoice's expiry time in seconds. If not " +
"specified an expiry of 3600 seconds (1 hour) " +
"is implied.",
"specified, an expiry of " +
"86400 seconds (24 hours) is implied.",
},
cli.BoolFlag{
Name: "private",

View File

@ -181,8 +181,8 @@ var addHoldInvoiceCommand = cli.Command{
cli.Int64Flag{
Name: "expiry",
Usage: "the invoice's expiry time in seconds. If not " +
"specified, an expiry of 3600 seconds (1 hour) " +
"is implied.",
"specified, an expiry of " +
"86400 seconds (24 hours) is implied.",
},
cli.BoolFlag{
Name: "private",

View File

@ -197,6 +197,8 @@ certain large transactions](https://github.com/lightningnetwork/lnd/pull/7100).
that caused additional failure message data to be interpreted as being part of
a channel update.
* [Fix addinvoice expiry flag comment](https://github.com/lightningnetwork/lnd/pull/7306).
## `lncli`
* [Add an `insecure` flag to skip tls auth as well as a `metadata` string slice
@ -366,3 +368,4 @@ refactor the itest for code health and maintenance.
* Roei Erez
* Tommy Volk
* Yong Yu
* Yusuke Shimizu

View File

@ -188,7 +188,7 @@ type AddHoldInvoiceRequest struct {
// payment (memo) is too long to naturally fit within the description field
// of an encoded payment request.
DescriptionHash []byte `protobuf:"bytes,4,opt,name=description_hash,json=descriptionHash,proto3" json:"description_hash,omitempty"`
// Payment request expiry time in seconds. Default is 3600 (1 hour).
// Payment request expiry time in seconds. Default is 86400 (24 hours).
Expiry int64 `protobuf:"varint,5,opt,name=expiry,proto3" json:"expiry,omitempty"`
// Fallback on-chain address.
FallbackAddr string `protobuf:"bytes,6,opt,name=fallback_addr,json=fallbackAddr,proto3" json:"fallback_addr,omitempty"`

View File

@ -84,7 +84,7 @@ message AddHoldInvoiceRequest {
*/
bytes description_hash = 4;
// Payment request expiry time in seconds. Default is 3600 (1 hour).
// Payment request expiry time in seconds. Default is 86400 (24 hours).
int64 expiry = 5;
// Fallback on-chain address.

View File

@ -261,7 +261,7 @@
"expiry": {
"type": "string",
"format": "int64",
"description": "Payment request expiry time in seconds. Default is 3600 (1 hour)."
"description": "Payment request expiry time in seconds. Default is 86400 (24 hours)."
},
"fallback_addr": {
"type": "string",
@ -493,7 +493,7 @@
"expiry": {
"type": "string",
"format": "int64",
"description": "Payment request expiry time in seconds. Default is 3600 (1 hour)."
"description": "Payment request expiry time in seconds. Default is 86400 (24 hours)."
},
"fallback_addr": {
"type": "string",

View File

@ -11635,7 +11635,7 @@ type Invoice struct {
// of an encoded payment request. When using REST, this field must be encoded
// as base64.
DescriptionHash []byte `protobuf:"bytes,10,opt,name=description_hash,json=descriptionHash,proto3" json:"description_hash,omitempty"`
// Payment request expiry time in seconds. Default is 3600 (1 hour).
// Payment request expiry time in seconds. Default is 86400 (24 hours).
Expiry int64 `protobuf:"varint,11,opt,name=expiry,proto3" json:"expiry,omitempty"`
// Fallback on-chain address.
FallbackAddr string `protobuf:"bytes,12,opt,name=fallback_addr,json=fallbackAddr,proto3" json:"fallback_addr,omitempty"`

View File

@ -3394,7 +3394,7 @@ message Invoice {
*/
bytes description_hash = 10;
// Payment request expiry time in seconds. Default is 3600 (1 hour).
// Payment request expiry time in seconds. Default is 86400 (24 hours).
int64 expiry = 11;
// Fallback on-chain address.

View File

@ -5060,7 +5060,7 @@
"expiry": {
"type": "string",
"format": "int64",
"description": "Payment request expiry time in seconds. Default is 3600 (1 hour)."
"description": "Payment request expiry time in seconds. Default is 86400 (24 hours)."
},
"fallback_addr": {
"type": "string",