From 15d2ff0c4d8b4b81f11ae2234d9d3ffcbfc6cc11 Mon Sep 17 00:00:00 2001 From: Elle Date: Thu, 24 Aug 2023 20:47:42 +0200 Subject: [PATCH] netann+docs: remove nil value from variadic list (#7922) The nil value in the variadic list causes a panic when the variadic parameters are iterated over. --- docs/release-notes/release-notes-0.17.0.md | 3 +++ netann/host_ann.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/release-notes/release-notes-0.17.0.md b/docs/release-notes/release-notes-0.17.0.md index 107d24dab..9ece76a40 100644 --- a/docs/release-notes/release-notes-0.17.0.md +++ b/docs/release-notes/release-notes-0.17.0.md @@ -59,6 +59,9 @@ have to make sure to not broadcast outdated transactions which can lead to locked up wallet funds indefinitely in the worst case. +- [Remove nil value](https://github.com/lightningnetwork/lnd/pull/7922) from + variadic parameter list. + # New Features ## Functional Enhancements ### Protocol Features diff --git a/netann/host_ann.go b/netann/host_ann.go index fdb48e839..767c3089c 100644 --- a/netann/host_ann.go +++ b/netann/host_ann.go @@ -178,7 +178,7 @@ func IPAnnouncer(annUpdater NodeAnnUpdater) func([]net.Addr, map[string]struct{}) error { return func(newAddrs []net.Addr, oldAddrs map[string]struct{}) error { - _, err := annUpdater(nil, func( + _, err := annUpdater(func( currentNodeAnn *lnwire.NodeAnnouncement) { // To ensure we don't duplicate any addresses, we'll // filter out the same of addresses we should no longer