Merge pull request #6472 from tvolk131/document_confirmation_height

Document that `confirmation_height` is unset

docs/release-notes/release-notes-0.15.0.md

@@ -271,6 +271,8 @@ from occurring that would result in an erroneous force close.](https://github.co
   to the total number of payments (complete and incomplete) that are currently
   in the payment database](https://github.com/lightningnetwork/lnd/pull/6463).
 
+* [Remove `confirmation_height` field from PendingChannel proto](https://github.com/lightningnetwork/lnd/pull/6472)
+
 ## Database
 
 * [Add ForAll implementation for etcd to speed up
@@ -368,6 +370,7 @@ gRPC performance metrics (latency to process `GetInfo`, etc)](https://github.com
 * randymcmillan
 * Rong Ou
 * Thebora Kompanioni
+* Tommy Volk
 * Torkel Rogstad
 * Vsevolod Kaganovych
 * Yong Yu

lnrpc/lightning.proto

@@ -2369,9 +2369,6 @@ message PendingChannelsResponse {
         // The pending channel
         PendingChannel channel = 1;
 
-        // The height at which this channel will be confirmed
-        uint32 confirmation_height = 2;
-
         /*
         The amount calculated to be paid in fees for the current set of
         commitment transactions. The fee amount is persisted with the channel
@@ -2390,6 +2387,9 @@ message PendingChannelsResponse {
         transaction. This value can later be updated once the channel is open.
         */
         int64 fee_per_kw = 6;
+
+        // Previously used for confirmation_height. Do not reuse.
+        reserved 2;
     }
 
     message WaitingCloseChannel {

lnrpc/lightning.swagger.json

@@ -2792,11 +2792,6 @@
           "$ref": "#/definitions/PendingChannelsResponsePendingChannel",
           "title": "The pending channel"
         },
-        "confirmation_height": {
-          "type": "integer",
-          "format": "int64",
-          "title": "The height at which this channel will be confirmed"
-        },
         "commit_fee": {
           "type": "string",
           "format": "int64",