From 00154bda24205b37dd7c740866444ad7c0cbfc88 Mon Sep 17 00:00:00 2001 From: "Johan T. Halseth" Date: Thu, 12 Jul 2018 11:02:54 +0200 Subject: [PATCH] contractcourt/chain_watcher: attempt dispatchRemoteClose using data loss commitPoint This commit makes the chainwatcher attempt to dispatch a remote close when it detects a remote state with a state number higher than our known remote state. This can mean that we lost some state, and we check the database for (hopefully) a data loss commit point retrieved during channel sync with the remote peer. If this commit point is found in the database we use it to try to recover our funds from the commitment. --- contractcourt/chain_watcher.go | 49 +++++++++++++++++++++++++++++----- 1 file changed, 42 insertions(+), 7 deletions(-) diff --git a/contractcourt/chain_watcher.go b/contractcourt/chain_watcher.go index f0fdb830b..8126d37d2 100644 --- a/contractcourt/chain_watcher.go +++ b/contractcourt/chain_watcher.go @@ -372,15 +372,50 @@ func (c *chainWatcher) closeObserver(spendNtfn *chainntnfs.SpendEvent) { c.cfg.chanState.FundingOutpoint, err) } - // This is the case that somehow the commitment - // broadcast is actually greater than even one beyond - // our best known state number. This should NEVER - // happen, but we'll log it in any case. + // This is the case that somehow the commitment broadcast is + // actually greater than even one beyond our best known state + // number. This should ONLY happen in case we experienced some + // sort of data loss. case broadcastStateNum > remoteStateNum+1: - log.Errorf("Remote node broadcast state #%v, "+ + log.Warnf("Remote node broadcast state #%v, "+ "which is more than 1 beyond best known "+ - "state #%v!!!", broadcastStateNum, - remoteStateNum) + "state #%v!!! Attempting recovery...", + broadcastStateNum, remoteStateNum) + + // If we are lucky, the remote peer sent us the correct + // commitment point during channel sync, such that we + // can sweep our funds. + // TODO(halseth): must handle the case where we haven't + // yet processed the chan sync message. + commitPoint, err := c.cfg.chanState.DataLossCommitPoint() + if err != nil { + log.Errorf("Unable to retrieve commitment "+ + "point for channel(%v) with lost "+ + "state: %v", + c.cfg.chanState.FundingOutpoint, err) + return + } + + log.Infof("Recovered commit point(%x) for "+ + "channel(%v)! Now attempting to use it to "+ + "sweep our funds...", + commitPoint.SerializeCompressed(), + c.cfg.chanState.FundingOutpoint) + + // Since we don't have the commitment stored for this + // state, we'll just pass an empty commitment. Note + // that this means we won't be able to recover any HTLC + // funds. + // TODO(halseth): can we try to recover some HTLCs? + err = c.dispatchRemoteForceClose( + commitSpend, channeldb.ChannelCommitment{}, + commitPoint, + ) + if err != nil { + log.Errorf("unable to handle remote "+ + "close for chan_point=%v: %v", + c.cfg.chanState.FundingOutpoint, err) + } // If the state number broadcast is lower than the // remote node's current un-revoked height, then