mirrors/lnd
1
0
Fork 0
mirror of https://github.com/lightningnetwork/lnd.git synced 2025-01-19 05:45:21 +01:00
Code Issues Projects Releases Wiki Activity
343a6ed831
lnd/htlcswitch/hop/payload_test.go

470 lines
11 KiB
Go
Raw Normal View History

htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
package hop_test
import (
"bytes"
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
"encoding/hex"
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
"reflect"
"testing"
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
"github.com/btcsuite/btcd/btcec/v2"
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
"github.com/lightningnetwork/lnd/htlcswitch/hop"
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
"github.com/lightningnetwork/lnd/lnwire"
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
"github.com/lightningnetwork/lnd/record"
htlcswitch/hop: parse and validate AMP records
2021-03-25 03:47:58 +01:00
"github.com/stretchr/testify/require"
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
)
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
var (
//nolint:lll
testPrivKeyBytes, _ = hex.DecodeString("e126f68f7eafcc8b74f54d269fe206be715000f94dac067d1c04a8ca3b2db734")
_, testPubKey = btcec.PrivKeyFromBytes(testPrivKeyBytes)
)
htlcswitch+invoices: log payment metadata
2022-01-11 14:15:23 +01:00
const testUnknownRequiredType = 0x80
htlcswitch/hop: make unknown required type const Currently we use the AMP record type, this allows us to change it easily as we add new known records. We also bump this to 0x0c instead of 0x0a.
2021-03-25 03:47:33 +01:00
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
type decodePayloadTest struct {
htlcswitch+invoices: log payment metadata
2022-01-11 14:15:23 +01:00
name string
payload []byte
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
isFinalHop bool
htlcswitch+invoices: log payment metadata
2022-01-11 14:15:23 +01:00
expErr error
expCustomRecords map[uint64][]byte
shouldHaveMPP bool
shouldHaveAMP bool
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
shouldHaveEncData bool
shouldHaveBlinding bool
htlcswitch+invoices: log payment metadata
2022-01-11 14:15:23 +01:00
shouldHaveMetadata bool
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
shouldHaveTotalAmt bool
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
}
var decodePayloadTests = []decodePayloadTest{
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "final hop valid",
isFinalHop: true,
payload: []byte{0x02, 0x00, 0x04, 0x00},
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "intermediate hop valid",
isFinalHop: false,
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
payload: []byte{0x02, 0x00, 0x04, 0x00, 0x06, 0x08, 0x01, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
},
},
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "final hop no amount",
payload: []byte{0x04, 0x00},
isFinalHop: true,
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
expErr: hop.ErrInvalidPayload{
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
Type: record.AmtOnionType,
Violation: hop.OmittedViolation,
FinalHop: true,
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
},
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "intermediate hop no amount",
isFinalHop: false,
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
payload: []byte{0x04, 0x00, 0x06, 0x08, 0x01, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00,
},
expErr: hop.ErrInvalidPayload{
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
Type: record.AmtOnionType,
Violation: hop.OmittedViolation,
FinalHop: false,
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
},
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "final hop no expiry",
isFinalHop: true,
payload: []byte{0x02, 0x00},
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
expErr: hop.ErrInvalidPayload{
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
Type: record.LockTimeOnionType,
Violation: hop.OmittedViolation,
FinalHop: true,
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
},
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "intermediate hop no expiry",
isFinalHop: false,
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
payload: []byte{0x02, 0x00, 0x06, 0x08, 0x01, 0x00, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00,
},
expErr: hop.ErrInvalidPayload{
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
Type: record.LockTimeOnionType,
Violation: hop.OmittedViolation,
FinalHop: false,
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
},
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "final hop next sid present",
isFinalHop: true,
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
payload: []byte{0x02, 0x00, 0x04, 0x00, 0x06, 0x08, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
},
expErr: hop.ErrInvalidPayload{
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
Type: record.NextHopOnionType,
Violation: hop.IncludedViolation,
FinalHop: true,
},
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "required type after omitted hop id",
isFinalHop: true,
htlcswitch/hop: make unknown required type const Currently we use the AMP record type, this allows us to change it easily as we add new known records. We also bump this to 0x0c instead of 0x0a.
2021-03-25 03:47:33 +01:00
payload: []byte{
0x02, 0x00, 0x04, 0x00,
testUnknownRequiredType, 0x00,
},
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
expErr: hop.ErrInvalidPayload{
htlcswitch/hop: make unknown required type const Currently we use the AMP record type, this allows us to change it easily as we add new known records. We also bump this to 0x0c instead of 0x0a.
2021-03-25 03:47:33 +01:00
Type: testUnknownRequiredType,
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
Violation: hop.RequiredViolation,
FinalHop: true,
},
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "required type after included hop id",
isFinalHop: false,
htlcswitch/hop: make unknown required type const Currently we use the AMP record type, this allows us to change it easily as we add new known records. We also bump this to 0x0c instead of 0x0a.
2021-03-25 03:47:33 +01:00
payload: []byte{
0x02, 0x00, 0x04, 0x00, 0x06, 0x08, 0x01, 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00,
testUnknownRequiredType, 0x00,
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
},
expErr: hop.ErrInvalidPayload{
htlcswitch/hop: make unknown required type const Currently we use the AMP record type, this allows us to change it easily as we add new known records. We also bump this to 0x0c instead of 0x0a.
2021-03-25 03:47:33 +01:00
Type: testUnknownRequiredType,
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
Violation: hop.RequiredViolation,
FinalHop: false,
},
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "required type zero final hop",
isFinalHop: true,
payload: []byte{0x00, 0x00, 0x02, 0x00, 0x04, 0x00},
htlcswitch/hop/payload: required failures with ErrInvalidPayload This commit adds a hop.PayloadViolation enum which encompasses the cases where the sender omits, includes, or requires a type that causes an ErrInvalidPayload faiulre. The existing Omitted bool is converted to this PayloadViolation, and NewPayloadFromReader is updated to return such a failure with a RequiredViolation when an unknown required type is detected. The unit tests are updated to cover the three possible cases of RequiredViolations, as well as included valid intermediate and final hop tests.
2019-10-31 05:19:08 +01:00
expErr: hop.ErrInvalidPayload{
Type: 0,
Violation: hop.RequiredViolation,
FinalHop: true,
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
},
},
htlcswitch/hop/payload: extend tests to required type failures
2019-10-31 05:20:49 +01:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "required type zero final hop zero sid",
isFinalHop: true,
htlcswitch/hop/payload: apply known constraints if required failure This commit modifies the NewPayloadFromReader to apply known presence/omission contraints in the event that the tlv parser returns an unknown required type failure. Now that the parser has been modified to finished parsing the stream to obtain a proper parsed type set, we can accurately apply these higher level validation checks. This overrides required type failures, such that they are only returned if the sender properly abided by the constraints on fields for which we know. The unit tests are updated to create otherwise valid payloads that then return unknown required type failures. In one case, a test which previously returned an unknown required type failure is made to return an included failure for the sid, indicating the unknown required type 0 is being overruled.
2019-10-31 05:21:10 +01:00
payload: []byte{0x00, 0x00, 0x02, 0x00, 0x04, 0x00, 0x06, 0x08,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
htlcswitch/hop/payload: extend tests to required type failures
2019-10-31 05:20:49 +01:00
},
expErr: hop.ErrInvalidPayload{
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
Type: record.NextHopOnionType,
htlcswitch/hop/payload: apply known constraints if required failure This commit modifies the NewPayloadFromReader to apply known presence/omission contraints in the event that the tlv parser returns an unknown required type failure. Now that the parser has been modified to finished parsing the stream to obtain a proper parsed type set, we can accurately apply these higher level validation checks. This overrides required type failures, such that they are only returned if the sender properly abided by the constraints on fields for which we know. The unit tests are updated to create otherwise valid payloads that then return unknown required type failures. In one case, a test which previously returned an unknown required type failure is made to return an included failure for the sid, indicating the unknown required type 0 is being overruled.
2019-10-31 05:21:10 +01:00
Violation: hop.IncludedViolation,
htlcswitch/hop/payload: extend tests to required type failures
2019-10-31 05:20:49 +01:00
FinalHop: true,
},
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "required type zero intermediate hop",
isFinalHop: false,
htlcswitch/hop/payload: apply known constraints if required failure This commit modifies the NewPayloadFromReader to apply known presence/omission contraints in the event that the tlv parser returns an unknown required type failure. Now that the parser has been modified to finished parsing the stream to obtain a proper parsed type set, we can accurately apply these higher level validation checks. This overrides required type failures, such that they are only returned if the sender properly abided by the constraints on fields for which we know. The unit tests are updated to create otherwise valid payloads that then return unknown required type failures. In one case, a test which previously returned an unknown required type failure is made to return an included failure for the sid, indicating the unknown required type 0 is being overruled.
2019-10-31 05:21:10 +01:00
payload: []byte{0x00, 0x00, 0x02, 0x00, 0x04, 0x00, 0x06, 0x08,
0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
htlcswitch/hop/payload: extend tests to required type failures
2019-10-31 05:20:49 +01:00
},
expErr: hop.ErrInvalidPayload{
Type: 0,
Violation: hop.RequiredViolation,
FinalHop: false,
},
},
htlcswitch/hop: always accept even custom tlv records This commit prepares for sending and receiving of application-specific custom tlv fields.
2019-11-11 10:37:24 +01:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "required type in custom range",
isFinalHop: false,
hltcswitch/hop: add next hop to intermediate hop with custom records Fix our existing test to have a valid intermediate hop that will pass stricter validation. Previously, we did not specify a next channel for an intermediate hop (which violates bolt4).
2023-11-01 20:34:31 +01:00
payload: []byte{
// amount
0x02, 0x00,
// cltv
0x04, 0x00,
// next hop id
0x06, 0x08,
0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
// custom
hop: store custom records from payload
2019-11-19 12:32:56 +01:00
0xfe, 0x00, 0x01, 0x00, 0x00, 0x02, 0x10, 0x11,
},
expCustomRecords: map[uint64][]byte{
65536: {0x10, 0x11},
htlcswitch/hop: always accept even custom tlv records This commit prepares for sending and receiving of application-specific custom tlv fields.
2019-11-11 10:37:24 +01:00
},
},
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "valid intermediate hop",
isFinalHop: false,
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
payload: []byte{0x02, 0x00, 0x04, 0x00, 0x06, 0x08, 0x01, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
},
expErr: nil,
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "valid final hop",
isFinalHop: true,
payload: []byte{0x02, 0x00, 0x04, 0x00},
expErr: nil,
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "intermediate hop with mpp",
isFinalHop: false,
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
payload: []byte{
// amount
0x02, 0x00,
// cltv
0x04, 0x00,
// next hop id
0x06, 0x08,
0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
// mpp
0x08, 0x21,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x08,
},
expErr: hop.ErrInvalidPayload{
Type: record.MPPOnionType,
Violation: hop.IncludedViolation,
FinalHop: false,
},
},
htlcswitch/hop: parse and validate AMP records
2021-03-25 03:47:58 +01:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "intermediate hop with amp",
isFinalHop: false,
htlcswitch/hop: parse and validate AMP records
2021-03-25 03:47:58 +01:00
payload: []byte{
// amount
0x02, 0x00,
// cltv
0x04, 0x00,
// next hop id
0x06, 0x08,
0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
// amp
0x0e, 0x41,
// amp.root_share
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
// amp.set_id
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
// amp.child_index
0x09,
},
expErr: hop.ErrInvalidPayload{
Type: record.AMPOnionType,
Violation: hop.IncludedViolation,
FinalHop: false,
},
},
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "intermediate hop with encrypted data",
isFinalHop: false,
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
payload: []byte{
// encrypted data
0x0a, 0x03, 0x03, 0x02, 0x01,
},
shouldHaveEncData: true,
},
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "intermediate hop with blinding point",
isFinalHop: false,
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
payload: append([]byte{
htlcswitch/test: add encrypted data to blinded intermediate hop Blinding points will always be accompanied by encrypted data, so update the test to more accurately represent reality.
2023-11-01 20:20:04 +01:00
// encrypted data
0x0a, 0x03, 0x03, 0x02, 0x01,
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
// blinding point (type / length)
0x0c, 0x21,
},
// blinding point (value)
testPubKey.SerializeCompressed()...,
),
shouldHaveBlinding: true,
htlcswitch/test: add encrypted data to blinded intermediate hop Blinding points will always be accompanied by encrypted data, so update the test to more accurately represent reality.
2023-11-01 20:20:04 +01:00
shouldHaveEncData: true,
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
},
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "final hop with mpp",
isFinalHop: true,
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
payload: []byte{
// amount
0x02, 0x00,
// cltv
0x04, 0x00,
// mpp
0x08, 0x21,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x08,
},
expErr: nil,
shouldHaveMPP: true,
},
htlcswitch/hop: parse and validate AMP records
2021-03-25 03:47:58 +01:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "final hop with amp",
isFinalHop: true,
htlcswitch/hop: parse and validate AMP records
2021-03-25 03:47:58 +01:00
payload: []byte{
// amount
0x02, 0x00,
// cltv
0x04, 0x00,
// amp
0x0e, 0x41,
// amp.root_share
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
// amp.set_id
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
// amp.child_index
0x09,
},
shouldHaveAMP: true,
},
htlcswitch+invoices: log payment metadata
2022-01-11 14:15:23 +01:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "final hop with metadata",
isFinalHop: true,
htlcswitch+invoices: log payment metadata
2022-01-11 14:15:23 +01:00
payload: []byte{
// amount
0x02, 0x00,
// cltv
0x04, 0x00,
// metadata
0x10, 0x03, 0x01, 0x02, 0x03,
},
shouldHaveMetadata: true,
},
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
{
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
name: "final hop with total amount",
isFinalHop: true,
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
payload: []byte{
// amount
0x02, 0x00,
// cltv
0x04, 0x00,
// total amount
0x12, 0x01, 0x01,
},
shouldHaveTotalAmt: true,
},
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
}
// TestDecodeHopPayloadRecordValidation asserts that parsing the payloads in the
// tests yields the expected errors depending on whether the proper fields were
// included or omitted.
func TestDecodeHopPayloadRecordValidation(t *testing.T) {
for _, test := range decodePayloadTests {
t.Run(test.name, func(t *testing.T) {
testDecodeHopPayloadValidation(t, test)
})
}
}
func testDecodeHopPayloadValidation(t *testing.T, test decodePayloadTest) {
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
var (
testTotalMsat = lnwire.MilliSatoshi(8)
testAddr = [32]byte{
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
}
htlcswitch/hop: parse and validate AMP records
2021-03-25 03:47:58 +01:00
testRootShare = [32]byte{
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12, 0x12,
}
testSetID = [32]byte{
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13, 0x13,
}
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
testEncData = []byte{3, 2, 1}
htlcswitch+invoices: log payment metadata
2022-01-11 14:15:23 +01:00
testMetadata = []byte{1, 2, 3}
htlcswitch/hop: parse and validate AMP records
2021-03-25 03:47:58 +01:00
testChildIndex = uint32(9)
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
)
htlcswitch/hop: explicitly signal final hop from sphinx packet Previously, we were using nextChanID to determine whether a hop payload is for the final recipient. This is no longer suitable in a route-blinding world where intermediate hops are allowed to have zero nextChanID TLVs (as this information is provided to forwarding nodes in their encrypted data). This commit updates payload reading to use the signal provided by sphinx that we are on the last packet, rather than implying it from the contents of a hop.
2023-11-01 15:39:33 +01:00
p, err := hop.NewPayloadFromReader(
bytes.NewReader(test.payload), test.isFinalHop,
)
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
if !reflect.DeepEqual(test.expErr, err) {
t.Fatalf("expected error mismatch, want: %v, got: %v",
test.expErr, err)
}
htlcswitch/hop/payload: parse option_mpp
2019-11-05 00:10:00 +01:00
if err != nil {
return
}
// Assert MPP fields if we expect them.
if test.shouldHaveMPP {
if p.MPP == nil {
t.Fatalf("payload should have MPP record")
}
if p.MPP.TotalMsat() != testTotalMsat {
t.Fatalf("invalid total msat")
}
if p.MPP.PaymentAddr() != testAddr {
t.Fatalf("invalid payment addr")
}
} else if p.MPP != nil {
t.Fatalf("unexpected MPP payload")
}
hop: store custom records from payload
2019-11-19 12:32:56 +01:00
htlcswitch/hop: parse and validate AMP records
2021-03-25 03:47:58 +01:00
if test.shouldHaveAMP {
if p.AMP == nil {
t.Fatalf("payload should have AMP record")
}
require.Equal(t, testRootShare, p.AMP.RootShare())
require.Equal(t, testSetID, p.AMP.SetID())
require.Equal(t, testChildIndex, p.AMP.ChildIndex())
} else if p.AMP != nil {
t.Fatalf("unexpected AMP payload")
}
htlcswitch+invoices: log payment metadata
2022-01-11 14:15:23 +01:00
if test.shouldHaveMetadata {
if p.Metadata() == nil {
t.Fatalf("payload should have metadata")
}
require.Equal(t, testMetadata, p.Metadata())
} else if p.Metadata() != nil {
t.Fatalf("unexpected metadata")
}
multi: add blinded path TLVs to onion payload / hops This commit adds the encrypted_data, blinding_point and total_amt_msat tlvs to the known set of even tlvs for the onion payload. These TLVs are added in two places (the onion payload and hop struct) because lnd uses the same set of TLV types for both structs (and they inherently represent the same thing). Note: in some places, unit tests intentionally mimic the style of older tests, so as to be more consistently readable.
2022-10-26 16:57:37 +02:00
if test.shouldHaveEncData {
require.NotNil(t, p.EncryptedData(),
"payment should have encrypted data")
require.Equal(t, testEncData, p.EncryptedData())
} else {
require.Nil(t, p.EncryptedData())
}
if test.shouldHaveBlinding {
require.NotNil(t, p.BlindingPoint())
require.Equal(t, testPubKey, p.BlindingPoint())
} else {
require.Nil(t, p.BlindingPoint())
}
if test.shouldHaveTotalAmt {
require.NotZero(t, p.TotalAmtMsat())
} else {
require.Zero(t, p.TotalAmtMsat())
}
hop: store custom records from payload
2019-11-19 12:32:56 +01:00
// Convert expected nil map to empty map, because we always expect an
// initiated map from the payload.
record: move CustomRecordSet
2019-12-12 00:01:55 +01:00
expCustomRecords := make(record.CustomSet)
hop: store custom records from payload
2019-11-19 12:32:56 +01:00
if test.expCustomRecords != nil {
expCustomRecords = test.expCustomRecords
}
if !reflect.DeepEqual(expCustomRecords, p.CustomRecords()) {
t.Fatalf("invalid custom records")
}
htlcswitch/iterator: validate presence/omission of payload types From BOLT 04: The writer: - MUST include amt_to_forward and outgoing_cltv_value for every node. - MUST include short_channel_id for every non-final node. - MUST NOT include short_channel_id for the final node.
2019-09-05 15:05:38 +02:00
}
Reference in New Issue Copy Permalink