1
0
mirror of https://github.com/lightning/bolts.git synced 2024-11-19 01:50:03 +01:00
Commit Graph

279 Commits

Author SHA1 Message Date
Rusty Russell
be3b72b768 BOLT 2: rename open_channel's max-num-htlcs to max-accepted-htlcs.
This is what it actually is (and how it's documented): you can't control
the total since both sides can add at the same time, you can only tell
the other side how many *it* can add, and control how many you add.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-25 10:31:47 +10:30
Pierre-Marie Padiou
a0bc945260 typo 2016-11-24 16:47:33 +01:00
Pierre-Marie Padiou
f8ad90b680 adding first-per-commitment-point to open_channel 2016-11-24 15:40:01 +01:00
Pierre-Marie Padiou
1781d28a97 fix tabs->spaces 2016-11-24 14:35:39 +01:00
Rusty Russell
0dd4583db1 Merge pull request #17 from lightningnetwork/funding-created-single-byte-outindex
BOLT 2: Only single byte for channel-index.
2016-11-24 12:42:36 +10:30
Rusty Russell
bfc392c6f9 Merge pull request #19 from lightningnetwork/fix-funding-locked-announce-sigs
BOLT 2: fix funding_locked announcement signatures.
2016-11-24 12:42:20 +10:30
Christian Decker
4dde8e6a26 Merge pull request #18 from lightningnetwork/license
Add CC-BY.
2016-11-23 15:49:46 +01:00
Rusty Russell
b742d2f73d BOLT 1, BOLT 2, BOLT 7: Remove message enums
The MSG_XXX is trivially derived from the name of the message if
people want to do that, so just change it to the actual message name.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-23 11:33:25 +10:30
Rusty Russell
2ea334a17f BOLT 2: fix funding_locked announcement signatures.
We need to supply a pair (a signature using our bitcoin key which signs the
node id, and a signature using our node key which signs the announce message),
and the length was wrong.  Move them to make alignment nicer, too (though
it probably doesn't matter, they're 4-byte aligned everywhere else).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-23 11:23:08 +10:30
Rusty Russell
5f5f87d124 Merge pull request #10 from lightningnetwork/feerate
BOLT 02/03: Add fee calculation details.
2016-11-23 06:27:50 +10:30
Rusty Russell
193bbef972 Add CC-BY.
Closes: #2
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-23 06:22:59 +10:30
Rusty Russell
1a132d4fab BOLT 2: Only single byte for channel-index.
And make it channel-index not channel_index to match the others (markdown
doesn't treat - specially, unlike _).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-23 06:07:08 +10:30
BitfuryLightning
25db6434fc Merge pull request #11 from rustyrussell/more-complex-gossip
BOLT #7: More complex proposal, using three separate message types.
2016-11-22 14:59:52 +02:00
Rusty Russell
9137aed167 BOLT #2: fill in descriptions and requirements for remaining fields. 2016-11-22 13:20:46 +10:30
Pierre-Marie Padiou
7bf986da23 close_signature -> closing_signed 2016-11-21 11:45:49 +01:00
Rusty Russell
2e93a4184e BOLT #7: More complex proposal, using three separate message types.
Contents stolen from Christian's draft.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-21 16:18:12 +10:30
Rusty Russell
bf80e07df0 BOLT 02/03: Add fee calculation details.
Make the fee amount by kiloweight, not by kilobyte, and spell out how
to calculate it.  Note that we have to trim HTLCs outputs whose second-stage
would also fall below dust limit, and we also make some reasonable
approximations on transaction size (which is unknowable before signatures
anyway).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-21 13:43:42 +10:30
Rusty Russell
a15f3f9ca3 BOLT #2: delete duplicate sentence.
It's already in the next paragraph.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-21 11:32:20 +10:30
Rusty Russell
60d91f2758 MSG_REVOCATION -> MSG_REVOKE_AND_ACK.
The fact that a revocation response also serves to acknowledge the
pending changes (and thus indicate the sender should apply them
to itself) is documented in the desciption, but still terribly
subtle.  Joseph suggested making it clearer, I think this
does that.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-21 10:34:43 +10:30
Rusty Russell
57b457ebd7 Merge pull request #8 from rustyrussell/fix-derivation
BOLT 2/3: watcher-compatible key derivation.

Nobody complained!
2016-11-19 10:31:40 +10:30
Pierre-Marie Padiou
db9ad2e63d BOLT #2: Add TOC
(Rebased by Rusty Russell <rusty@rustcorp.com.au>)
2016-11-18 14:02:32 +10:30
Pierre-Marie Padiou
e81ffb304c BOLT #2: Rename fee-per-kilobyte to feerate-per-kilobyte for clarity.
(Rebased by Rusty Russell <rusty@rustcorp.com.au>)
2016-11-18 14:02:21 +10:30
Pierre-Marie Padiou
18824a803a BOLT #2: Fix indent levels
(Rebased by Rusty Russell <rusty@rustcorp.com.au>)
2016-11-18 14:02:09 +10:30
Rusty Russell
32779962b5 BOLT 2/3: watcher-compatible key derivation.
After much discussion with Tadge and Laolu, I think we have something
which is nicely outsourcable, and yetnot insanely complex.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-17 14:33:22 +10:30
Pierre-Marie Padiou
fc9975f529 minor: updated open channel diagram 2016-11-16 16:24:50 -08:00
Olaoluwa Osuntokun
6c095bca5f BOLT 2: specify size of reason field in htlc fails 2016-11-15 12:30:00 -08:00
Rusty Russell
d1b7c783ac BOLT #2: fix cross-references.
And remove a duplicate sentence.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-15 14:00:37 +10:30
Rusty Russell
9b7a2922b1 BOLT #2, #5: derive maximum HTLC limit based on penalty size.
Calculations are put in 05-onchain.md, and referred to by 02-peer-protocol.

The number is 600, comfortably under the 626 theoretical limit.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-15 13:56:45 +10:30
Rusty Russell
76dfd378ff Transfer from google doc.
Minimal markdown and consistency fixes, more to come.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2016-11-15 11:53:20 +10:30