mirrors/lightning-bolts
1
0
Fork 0
mirror of https://github.com/lightning/bolts.git synced 2024-11-19 10:00:04 +01:00
Code Issues Projects Releases Wiki Activity

BOLT 1: Restore all-zero error semantics

Browse Source 
There were valid uses for "I don't want to talk to you anymore" apparently!

Also fixed some tabs -> spaces.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2022-01-04 05:55:42 +10:30
parent c36c14d6da
commit 8032f70f57
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
01-messaging.md
View File

@ -324,6 +324,8 @@ For simplicity of diagnosis, it's often useful to tell a peer that something is
#### Requirements #### Requirements
The channel is referred to by `channel_id`, unless `channel_id` is 0 (i.e. all bytes are 0), in which case it refers to all channels.
The funding node: The funding node:
- for all error messages sent before (and including) the `funding_created` message: - for all error messages sent before (and including) the `funding_created` message:
- MUST use `temporary_channel_id` in lieu of `channel_id`. - MUST use `temporary_channel_id` in lieu of `channel_id`.
@ -336,9 +338,10 @@ A sending node:
- SHOULD send `error` for protocol violations or internal errors that make channels unusable or that make further communication unusable. - SHOULD send `error` for protocol violations or internal errors that make channels unusable or that make further communication unusable.
- SHOULD send `error` with the unknown `channel_id` in reply to messages of type `32`-`255` related to unknown channels. - SHOULD send `error` with the unknown `channel_id` in reply to messages of type `32`-`255` related to unknown channels.
- when sending `error`: - when sending `error`:
- MUST fail the channel referred to by the error message. - MUST fail the channel(s) referred to by the error message.
- MAY set `channel_id` to all zero to indicate all channels.
- when sending `warning`: - when sending `warning`:
- MAY set `channel_id` to all zero if the warning is not related to a specific channel. - MAY set `channel_id` to all zero if the warning is not related to a specific channel.
- MAY close the connection after sending. - MAY close the connection after sending.
- MAY send an empty `data` field. - MAY send an empty `data` field.
- when failure was caused by an invalid signature check: - when failure was caused by an invalid signature check:
@ -346,12 +349,15 @@ A sending node:
The receiving node: The receiving node:
- upon receiving `error`: - upon receiving `error`:
- MUST fail the channel referred to by `channel_id`, if that channel is with the sending node. - if `channel_id` is all zero:
- MUST fail all channels with the sending node.
- otherwise:
- MUST fail the channel referred to by `channel_id`, if that channel is with the sending node.
- upon receiving `warning`: - upon receiving `warning`:
- SHOULD log the message for later diagnosis. - SHOULD log the message for later diagnosis.
- MAY disconnect. - MAY disconnect.
- MAY reconnect after some delay to retry. - MAY reconnect after some delay to retry.
- MAY attempt `shutdown` if permitted at this point. - MAY attempt `shutdown` if permitted at this point.
- if no existing channel is referred to by `channel_id`: - if no existing channel is referred to by `channel_id`:
- MUST ignore the message. - MUST ignore the message.
- if `data` is not composed solely of printable ASCII characters (For reference: the printable character set includes byte values 32 through 126, inclusive): - if `data` is not composed solely of printable ASCII characters (For reference: the printable character set includes byte values 32 through 126, inclusive):