mirrors/lightning-bolts
1
0
Fork 0
mirror of https://github.com/lightning/bolts.git synced 2025-03-10 09:10:07 +01:00
Code Issues Projects Releases Wiki Activity

BOLT 1: add networks to init message. (#682)

Browse source 
Add networks to init message via TLV extension.
This prevents accidentally connecting a testnet node to mainnet or the other way around.
This commit is contained in:
Rusty Russell 2020-02-18 19:16:58 +10:30 • committed by GitHub
parent 38479359a1
commit 7b0169263e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
01-messaging.md
View file

@ -244,7 +244,16 @@ The `features` field MUST be padded to bytes with 0s.
* [`gflen*byte`:`globalfeatures`] * [`gflen*byte`:`globalfeatures`]
* [`u16`:`flen`] * [`u16`:`flen`]
* [`flen*byte`:`features`] * [`flen*byte`:`features`]
* [`init_tlvs`:`tlvs`]
1. tlvs: `init_tlvs`
2. types:
1. type: 1 (`networks`)
2. data:
* [`...*chain_hash`:`chains`]
The optional `networks` indicates the chains the node is interested in.
#### Requirements #### Requirements
@ -254,6 +263,7 @@ The sending node:
- MUST set any undefined feature bits to 0. - MUST set any undefined feature bits to 0.
- SHOULD NOT set features greater than 13 in `globalfeatures`. - SHOULD NOT set features greater than 13 in `globalfeatures`.
- SHOULD use the minimum length required to represent the `features` field. - SHOULD use the minimum length required to represent the `features` field.
- SHOULD set `networks` to all chains it will gossip or open channels for.
The receiving node: The receiving node:
- MUST wait to receive `init` before sending any other messages. - MUST wait to receive `init` before sending any other messages.
@ -263,6 +273,8 @@ The receiving node:
- MUST ignore the bit. - MUST ignore the bit.
- upon receiving unknown _even_ feature bits that are non-zero: - upon receiving unknown _even_ feature bits that are non-zero:
- MUST fail the connection. - MUST fail the connection.
- upon receiving `networks` containing no common chains
- MAY fail the connection.
- if the feature vector does not set all known, transitive dependencies: - if the feature vector does not set all known, transitive dependencies:
- MUST fail the connection. - MUST fail the connection.
@ -276,6 +288,11 @@ This semantic allows both future incompatible changes and future backward compat
Nodes wait for receipt of the other's features to simplify error Nodes wait for receipt of the other's features to simplify error
diagnosis when features are incompatible. diagnosis when features are incompatible.
Since all networks share the same port, but most implementations only
support a single network, the `networks` fields avoids nodes
erroneously believing they will receive updates about their preferred
network, or that they can open channels.
### The `error` Message ### The `error` Message
For simplicity of diagnosis, it's often useful to tell a peer that something is incorrect. For simplicity of diagnosis, it's often useful to tell a peer that something is incorrect.

2
07-routing-gossip.md
View file

@ -917,6 +917,8 @@ A node:
the arrival times of the messages. the arrival times of the messages.
- Note: this results in staggered announcements that are unique (not - Note: this results in staggered announcements that are unique (not
duplicated). duplicated).
- SHOULD NOT forward gossip messages to peers who sent `networks` in `init`
and did not specify the `chain_hash` of this gossip message.
- MAY re-announce its channels regularly. - MAY re-announce its channels regularly.
- Note: this is discouraged, in order to keep the resource requirements low. - Note: this is discouraged, in order to keep the resource requirements low.
- upon connection establishment: - upon connection establishment: