mirrors/lightning-bolts
1
0
Fork 0
mirror of https://github.com/lightning/bolts.git synced 2024-11-19 01:50:03 +01:00
Code Issues Projects Releases Wiki Activity

dual-fund: add require_confirmed_inputs to RBF messages

Browse Source 
Make `require_confirmed_inputs` explicit for RBF regnegotiation.

Requested-By: @t-bast
This commit is contained in:
niftynei 2023-12-13 14:58:02 -06:00 committed by neil saitug
parent 6018a4d43b
commit 0bdaa8b9f6
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
02-peer-protocol.md
View File

@ -451,6 +451,7 @@ completed.
1. type: 0 (`funding_output_contribution`)
2. data:
* [`s64`:`satoshis`]
1. type: 2 (`require_confirmed_inputs`)
#### Requirements
@ -459,6 +460,8 @@ The sender:
of the previously constructed transaction, rounded down.
- If it contributes to the transaction's funding output:
- MUST set `funding_output_contribution`
- If it requires the receiving node to only use confirmed inputs:
- MUST set `require_confirmed_inputs`
The recipient:
- MUST respond either with `tx_abort` or with `tx_ack_rbf`
@ -466,6 +469,8 @@ The recipient:
- the `feerate` is not greater than or equal to 25/24 times `feerate`
of the last successfully constructed transaction
- MAY send `tx_abort` for any reason
- MUST fail the negotiation if:
- `require_confirmed_inputs` is set but it cannot provide confirmed inputs
#### Rationale
@ -492,21 +497,27 @@ not contributing to the funding output.
* [`channel_id`:`channel_id`]
* [`tx_ack_rbf_tlvs`:`tlvs`]
1. `tlv_stream`: `tx_ack_rbf_tlvs`
2. types:
1. type: 0 (`funding_output_contribution`)
2. data:
* [`s64`:`satoshis`]
1. type: 2 (`require_confirmed_inputs`)
#### Requirements
The sender:
- If it contributes to the transaction's funding output:
- MUST set `funding_output_contribution`
- If it requires the receiving node to only use confirmed inputs:
- MUST set `require_confirmed_inputs`
The recipient:
- MUST respond with `tx_abort` or with a `tx_add_input` message,
restarting the interactive tx collaboration protocol.
- MUST fail the negotiation if:
- `require_confirmed_inputs` is set but it cannot provide confirmed inputs
#### Rationale
@ -1286,7 +1297,8 @@ protocol, with the following additional caveats.
##### Requirements
The sending node:
- if the receiver set `require_confirmed_inputs` in `open_channel2` or `accept_channel2`:
- if the receiver set `require_confirmed_inputs` in `open_channel2`,
`accept_channel2`, `tx_init_rbf` or `tx_ack_rbf`:
- MUST NOT send a `tx_add_input` that contains an unconfirmed input
#### The `tx_add_output` Message
@ -1318,7 +1330,8 @@ Upon receipt of consecutive `tx_complete`s, the receiving node:
successfully negotiated transaction's fees
- the transaction does not share at least one input with
each previous funding transaction
- if it has sent `require_confirmed_inputs` in `open_channel2` or `accept_channel2`:
- if it has sent `require_confirmed_inputs` in `open_channel2`,
`accept_channel2`, `tx_init_rbf` or `tx_ack_rbf`:
- MUST fail the negotiation if:
- one of the inputs added by the other peer is unconfirmed