mirrors/lightning-bolts
1
0
Fork 0
mirror of https://github.com/lightning/bolts.git synced 2024-11-19 10:00:04 +01:00
Code Issues Projects Releases Wiki Activity

BOLT 3: fix definition of flip(B) in P. (#779)

Browse Source 
It turns out everyone does `P[B / 8] ^= (1 << (P % 8))`,
which is not what the spec says to do (it implies you
would treat P as a bitstring numbered 255 to 0).

See this stackoverflow question:
	https://stackoverflow.com/questions/49928131/lightning-secret-generation-from-seed

Reported-by: Janus Troelsen @ysangkok (on Twitter)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell 2020-07-07 16:28:08 +09:30 committed by GitHub
parent 9e8e29af9b
commit 0ac9a6c409
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
03-transactions.md
View File

@ -527,7 +527,9 @@ generate_from_seed(seed, I):
return P
```
Where "flip(B)" alternates the B'th least significant bit in the value P.
Where "flip(B)" alternates the (B mod 8) bit of the (B div 8)
byte of the value. So, "flip(0) in e3b0..." is "e2b0...", and
"flip(10) in "e3b0..." is "e3b4...".
The receiving node:
- MAY store all previous per-commitment secrets.