mirrors/eclair
1
0
Fork 0
mirror of https://github.com/ACINQ/eclair.git synced 2025-02-22 14:22:39 +01:00
Code Issues Projects Releases Wiki Activity

Check if closing tx is known before handling it (#587)

Browse source 
If the closing tx is already in `mutualClosePublished`, it means that we
already know about it and don't need to re-handle it again. Everytime we
succesfully negotiate a mutual close, we end up publishing ourselves the
closing tx, and right after that we are notified of this tx by the
watcher. We always ended up with duplicates in the
`mutualClosePublished`field.

This fixes #568.
This commit is contained in:
Pierre-Marie Padiou 2018-05-04 14:46:36 +02:00 • committed by GitHub
parent 30155f3262
commit 7c12a7fecf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
eclair-core/src/main/scala/fr/acinq/eclair/channel/Channel.scala
View file

@ -1096,12 +1096,12 @@ class Channel(val nodeParams: NodeParams, wallet: EclairWallet, remoteNodeId: Pu
}
case Event(WatchEventSpent(BITCOIN_FUNDING_SPENT, tx), d: DATA_CLOSING) =>
if (d.mutualCloseProposed.map(_.txid).contains(tx.txid)) {
if (d.mutualClosePublished.map(_.txid).contains(tx.txid)) {
// we already know about this tx, probably because we have published it ourselves after successful negotiation
stay
} else if (d.mutualCloseProposed.map(_.txid).contains(tx.txid)) {
// at any time they can publish a closing tx with any sig we sent them
handleMutualClose(tx, Right(d))
} else if (d.mutualClosePublished.map(_.txid).contains(tx.txid)) {
// we have published a closing tx which isn't one that we proposed, and used it instead of our last commitment when an error happened
handleMutualClose(tx, Right(d))
} else if (Some(tx.txid) == d.localCommitPublished.map(_.commitTx.txid)) {
// this is because WatchSpent watches never expire and we are notified multiple times
stay