1
0
Fork 0
mirror of https://github.com/ACINQ/eclair.git synced 2025-03-12 19:01:39 +01:00
eclair/pom.xml

281 lines
11 KiB
XML
Raw Permalink Normal View History

<!--
Merge master into Android (#1002) * Fix eclair-cli to work with equal sign in arguments (#926) * Fix eclair cli argument passing * Modify eclair-cli to work with equals in arguments * Eclair-cli: show usage when wrong params are received * Remove deprecated call from eclair-cli help message [ci skip] * Make Electrum tests pass on windows (#932) There was an obscure Docker error when trying to start an Electrum server in tests. [1] It appears that there is a conflict between Docker and Hyper-V on some range of ports. A workaround is to just change the port we were using. [1] https://github.com/docker/for-win/issues/3171 * API: fix fee rate conversion (#936) Our `open` API calls expects an optional fee rate in satoshi/byte, which is the most widely used unit, but failed to convert to satoshi/kiloweight which is the standard in LN. We also check that the converted fee rate cannot go below 253 satoshi/kiloweight. * Expose the websocket over HTTP GET to work properly with basic auth (#934) * Expose the websocket over HTTP GET * Add test for basic auth over websocket endpoint * Set max payment attempts from configuration (#931) With a default to `5`. * Add a proper payments database (#885) There is no unique identifier for payments in LN protocol. Critically, we can't use `payment_hash` as a unique id because there is no way to ensure unicity at the protocol level. Also, the general case for a "payment" is to be associated to multiple `update_add_htlc`s, because of automated retries. We also routinely retry payments, which means that the same `payment_hash` will be conceptually linked to a list of lists of `update_add_htlc`s. In order to address this, we introduce a payment id, which uniquely identifies a payment, as in a set of sequential `update_add_htlc` managed by a single `PaymentLifecycle` that ends with a `PaymentSent` or `PaymentFailed` outcome. We can then query the api using either `payment_id` or `payment_hash`. The former will return a single payment status, the latter will return a set of payment statuses, each identified by their `payment_id`. * Add a payment identifier * Remove InvalidPaymentHash channel exception * Remove unused 'close' from paymentsDb * Introduce sent_payments in PaymentDB, bump db version * Return the UUID of the ongoing payment in /send API * Add api to query payments by ID * Add 'fallbackAddress' in /receive API * Expose /paymentinfo by paymentHash * Add id column to audit.sent table, add test for db migration * Add invoices to payment DB * Add license header to ExtraDirective.scala * Respond with HTTP 404 if the corresponding invoice/paymentHash was not found. * Left-pad numeric bolt11 tagged fields to have a number of bits multiple of five (bech32 encoding). * Add invoices API * Remove CheckPayment message * GUI: consume UUID reply from payment initiator * API: reply with JSON encoded response if the queried element wasn't found * Return a payment request object in /receive * Remove limit of pending payment requests! * Avoid printing "null" fields when serializing an invoice to json * Add index on paymentDb.sent_payments.payment_hash * Order results in descending order in listPaymentRequest * Electrum: do not persist transaction locks (#953) Locks held on utxos that are used in unpublished funding transactions should not be persisted. If the app is stopped before the funding transaction has been published the channel is forgotten and so should be locks on its funding tx utxos. * Added a timeout for channel open request (#928) Until now, if the peer is unresponsive (typically doesn't respond to `open_channel` or `funding_created`), we waited indefinitely, or until the connection closed. It translated to an API timeout for users, and uncertainty about the state of the channel. This PR: - adds an optional `--openTimeoutSeconds` timeout to the `open` endpoint, that will actively cancel the channel opening if it takes too long before reaching state `WAIT_FOR_FUNDING_CONFIRMED`. - makes the `ask` timeout configurable per request with a new `--timeoutSeconds` - makes the akka http timeout slightly greater than the `ask` timeout Ask timeout is set to 30s by default. * Set `MAX_BUFFERED` to 1,000,000 (#948) Note that this doesn't mean that we will buffer 1M objects in memory: those are just pointers to (mostly) network announcements that already exist in our routing table. Routing table has recently gone over 100K elements (nodes, announcements, updates) and this causes the connection to be closed when peer requests a full initial sync. * Fix Dockerfile maven binary checksum (#956) The Maven 3.6.0 SHA256 checksum was invalid and caused the docker build to fail. * Add channel errors in audit db (#955) We now keep track of all local/remote channel errors in the audit db. * Added simple plugin support (#927) Using org.clapper:classutil library and a very simple `Plugin` interface. * Live channel database backup (#951) * Backup running channel database when needed Every time our channel database needs to be persisted, we create a backup which is always safe to copy even when the system is busy. * Upgrade sqlite-jdbc to 3.27.2.1 * BackupHandler: use a specific bounded mailbox BackupHandler is now private, users have to call BackupHandler.props() which always specifies our custom bounded maibox. * BackupHandler: use a specific threadpool with a single thread * Add backup notification script Once a new backup has been created, call an optional user defined script. * Update readme with bitcoin 0.17 instructions (#958) This has somehow been missed by PR #826. * Backup: explicitely specify move options (#960) * Backup: explicitely specify move options We now specify that we want to atomically overwrite the existing backup file with the new one (fixes a potential issue on Windows). We also publish a specific notification when the backup process has been completed. * Print stack trace when crashing during boot sequence (#949) * Print stack trace when crashing during boot sequence * Use friendly message when db compatibility check fails * ElectrumWallet should not send ready if syncing (#963) This commit is already embedded in version `0.2-android-beta22`. * Channel: Log additional data (#943) * Channel: Log additional data Log local channel parameters, and our peer's open or accept message. This should be enough to recompute keys needed to recover funds in case of unilateral close. * Electrum: make debug logs shorter (#964) * Better handling of closed channels (#944) * Remove closed channels when application starts If the app is stopped just after a channel has transition from CLOSING to CLOSED, when the application starts again if will be restored as CLOSING. This commit checks channel data and remove closed channels instead of restoring them. * Channels Database: tag closed channels but don't delete them Instead we add a new `closed` column that we check when we restore channels. * Document how we check and remove closed channels on startup * Do not print the stacktrace on stderr when there is an error at boot (#966) * Do not print the stacktrace on stdout when there is an error at boot * Fix flaky test in PaymentLifecycleSpec (#967) * Use local random pamentHash for each test in paymentlifecyclespec, intercept the route request before the router. * Rename `eclair.bak` to `eclair.sqlite.bak` (#968) This removes any ambiguity about what the content of the file is about. * Fixed concurrency issue in `IndexedObservableList` (#961) Update map with new indexes after element is removed Fixes #915 * Various fix and improvements in time/timestamp handling (#971) This PR standardizes the way we compute the current time as unix timestamp - Scala's Platform is used and the conversion is done via scala's concurrent.duration facilities - Java's Instant has been replaced due to broken compatibility with android - AuditDB events use milliseconds (fixes #970) - PaymentDB events use milliseconds - Query filters for AuditDB and PaymentDB use seconds * API: Support query by `channelId` or `shortChannelId` everywhere (#969) Add support for querying a channel information by its `shortChannelId`. * Smarter strategy for sending `channel_update`s (#950) The goal is to prevent sending a lot of updates for flappy channels. Instead of sending a disabled `channel_update` after each disconnection, we now wait for a payment to try to route through the channel and only then reply with a disabled `channel_update` and broadcast it on the network. The reason is that in case of a disconnection, if noone cares about that channel then there is no reason to tell everyone about its current (disconnected) state. In addition to that, when switching from `SYNCING`->`NORMAL`, instead of emitting a new `channel_update` with flag=enabled right away, we wait a little bit and send it later. We also don't send a new `channel_update` if it is identical to the previous one (except if the previous one is outdated). This way, if a connection to a peer is unstable and we keep getting disconnected/reconnected, we won't spam the network. The extra delay allows us to remove the change made in #888, which was a workaround in case we generated `channel_update` too quickly. Also, increased refresh interval from 7 days to 10 days. There was no need to be so conservative. Note that on startup we still need to re-send `channel_update` for all channels in order to properly initialize the `Router` and the `Relayer`. Otherwise they won't know about those channels, and e.g. the `Relayer` will return `UnknownNextPeer` errors. But we don't need to create new `channel_update`s in most cases, so this should have little or no impact to gossip because our peers will already know the updates and will filter them out. On the other hand, if some global parameters (like relaying fees) are changed, it will cause the creation a new `channel_update` for all channels. * Fixed overflow issue with max duration (#975) This is a regression caused by #971, because `Duration` has a max value of `Long.MaxValue` *nanoseconds*, not *seconds*. * Use proper closing type in `ChannelClosed` event (#977) There was actually a change introduced by #944 where we used `ClosingType.toString` instead of manually defining types, causing a regression in the audit database. * Update bash autocompletion for eclair-cli (#983) * Update bash autocompletition file to suggest all the endpoints * Update list of commands in eclair-cli help message * Replace `UnknownPaymentHash` and `IncorrectPaymentAmount` with `IncorrectOrUnknownPaymentDetails` (#984) See https://github.com/lightningnetwork/lightning-rfc/pull/516 and https://github.com/lightningnetwork/lightning-rfc/pull/544 * Wireshark dissector support (#981) * Transport: add support for encryption key logging. This is the format the wireshark lightning-dissector uses to be able to decrypt lightning messages. * Enrich test for internal eclair API implementation (fr.acinq.eclair.Eclair.scala) (#938) * Add test to EclairImpl for `/send`, `/allupdates` and `/forceclose/` * Set default chain to "mainnet" (#989) Eclair is now configured to run on mainnet by default. * Set tcp client timeout to 20s (#990) So that it fails before the ask/api time out. * Add bot support for code coverage (codecov) (#982) * Add scoverage-maven-plugin dependency * Update travis build to generate a scoverage report * Add custom codecov configuration to have nice PR comments * Add badge for test coverage in readme * Accept `commit_sig` without changes (#988) LND sometimes sends a new signature without any changes, which is a (harmless) spec violation. Note that the test was previously not failing because it wasn't specific enough. The test now fails and has been ignored. * Ignore subprojects eclair-node/eclair-node-gui in the codecov report (#991) * Use bitcoind fee estimator first (#987) * use bitcoind fee provider first * set default `smooth-feerate-window`=6 * Configuration: increase fee rate mismatch threshold We wil accept fee rates that up to 8x bigger or smaller than our local fee rate * Updated license header (#992) * Release v0.3 (#994) * gui: include javafx native libraries for windows, mac, linux * Release v0.3 * Set version to 0.3.1-SNAPSHOT * Improved test coverage of `io` package (#996) * improved test coverage of `NodeURI` * improved test coverage of `Peer` * Fix TextUI * BackupHandler: use renameTo() on Android Most Path methods are not available at our current API level
2019-05-21 17:56:47 +02:00
~ Copyright 2019 ACINQ SAS
~
~ Licensed under the Apache License, Version 2.0 (the "License");
~ you may not use this file except in compliance with the License.
~ You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
-->
2015-08-19 13:57:05 +02:00
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
2015-08-19 14:05:14 +02:00
<groupId>fr.acinq.eclair</groupId>
2015-08-19 13:57:05 +02:00
<artifactId>eclair_2.11</artifactId>
2024-11-21 19:18:41 +01:00
<version>0.4.25-android-phoenix</version>
2015-08-19 13:57:05 +02:00
<packaging>pom</packaging>
<modules>
<module>eclair-core</module>
2016-08-26 18:31:12 +02:00
<module>eclair-node</module>
2015-08-19 13:57:05 +02:00
</modules>
<description>A scala implementation of the Lightning Network</description>
<url>https://github.com/ACINQ/eclair</url>
2015-08-19 13:57:05 +02:00
<name>${project.artifactId}</name>
<licenses>
<license>
<url>https://raw.githubusercontent.com/ACINQ/eclair/master/LICENSE</url>
<name>Apache License</name>
<distribution>repo</distribution>
</license>
</licenses>
<scm>
<connection>scm:git:git@github.com:ACINQ/eclair.git</connection>
<developerConnection>scm:git:git@github.com:ACINQ/eclair.git</developerConnection>
<url>git@github.com:ACINQ/eclair.git</url>
</scm>
<developers>
<developer>
[Android] Support for electrumx API (#214) * back to 0.2-SNAPHOT (#166) use scala plugin 3.3.1 (mvn scala:console now works) add Dominique to the list of developpers * Process `update_fail_malformed_htlc` properly (#168) * add a test that fails and shows that we don't process `update_fail_malformed` properly * remove HTLCs failed with update_fail_malformed * fixes #167 * Re-send htlc/sigs after `funding_locked` (#169) We previously skipped the `handleSync` function when we had to re-send `funding_locked` messages on reconnection. This didn't take into account the fact that we might have been disconnected right after sending the very first `commit_sig` in the channel. In that case we need to first re-send `funding_locked`, then re-send whatever updates were included in the lost signature, and finally re-send the same `commit_sig`. Note that the specification doesn't require to re-send the exact same updates and signatures on reconnection. But doing this allows for a single commitment history and allows us not to keep track of all signatures sent to the other party. Closes #165 * Handle `update_fail_malformed_htlc` in payment FSM (#170) * handling `update_fail_malformed` messages in payment fsm * added check on failure code for malformed htlc errors Spec says that the `update_fail_malformed_htlc`.`failure_code` must have the BADONION bit set. * removed hard-coded actor names in fuzzy tests * Added an integration test on revoked tx handling (#172) The scenario was already tested at a lower level, but this is more realistic, with a real bitcoin core. Note that we currently only steal the counterparty's *main output*, we ignore pending htlcs. From an incentive point-of-view, it is an acceptable tradeoff because the amount of in-flight htlcs should typically be far less than the main outputs (and can be configured with `max-htlc-value-in-flight-msat`). * Added ACK-based TCP write back-pressure (#174) Current implementation was simplistic, which resulted in writes being rejected when OS buffer was full. This happened especially right after connection, when dumping a large routing table. It is not clear whether we need read throttling too. * Added check amount>dust on `ClaimDelayedOutputTx` (#177) The current trimming logic [1] as defined in the spec only takes care of 2nd level txes, making sure that their outputs are greater than the configured dust limit. However, it is very possible that depending on the current `feeRatePerKw`, 3rd level transactions (such as those claiming delayed outputs) are below the dust limit. Current implementation wasn't taking care of that, and was happily generating transactions with negative amounts, as reported in #164. This fixes #164 by rejecting transactions with an amount below the dust limit, similarly to what happens when the parent output is trimmed for 2nd level txes. [1] https://github.com/lightningnetwork/lightning-rfc/blob/master/03-transactions.md#trimmed-outputs * Reworked handling of `shutdown` messages (#176) Current version attempted to do everything at once, and would always leave the NORMAL state after processing the `shutdown` message. In addition to being overly complicated, it had bugs because it is just not always possible to do so: for example when we have unsigned outgoing `update_add_htlc` and are already in the process of signing older changes, the only thing we can do is wait for the counterparty's `revoke_and_ack` and sign again right away when we receive it. Only after that can we send our `shutdown` message, and we can't accept new `update_add_htlc` in the meantime. Another issue with the current implementation was that we considered unsigned outgoing *changes*, when only unsigned outgoing `update_add_htlc` are relevant in the context of `shutdown` logic. We now also fail to route htlcs in SHUTDOWN state, as recommended by BOLT 2. This fixes #173. * Base checks in `sendAdd` on the *last* sent sig (#180) fixes #175 * Store state when a sig is received in SHUTDOWN (#181) This fixes #173 (for good this time) * Support multiple hops in RoutingInfoTag (#185) * Support multiple hops in RoutingInfoTag * Change `HiddenHop` to `ExtraHop`, `channelId: BinaryData` to `shortChannelId: Long` * payment request: encode expiry as a varlen unsigned long (#188) * payment request expiry encoding: add Anton's test it shows that we don't encode/decode values which would take up more than 2 5-bits value * payment request: encode expiry as a varlen unsigned value fixes #186 * Have channels subscribe to blockchain events at creation (#195) Instead of only subscribing to those events when we reach certain states, we now always subscribe to them at startup. It doesn't cost a lot because we receive an event only when a new block appears, and is much simpler. Note that we previously didn't even bother unsubscribing when we weren't interested anymore in the events, and were ignoring the messages in the `whenUnhandled` block. So it is more consistent to have the same behavior during the whole lifetime of the channel. This fixes #187. * Add primary key to channel_updates table (#199) This table was missing a primary key, which caused it to grow indefinitely. Also added duplication tests to other tables. * Always store channel state when a rev is received (#201) The way the store data currently doesn't allow for easy testing of this. It will be improved in a later iteration. This fixes #200. * Add an optional 'minimum htlc expiry' tag (#202) * Support building payments with extra hops (#198) * Support building of outgoing payments with optional extra hops from payment requests * Add test for route calculation with extra hops * Simplify pattern matching in `buildExtra` * `buildPayment` now uses a reverse Seq[Hop] to create a Seq[ExtraHop] Since `Router` currently stores `ChannelUpdate`'s for non-public channels, it is possible to use it not only to get a route from payer to payee but also to get a "reverse" assisted route from payee when creating a `PaymentRequest`. In principle this could be used to even generate a full reverse path to a payer which does not have an access to routing table for some reason. * Can create `PaymentRequest`s with `RoutingInfoTag`s * Bugfix and update test with data from live payment testing * Move ExtraHop to PaymentRequest.scala * Use `min_final_cltv_expiry` included in payment request (if any) (#210) * Lock utxos when creating a funding transaction with Bitcoin Core (#211) This mitigates issues when opening channels in parallel and having unpublished transactions reuse utxos that are already used by other txs. Note that utxo will stay locked if counterparty disconnects after the `funding_created` message is sent, and before a `funding_signed` is received. In that case we should release locked utxos by calling `lockunspent` RPC function. * Readme: added help for options syntax (#212) * (README) updated link to release readme * (README) added a link to HOCON readme for options syntax This closes #209 * Rework preimage handling (#183) * properly handle new htlc requests when closing When in NORMAL state and a `shutdown` message has already been sent or received, then any subsequent `CMD_ADD_HTLC` fails and the relayer is notified of the failure. Same in SHUTDOWN state. This fixes a possible race condition when a channel just switched to SHUTDOWN, and the relayer keeps sending it new htlcs before being notified of the state change. * renamed Htlc->DirectedHtlc + cleanup * storing origin of htlcs in the channel state Currently this information is handled in the relayer, which is not persisted. As a consequence, if eclair is shut down and there are pending (signed) incoming htlcs, those will always expire (time out and fail) even if the corresponding outgoing htlc is fulfilled, because we lose the lookup table (the relayer's `bindings` map). Storing the origin in the channel (as opposed to persisting the state of the relayer) makes sense because we want to store the origin if and only if an outgoing htlc was successfully sent and signed in a channel. It is also probably more performant because we only need to do one disk operation (which we have to do at signing anyway) instead of two distinct operations. * removed bindings from relayer Instead, we rely on the origin stored in the actor state. * preimages are now persisted and acknowledged Upon reception of an `UpdateFulfillHtlc`, the relayer forwards it immediately to the origin channel, *and* it stores the preimage in a `PreimagesDb`. When the origin channel has irrevocably committed the fulfill in a `CommitSig`, it sends an `AckFulfillCmd` back to the relayer, which will then remove the preimage from its database. In addition to that, the relayer will re-send all pending fulfills when it is notified that a channel reaches NORMAL, SHUTDOWN, or CLOSING state. That way we make sure that the origin channel will always get the fulfill eventually, even if it currently OFFLINE for example. This fixes #146. Also, the relayer now relies on the register to forward messages to channels based on `channelId` or `shortChannelId`. This simplifies the relayer but adds one hop when forwarding messages. * modified `PaymentRelayed` event Replaced `amountIn` and `feesEarned` by more explicit `amountIn` and `amountOut`. `feesEarned` are simply the difference. TODO: - when local/remote closing a channel, we currently do not wait for htlc-related transactions, we consider the channel CLOSED when the commitment transactions has been buried deeply enough; this is wrong because it wouldn't let us time to extract payment preimages in certain cases * Reworked channel closing logic (#204) When doing an unilateral close (local or remote), we previously weren't watching htlc outputs to decide whether the commit was finished or not. This was incorrect because we didn't make sure the htlc-related transactions had indeed been confirmed on the blockchain, making us potentially lose money. This is not trivial, because htlc transactions may be double-spent by the counterparty, dependending on scenarios (ex: `htlc-timeout` vs `claim-success`). On top of that, there may be several different kind of commits in competition at the same time. With this change, we now: - put `WatchConfirm` watches on the commitment tx, and on all outputs only us control (eg: our main output) ; - put `WatchSpent` watches on the outputs that may be double spent by the counterparty; when such an output is spent, we put a `WatchConfirm` on the corresponding transaction and keep track of all outpoints spent ; - every time a new transaction is confirmed, we find out if there are some remaining transactions waiting for confirmation, taking into account the fact that some 2nd/3rd-stage txs may never confirm because their input has been doublespent. We also don't rely anymore on dedicated `BITCOIN_CLOSE_DONE`, `BITCOIN_LOCALCOMMIT_DONE`, ... events. * Better handle big routing table (#194) * increased tcp send buffer x100 * throttle announcement messages when dumping the table * set router throttling to chunkSize=10 delay=50ms * Handle remote `error` in `SYNCING` state (#205) This closes #203. * added support for electrumx wallet/watcher This is a rework of #184 with numerous improvements and bugfixes. * re-enabled `WatchSpentBasic` * fixed several issues in watcher * fixed pattern matching for INPUT_RECONNECTED event in CLOSING * reduced logback_colors log level * disabled WatchSpentBasic on android * moved bitcoin init to the bootstrap future This way the name resolution when loading electrum server addresses does not occur on android's main thread. * improved fees management * main feerate source is now earn.com (21.co) instead of bitpay insight * if main feerate source is unavailable, we now fallback to default values * we retrieve feerates for a set of block delays instead of just one * we now use different block delays depending on transactions: - `block_delay`=`1` for txes that compete with others (eg: commitment tx, htlc tx, penalty tx) - `block_delay`=`6` for other txes (eg: funding tx, closing tx, delayed output tx) TODO: - set sensible default values for feerates * WalletTransactionReceive contains the tx fee as an option * connect txes even if they arrive out of order * use manual transitions because of limitation in akka 2.3 FSM * Delay `announcement_signatures` when received early (#217) * delay `announcement_signatures` in state `WAIT_FOR_FUNDING_LOCKED` * delay `announcement_signatures` in state `WAIT_FOR_FUNDING_CONFIRMED` * always re-send our `announcement_signatures` in response to theirs * Use a separate `htlc_key` to sign 2nd stage htlc txs (#213) We previously used the `payment_key` both for our main output, and to sign the local `htlc_success`/`htlc_timeout` transactions. With this change we can keep the `payment_privkey` offline, which is far better from a security point of view because an attacker getting control of a node wouldn't be able to just publish the current commitment transaction and get the funds. The attacker would only be able to get our `htlc_privkey`, which we only use in a 2-of-2 multisig with our counterparty, so it is useless except if the attacker and the counterparty are the same person, and even in that case only the pending htlcs would be at risk. Note that this implementation is a first step and actually keeps the payment key to spend our outputs in non-mutual close scenarios. * wallet: send confidence event as soon as a tx is confirmed * fixed 5985148f2fc727dadbe9ffece596ed61331435b6 and improve events * added `NewWalletReceiveAddress` event * cleaned up electrum testnet seeds * added a test on dumping routing state * routing table dump is now disabled in the router instead of peer * removed WAIT_FOR_FUNDING_PUBLISHED state and clarified funding tx publish assumptions * wallet: use BIP49 derivation and 24 words mnemonic codes we use segwit with p2sh-of-p2wkh so we should use BIP49 derivation instead of BIP44 (same path with m/49'/... instead of m/44'/...) * added a rollback function to `EclairWallet` This rollback is called whenever we know we won't publish the funding tx, so that we tell the wallet to release locks on utxos. * fundee now checks feerates at `open_channel` reception * proper handling of electrum connection/disconnection * moved bitcoinj test to its own package * Improved fees management (#216) * main feerate source is now earn.com (21.co) instead of bitpay insight * if main feerate source is unavailable, we now fallback to default values * we retrieve feerates for a set of block delays instead of just one * we now use different block delays depending on transactions: - `block_delay`=`1` for txes that compete with others (eg: commitment tx, htlc tx, penalty tx) - `block_delay`=`6` for other txes (eg: funding tx, closing tx, delayed output tx) * make electrum wallet advertise address at startup * Prune stale network announcements (#219) See https://github.com/lightningnetwork/lightning-rfc/blob/master/07-routing-gossip.md#recommendation-on-pruning-stale-entries. * send a new `channel_update` every 24h as keepalive * use case object instead of symbol for ticks * minor improvements in router init * prune stale channels Note that we don't want to prune brand new channels for which we didn't yet receive a channel update, so we consider stale a channel that: (1) is older than 2 weeks (2*7*144 = 2016 blocks) AND (2) didn't have an update during the last 2 weeks. Pruning is triggered every day. Also renamed event `BITCOIN_FUNDING_OTHER_CHANNEL_SPENT` to `BITCOIN_FUNDING_EXTERNAL_CHANNEL_SPENT`. * filter out duplicate announcements before checking sig * changed routing table dump parameters * set version to 0.2-android-SNAPSHOT
2017-11-21 18:25:27 +01:00
<id>dpad85</id>
</developer>
<developer>
<id>pm47</id>
</developer>
[Android] Support for electrumx API (#214) * back to 0.2-SNAPHOT (#166) use scala plugin 3.3.1 (mvn scala:console now works) add Dominique to the list of developpers * Process `update_fail_malformed_htlc` properly (#168) * add a test that fails and shows that we don't process `update_fail_malformed` properly * remove HTLCs failed with update_fail_malformed * fixes #167 * Re-send htlc/sigs after `funding_locked` (#169) We previously skipped the `handleSync` function when we had to re-send `funding_locked` messages on reconnection. This didn't take into account the fact that we might have been disconnected right after sending the very first `commit_sig` in the channel. In that case we need to first re-send `funding_locked`, then re-send whatever updates were included in the lost signature, and finally re-send the same `commit_sig`. Note that the specification doesn't require to re-send the exact same updates and signatures on reconnection. But doing this allows for a single commitment history and allows us not to keep track of all signatures sent to the other party. Closes #165 * Handle `update_fail_malformed_htlc` in payment FSM (#170) * handling `update_fail_malformed` messages in payment fsm * added check on failure code for malformed htlc errors Spec says that the `update_fail_malformed_htlc`.`failure_code` must have the BADONION bit set. * removed hard-coded actor names in fuzzy tests * Added an integration test on revoked tx handling (#172) The scenario was already tested at a lower level, but this is more realistic, with a real bitcoin core. Note that we currently only steal the counterparty's *main output*, we ignore pending htlcs. From an incentive point-of-view, it is an acceptable tradeoff because the amount of in-flight htlcs should typically be far less than the main outputs (and can be configured with `max-htlc-value-in-flight-msat`). * Added ACK-based TCP write back-pressure (#174) Current implementation was simplistic, which resulted in writes being rejected when OS buffer was full. This happened especially right after connection, when dumping a large routing table. It is not clear whether we need read throttling too. * Added check amount>dust on `ClaimDelayedOutputTx` (#177) The current trimming logic [1] as defined in the spec only takes care of 2nd level txes, making sure that their outputs are greater than the configured dust limit. However, it is very possible that depending on the current `feeRatePerKw`, 3rd level transactions (such as those claiming delayed outputs) are below the dust limit. Current implementation wasn't taking care of that, and was happily generating transactions with negative amounts, as reported in #164. This fixes #164 by rejecting transactions with an amount below the dust limit, similarly to what happens when the parent output is trimmed for 2nd level txes. [1] https://github.com/lightningnetwork/lightning-rfc/blob/master/03-transactions.md#trimmed-outputs * Reworked handling of `shutdown` messages (#176) Current version attempted to do everything at once, and would always leave the NORMAL state after processing the `shutdown` message. In addition to being overly complicated, it had bugs because it is just not always possible to do so: for example when we have unsigned outgoing `update_add_htlc` and are already in the process of signing older changes, the only thing we can do is wait for the counterparty's `revoke_and_ack` and sign again right away when we receive it. Only after that can we send our `shutdown` message, and we can't accept new `update_add_htlc` in the meantime. Another issue with the current implementation was that we considered unsigned outgoing *changes*, when only unsigned outgoing `update_add_htlc` are relevant in the context of `shutdown` logic. We now also fail to route htlcs in SHUTDOWN state, as recommended by BOLT 2. This fixes #173. * Base checks in `sendAdd` on the *last* sent sig (#180) fixes #175 * Store state when a sig is received in SHUTDOWN (#181) This fixes #173 (for good this time) * Support multiple hops in RoutingInfoTag (#185) * Support multiple hops in RoutingInfoTag * Change `HiddenHop` to `ExtraHop`, `channelId: BinaryData` to `shortChannelId: Long` * payment request: encode expiry as a varlen unsigned long (#188) * payment request expiry encoding: add Anton's test it shows that we don't encode/decode values which would take up more than 2 5-bits value * payment request: encode expiry as a varlen unsigned value fixes #186 * Have channels subscribe to blockchain events at creation (#195) Instead of only subscribing to those events when we reach certain states, we now always subscribe to them at startup. It doesn't cost a lot because we receive an event only when a new block appears, and is much simpler. Note that we previously didn't even bother unsubscribing when we weren't interested anymore in the events, and were ignoring the messages in the `whenUnhandled` block. So it is more consistent to have the same behavior during the whole lifetime of the channel. This fixes #187. * Add primary key to channel_updates table (#199) This table was missing a primary key, which caused it to grow indefinitely. Also added duplication tests to other tables. * Always store channel state when a rev is received (#201) The way the store data currently doesn't allow for easy testing of this. It will be improved in a later iteration. This fixes #200. * Add an optional 'minimum htlc expiry' tag (#202) * Support building payments with extra hops (#198) * Support building of outgoing payments with optional extra hops from payment requests * Add test for route calculation with extra hops * Simplify pattern matching in `buildExtra` * `buildPayment` now uses a reverse Seq[Hop] to create a Seq[ExtraHop] Since `Router` currently stores `ChannelUpdate`'s for non-public channels, it is possible to use it not only to get a route from payer to payee but also to get a "reverse" assisted route from payee when creating a `PaymentRequest`. In principle this could be used to even generate a full reverse path to a payer which does not have an access to routing table for some reason. * Can create `PaymentRequest`s with `RoutingInfoTag`s * Bugfix and update test with data from live payment testing * Move ExtraHop to PaymentRequest.scala * Use `min_final_cltv_expiry` included in payment request (if any) (#210) * Lock utxos when creating a funding transaction with Bitcoin Core (#211) This mitigates issues when opening channels in parallel and having unpublished transactions reuse utxos that are already used by other txs. Note that utxo will stay locked if counterparty disconnects after the `funding_created` message is sent, and before a `funding_signed` is received. In that case we should release locked utxos by calling `lockunspent` RPC function. * Readme: added help for options syntax (#212) * (README) updated link to release readme * (README) added a link to HOCON readme for options syntax This closes #209 * Rework preimage handling (#183) * properly handle new htlc requests when closing When in NORMAL state and a `shutdown` message has already been sent or received, then any subsequent `CMD_ADD_HTLC` fails and the relayer is notified of the failure. Same in SHUTDOWN state. This fixes a possible race condition when a channel just switched to SHUTDOWN, and the relayer keeps sending it new htlcs before being notified of the state change. * renamed Htlc->DirectedHtlc + cleanup * storing origin of htlcs in the channel state Currently this information is handled in the relayer, which is not persisted. As a consequence, if eclair is shut down and there are pending (signed) incoming htlcs, those will always expire (time out and fail) even if the corresponding outgoing htlc is fulfilled, because we lose the lookup table (the relayer's `bindings` map). Storing the origin in the channel (as opposed to persisting the state of the relayer) makes sense because we want to store the origin if and only if an outgoing htlc was successfully sent and signed in a channel. It is also probably more performant because we only need to do one disk operation (which we have to do at signing anyway) instead of two distinct operations. * removed bindings from relayer Instead, we rely on the origin stored in the actor state. * preimages are now persisted and acknowledged Upon reception of an `UpdateFulfillHtlc`, the relayer forwards it immediately to the origin channel, *and* it stores the preimage in a `PreimagesDb`. When the origin channel has irrevocably committed the fulfill in a `CommitSig`, it sends an `AckFulfillCmd` back to the relayer, which will then remove the preimage from its database. In addition to that, the relayer will re-send all pending fulfills when it is notified that a channel reaches NORMAL, SHUTDOWN, or CLOSING state. That way we make sure that the origin channel will always get the fulfill eventually, even if it currently OFFLINE for example. This fixes #146. Also, the relayer now relies on the register to forward messages to channels based on `channelId` or `shortChannelId`. This simplifies the relayer but adds one hop when forwarding messages. * modified `PaymentRelayed` event Replaced `amountIn` and `feesEarned` by more explicit `amountIn` and `amountOut`. `feesEarned` are simply the difference. TODO: - when local/remote closing a channel, we currently do not wait for htlc-related transactions, we consider the channel CLOSED when the commitment transactions has been buried deeply enough; this is wrong because it wouldn't let us time to extract payment preimages in certain cases * Reworked channel closing logic (#204) When doing an unilateral close (local or remote), we previously weren't watching htlc outputs to decide whether the commit was finished or not. This was incorrect because we didn't make sure the htlc-related transactions had indeed been confirmed on the blockchain, making us potentially lose money. This is not trivial, because htlc transactions may be double-spent by the counterparty, dependending on scenarios (ex: `htlc-timeout` vs `claim-success`). On top of that, there may be several different kind of commits in competition at the same time. With this change, we now: - put `WatchConfirm` watches on the commitment tx, and on all outputs only us control (eg: our main output) ; - put `WatchSpent` watches on the outputs that may be double spent by the counterparty; when such an output is spent, we put a `WatchConfirm` on the corresponding transaction and keep track of all outpoints spent ; - every time a new transaction is confirmed, we find out if there are some remaining transactions waiting for confirmation, taking into account the fact that some 2nd/3rd-stage txs may never confirm because their input has been doublespent. We also don't rely anymore on dedicated `BITCOIN_CLOSE_DONE`, `BITCOIN_LOCALCOMMIT_DONE`, ... events. * Better handle big routing table (#194) * increased tcp send buffer x100 * throttle announcement messages when dumping the table * set router throttling to chunkSize=10 delay=50ms * Handle remote `error` in `SYNCING` state (#205) This closes #203. * added support for electrumx wallet/watcher This is a rework of #184 with numerous improvements and bugfixes. * re-enabled `WatchSpentBasic` * fixed several issues in watcher * fixed pattern matching for INPUT_RECONNECTED event in CLOSING * reduced logback_colors log level * disabled WatchSpentBasic on android * moved bitcoin init to the bootstrap future This way the name resolution when loading electrum server addresses does not occur on android's main thread. * improved fees management * main feerate source is now earn.com (21.co) instead of bitpay insight * if main feerate source is unavailable, we now fallback to default values * we retrieve feerates for a set of block delays instead of just one * we now use different block delays depending on transactions: - `block_delay`=`1` for txes that compete with others (eg: commitment tx, htlc tx, penalty tx) - `block_delay`=`6` for other txes (eg: funding tx, closing tx, delayed output tx) TODO: - set sensible default values for feerates * WalletTransactionReceive contains the tx fee as an option * connect txes even if they arrive out of order * use manual transitions because of limitation in akka 2.3 FSM * Delay `announcement_signatures` when received early (#217) * delay `announcement_signatures` in state `WAIT_FOR_FUNDING_LOCKED` * delay `announcement_signatures` in state `WAIT_FOR_FUNDING_CONFIRMED` * always re-send our `announcement_signatures` in response to theirs * Use a separate `htlc_key` to sign 2nd stage htlc txs (#213) We previously used the `payment_key` both for our main output, and to sign the local `htlc_success`/`htlc_timeout` transactions. With this change we can keep the `payment_privkey` offline, which is far better from a security point of view because an attacker getting control of a node wouldn't be able to just publish the current commitment transaction and get the funds. The attacker would only be able to get our `htlc_privkey`, which we only use in a 2-of-2 multisig with our counterparty, so it is useless except if the attacker and the counterparty are the same person, and even in that case only the pending htlcs would be at risk. Note that this implementation is a first step and actually keeps the payment key to spend our outputs in non-mutual close scenarios. * wallet: send confidence event as soon as a tx is confirmed * fixed 5985148f2fc727dadbe9ffece596ed61331435b6 and improve events * added `NewWalletReceiveAddress` event * cleaned up electrum testnet seeds * added a test on dumping routing state * routing table dump is now disabled in the router instead of peer * removed WAIT_FOR_FUNDING_PUBLISHED state and clarified funding tx publish assumptions * wallet: use BIP49 derivation and 24 words mnemonic codes we use segwit with p2sh-of-p2wkh so we should use BIP49 derivation instead of BIP44 (same path with m/49'/... instead of m/44'/...) * added a rollback function to `EclairWallet` This rollback is called whenever we know we won't publish the funding tx, so that we tell the wallet to release locks on utxos. * fundee now checks feerates at `open_channel` reception * proper handling of electrum connection/disconnection * moved bitcoinj test to its own package * Improved fees management (#216) * main feerate source is now earn.com (21.co) instead of bitpay insight * if main feerate source is unavailable, we now fallback to default values * we retrieve feerates for a set of block delays instead of just one * we now use different block delays depending on transactions: - `block_delay`=`1` for txes that compete with others (eg: commitment tx, htlc tx, penalty tx) - `block_delay`=`6` for other txes (eg: funding tx, closing tx, delayed output tx) * make electrum wallet advertise address at startup * Prune stale network announcements (#219) See https://github.com/lightningnetwork/lightning-rfc/blob/master/07-routing-gossip.md#recommendation-on-pruning-stale-entries. * send a new `channel_update` every 24h as keepalive * use case object instead of symbol for ticks * minor improvements in router init * prune stale channels Note that we don't want to prune brand new channels for which we didn't yet receive a channel update, so we consider stale a channel that: (1) is older than 2 weeks (2*7*144 = 2016 blocks) AND (2) didn't have an update during the last 2 weeks. Pruning is triggered every day. Also renamed event `BITCOIN_FUNDING_OTHER_CHANNEL_SPENT` to `BITCOIN_FUNDING_EXTERNAL_CHANNEL_SPENT`. * filter out duplicate announcements before checking sig * changed routing table dump parameters * set version to 0.2-android-SNAPSHOT
2017-11-21 18:25:27 +01:00
<developer>
<id>sstone</id>
</developer>
</developers>
2015-08-19 13:57:05 +02:00
<properties>
<project.build.outputTimestamp>2020-01-01T00:00:00Z</project.build.outputTimestamp>
2015-08-19 13:57:05 +02:00
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2017-08-25 12:24:54 +02:00
<maven.compiler.source>1.7</maven.compiler.source>
<maven.compiler.target>1.7</maven.compiler.target>
<scala.version>2.11.12</scala.version>
2015-08-19 13:57:05 +02:00
<scala.version.short>2.11</scala.version.short>
2019-10-31 17:23:05 +01:00
<akka.version>2.3.14</akka.version>
<akka.http.version>10.0.11</akka.http.version>
<sttp.version>1.3.9</sttp.version>
<bitcoinlib.version>0.18.3</bitcoinlib.version>
<guava.version>24.0-android</guava.version>
<kamon.version>2.1.0</kamon.version>
2015-08-19 13:57:05 +02:00
</properties>
<build>
<pluginManagement>
<plugins>
2017-12-03 17:46:41 +01:00
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<version>3.0.2</version>
<executions>
<execution>
<phase>package</phase>
<goals>
<goal>copy-dependencies</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/lib</outputDirectory>
</configuration>
</execution>
</executions>
2017-12-03 17:46:41 +01:00
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>3.2.0</version>
</plugin>
2015-08-19 13:57:05 +02:00
</plugins>
</pluginManagement>
<plugins>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<version>3.2.0</version>
<inherited>true</inherited>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>versions-maven-plugin</artifactId>
<version>2.3</version>
</plugin>
<plugin>
<groupId>pl.project13.maven</groupId>
<artifactId>git-commit-id-plugin</artifactId>
<version>2.2.3</version>
<executions>
<execution>
<goals>
<goal>revision</goal>
</goals>
<configuration>
<failOnNoGitDirectory>false</failOnNoGitDirectory>
</configuration>
</execution>
</executions>
</plugin>
2015-08-19 13:57:05 +02:00
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
Update Android branch (#746) * Fixed regression in rebroadcast (#713) Fixed regression caused by 2c1811d: we now don't force sending a channel_update at the same time with channel_announcement. This greatly simplifies the rebroadcast logic, and is what caused the integration test to fail. Added proper test on Peer, testing the actor, not only static methods. * Routing sync fixes (#712) * Router: reset sync state on reconnection When we're reconnected to a peer we will start a new sync process and should reset our sync state with that peer. * Ignore 'origin htlc not found' in CLOSING (#708) If we don't have the origin, it means that we already have forwarded the fulfill so that's not a big deal. This can happen if they send a signature containing the fulfill, then fail the channel before we have time to sign it. * Fix handling of born again channels (#717) * Fix handling of born again channels When we receive a recent update for a channel that we had marked as stale we must send a query to the underlying transport, not the origin of the update (which would send the query back to the router) * Replace `update_fee` in commitments (#709) This is a simple optimisation, we don't have to keep all `update_fee`, just the last one. cf BOLT 2: > An update_fee message is sent by the node which is paying the Bitcoin fee. Like any update, it's first committed to the receiver's commitment transaction and then (once acknowledged) committed to the sender's. Unlike an HTLC, update_fee is never closed but simply replaced. * Tests: use bitcoind 0.16.3 (#715) Bitcoind 0.16.0 is no longer available * Make `publishTransaction` idempotent (#711) Bitcoin core returns an error `missing inputs (code: -25)` if the tx that we want to publish has already been published and its output have been spent. When we receive this error, we try to get the tx, in order to know if it is in the blockchain, or if its inputs were spent by another tx. Note: If the outputs of the tx were still unspent, bitcoin core would return "transaction already in block chain (code: -27)" and this is already handled. * Improved eclair-cli (#718) This fixes #695, and also adds the channel point in the default channel output. ```bash $ ./eclair-cli channel 00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46 { "nodeId": "0232e20e7b68b9b673fb25f48322b151a93186bffe4550045040673797ceca43cf", "shortChannelId": "845230006070001", "channelId": "00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46", "state": "NORMAL", "balanceSat": 9858759, "capacitySat": 10000000, "channelPoint": "470eafa146785a21a3eb55f4d327969b511f08cbb61b566537f94ad9564dfd00:1" } ``` * Handle update relay fee in OFFLINE state (#719) Previously it was only possible to update relay fee in NORMAL state, which is not very convenient because most of the time there are always some channels in OFFLINE state. This works like the NORMAL case, except that the new `channel_update` won't be broadcast immediately. It will be sent out next time the channel goes back to NORMAL, in the same `channel_update` that sets the `enable` flag to true. Also added a default handler that properly rejects the CMD_UPDATE_RELAY_FEE command in all other states. * Fixed regression caused by 7a4f175 (#722) When updating relay fee in state OFFLINE, the new channel_update must have the disabled flag on. This caused tests to be flaky, added necessary checks to always make them fail in case that kind of regression happens again. * Logging: use a rolling file appender (#721) * Logging: use a rolling file appender Use one file per day, keep 90 days of logs with a total maximum size capped at 5 Gb * Router: log routing broadcast in debug level only * set version to 0.2-beta6 * set version back to 0.2-SNAPSHOT * Simplify bitcoind version check (#731) Bitcoind returns version as MMmmrr (major, minor, revision), use an int representation and compare it to our minimum version target. * Update scalatest and remove junit runner (#728) * updated to scalatest 3.0.5 * use scalatest runner instead of junit Output is far more readable, and makes console (incl. travis) reports actually usable. Turned off test logs as error reporting is enough to figure out what happens. The only downside is that we can't use junit's categories to group tests, like we did for docker related tests. We could use nested suites, but that seems to be overkill so I just removed the categories. Users will only have the possibility to either skip/run all tests. * update scala-maven-plugin to 3.4.2 NB: This requires maven 3.5.4, which means that we currently need to manually install maven on travis. Also updated Docker java version to 8u181 (8u171 for compiling). * Add instructions for Bitcoin Core 0.17.0 [ci skip] (#732) * Add instructions for Bitcoin Core 0.17.0 [ci skip] Bitcoin Core 0.17.0 deprecates the `signrawtransaction` RPC call, which will be removed in version 0.18.0, you need to enable this call if you want your eclair node to use a 0.1.70 node. * README: add an example of how to use the new bitcoin.conf sections [ci skip] * Only persist trimmed htlcs (#724) We persist htlc data in order to be able to claim htlc outputs in case a revoked tx is published by our counterparty, so only htlcs above remote's `dust_limit` matter. Removed the TODO because we need data to be indexed by commit number so it is ok to write the same htlc data for every commitment it is included in. * set version to 0.2-beta7 * set version to 0.2-SNAPSHOT * Add `htlcMaximumMsat` field to `ChannelUpdate` message (#738) * Add `htlcMaximumMsat` field to `ChannelUpdate` message * added compatibility test with c-lightning * Fix encoding of FinalIncorrectHtlcAmount error message (#740) * set version to 0.2-beta8 * set version to 0.2-SNAPSHOT * Always add 1 block to the `finalCltvExpiry` (#742) This fixes #651. * ignore IntegrationSpec (no server on android) * back to SNAPSHOT * use proper [gs]etNullableLong method for Sqlite
2018-10-25 17:50:48 +02:00
<version>3.4.2</version>
<configuration>
<args combine.children="append">
<arg>-deprecation</arg>
<arg>-feature</arg>
<arg>-language:postfixOps</arg>
<arg>-language:implicitConversions</arg>
<arg>-Xfatal-warnings</arg>
<arg>-unchecked</arg>
<arg>-Xmax-classfile-name</arg>
<arg>140</arg>
Update android branch (#1162) * Update list of commands in eclair-cli help (#1091) * Add missing API endpoints to eclair-cli help * Documentation update (#1092) * Typed amounts (#1088) * Route computation: fix fee check (#1101) Fee check during route computation is: - fee is below maximum value - OR fee is below amout * maximum percentage The second check was buggy and route computation would failed when fees we above maximum value but below maximum percentage of amount being paid. * Publish transactions during transitions (#1089) Follow up to #1082. The goal is to be able to publish transactions only after we have persisted the state. Otherwise we may run into corner cases like [1] where a refund tx has been published, but we haven't kept track of it and generate a different one (with different fees) the next time. As a side effect, we can now remove the special case that we were doing when publishing the funding tx, and remove the `store` function. NB: the new `calling` transition method isn't restricted to publishing transactions but that is the only use case for now. [1] https://github.com/ACINQ/eclair-mobile/issues/206 * Typed cltv expiry (#1104) Untyped cltv expiry was confusing: delta and absolute expiries really need to be handled differently. Even variable names were sometimes misleading. Now the compiler will help us catch errors early. * Extended queries optional (#899) This is the implementation of https://github.com/lightningnetwork/lightning-rfc/pull/557. * Correctly handle multiple channel_range_replies The scheme we use to keep tracks of channel queries with each peer would forget about missing data when several channel_range_replies are sent back for a single channel_range_queries. * RoutingSync: remove peer entry properly * Remove peer entry on our sync map only when we've received a `reply_short_channel_ids_end` message. * Make routing sync test more explicit * Do not send channel queries if we don't want to sync * Router: clean our sync state when we (re)connect to a peer We must clean up leftovers for the previous session and start the sync process again. * Router: reset sync state on reconnection When we're reconnected to a peer we will start a new sync process and should reset our sync state with that peer. * Extended Queries: use TLV format for optional data Optional query extensions now use TLV instead of a custom format. Flags are encoded as varint instead of bytes as originally proposed. With the current proposal they will all fit on a single byte, but will be much easier to extends this way. * TLV Stream: Implement a generic "get" method for TLV fields If a have a TLV stream of type MyTLV which is a subtype of TLV, and MyTLV1 and MYTLV2 are both subtypes of MyTLV then we can use stream.get[MyTLV1] to get the TLV record of type MYTLV1 (if any) in our TLV stream. * Channel range queries: send back node announcements if requested (#1108) This PR adds support for sending back node announcements when replying to channel range queries: - when explicitly requested (bit is set in the optional query flag) - when query flags are not used and a channel announcement is sent (as per the BOLTs) A new configuration option `request-node-announcements` has been added in the `router` section. If set to true, we will request node announcements when we receive a channel id (through channel range queries) that we don't know of. This is a setting that we will probably turn off on mobile devices. * Rework router data structures (#902) Instead of using two separate maps (for channels and channel_updates), we now use a single map, which groups channel+channel_updates. This is also true for data storage, resulting in the removal of the channel_updates table. * Add more numeric utilities to MilliSatoshi (#1103) Add comparisons and postfix operators. Update most of the codebase to leverage those. * Use unsigned comparison for 'maxHtlcValueInFlightMsat' (#1105) * Add a sync whitelist (#954) We will only sync with whilelisted peer. If the whitelist is empty then we sync with everyone. * Move http APIs to subproject eclair-node (#1102) * Fix regression in `Commitments.availableForSend` (#1107) We must consider `nextRemoteCommit` when applicable. This is a regression caused in #784. The core bug only exists when we have a pending unacked `commit_sig`, but since we only send the `AvailableBalanceChanged` event when sending a signature (not when receiving a revocation), actors relying on this event to know the current available balance (e.g. the `Relayer`) will have a wrong value in-between two outgoing sigs. * Bolt4: remove final_expiry_too_soon error message (#1106) It allowed probing attacks and the spec deprecated it in favor of IncorrectOrUnknownPaymentDetails. Also add better support for unknown failure messages. * Fix maven mirror (#1120) * Use Long to back the UInt64 type (#1109) * Define comparison operators between UInt64 and MilliSatoshi * Implement Bolt 11 invoice feature bits (#1121) lightningnetwork/lightning-rfc#656 introduced invoice feature bits as a pre-requisite for AMP and other advanced payment use-cases. * Update docker build (#1123) * Update docker base image to jdk11, update maven to 3.6.2 [ci skip] * Reject expired invoices before payment flow starts (#1117) * Made sync params configurable (#1124) This allows us to choose smaller parameters for tests and reduce cpu requirement during testing. NB: The default value of 3500 for `reply_channel_range` was wrong. Theoretical max is ~2700. * Activate support for variable-length onion (#1087) This is now enabled by default. We forward variable-length onions if we receive some. We accept variable-length payments. However for maximum compatibility with the network, we send payments using legacy payloads. * Add Semaphore CI (#1125) * Router computes network stats (#1116) * Add comments and fix warnings in graph processing * Add small feature to set the htlcMaximumMsat for routing hints (otherwise the graph processing algorithm used a minimum value which slightly reduced the benefits of those routing hints) * Add the computation of network statistics to the router: this will be useful for multi-part payments to decide what thresholds should be used to split a payment * Add monitoring with Kamon (disabled by default) (#1126) For now: - we only track some tasks (especially in the router, but not even `node_announcement` and `channel_update` - all db calls are monitored - kamon is disabled by default * Check funds in millisatoshi when sending/receiving an HTLC (#1128) Instead of satoshi, which could introduce rounding errors. Also, we check first the balance before the max-inflight amount, because it makes more sense in terms of error management. Co-Authored-By: Bastien Teinturier <31281497+t-bast@users.noreply.github.com> * Don't hardcode the channel version (#1129) Instead of hardcoding the channel version when we instantiate the `Commitments` object, we rather define it when the channel is instantiated. This is saner and prepares future usage. * Removed Globals class (#1127) This is a prerequisite to parallelization of tests. * Make tests run in parallel (#1112) There are two level of parallelization: - between test suites (a suite = a test file) - within a suite (depends on tests suites, some rely on sequential execution of tests, some don't) * Add codecov integration to semaphore CI (#1134) * Remove codecov integration from travis CI * Drop support for Java 8 (#1135) We already have Java 7 (for Android) and Java 11. Supporting Java 8 would require crossbuilding, which we are not doing (two recent PRs broke the build on Java 8). * Sphinx: accept invalid downstream errors (#1137) When a downstream node sends us an onion error with an invalid length, we must forward the failure. The recipient won't be able to extract the error but at least it knows the payment failed. * Update string to match on bitcoind while it's indexing (#1138) * Check for bitcoind's getrawtransaction availablilty during startup * Peer: disable kamon * Payment lifecycle refactoring (#1130) * Unify payment events (no more duplication between payment types and events) * Factorize DB and eventStream interactions: this paves the way for sub-payments that shouldn't be stored in the DB nor emit events. * Add more fields to the payments DB: * bolt 11 invoice for sent payment * external id (for app developers) * parent id (AMP) * target node id * fees * route (if success) * failures (if failed) * Re-work the PaymentsDb interface * Clarify use of seconds / milliseconds in DB interfaces -> milliseconds everywhere * Run SQL migrations inside transactions * Improve error handling when we couldn't find all the channels for a supplied route in /sendtoroute API (#1142) * Improve error handling when we couldn't find all the channels for a supplied route in /sendtoroute * Handle fees increases when channel is OFFLINE (#1080) * Add 'close-on-offline-feerate-mismatch' configuration to avoid closing offline channel when the feerate mismatch if over the threshold. * Derive channel keys from the channel funding pubkey (#1097) We now generate a random funding key for each new channel, and use its public key to deterministically derive all channel keys and secrets. This will let us easily recover funds using DLP even if we've lost everything but our seed: we just need to connect to the node we had a channel with, ask them to publish their commit tx, and once we see it on the blockchain we can extract our funding pubkey, recompute channel keys and spend our output. * Add a "funding pubkey path" option to the channel version field This option is checked when we need to compute channel keys. For old channels it won't be set, and we always set it for new ones. * ChannelVersion: make sure that all bits are set to 0 for legacy channels * ChannelVersion: USE_PUBKEY_KEYPATH is set by default * Check if remote funder can handle an updated commit fee when sending HTLC (#1084) If the sender of an htlc isn't the funder, then both sides will have to afford the payment: - the sender needs to be able to afford the htlc amount - the funder needs to be able to afford the greater commit tx fee incurred by the additional htlc output. Fixes #1081. Co-Authored-By: Pierre-Marie Padiou <pm47@users.noreply.github.com> * Fix and expand channel keypath (#1147) * Fix funding pubkey to channel key path computation Channel key path is generated from 8 bytes computed from our funding pubkey, but we extracted 4 uint32 values instead of 2 (last 2 were always 0). We now use 128 bits to derive channel key paths. * Add a channel key path compatibility test This test will fail if we change the way we compute channel key paths, which would break existing channels. * Use the same chain hash reference in all channel updates To save memory, once we check that a channel_update's chain hash matches what we expect we just replace it with a reference to our own chain hash. * Commitments: take HTLC fee into account (#1152) Our balance computation was slightly incorrect. If you want to know how much you can send (or receive), you need to take into account the fact that you'll add a new HTLC which adds weight to the commit tx (and thus adds fees). * Android: add a spray-based API to eclair-node This is a copy of the spray-based API developped by @araspitzu (akka-http does not work for akka 2.3 which we use on the android branch) * HTTP API: add type hints for payment status (#1150) Cleans up the JSON payment status (easier to interpret for callers). * Use "mock" Kamon library Kamon does not work on Android and does not make much sense, so we replace it with a basic Mock implementation that does nothing. * Electrum: improve coin selection (fixes #1146) (#1149) Our previous coin selection would sometimes fail when there was one wallet utxo and and low feerate, because our first pass used a fee estimate that was too high and could sometimes not be met. * Extend funding key path to 256 bits (#1154) Our random funding key path is now 8 * 32 bits plus a 1' (funder) or 0' (fundee). Channel key paths are computed from the sha256 of the funding public key (we take all 256 bits). * Use bitcoin 0.18.1 in the test (#1148) * Upgrade new unit tests to bitcoin 0.18.1 API (#1157) We had 2 open PRs, one that added new tests using the 0.API, one that switched to 0.18.1, when they were merged the new tests failed since they had not been upgraded.... * Update netty dependency to 4.1.32 (#1160) Also: * explicitely set endpoint identification algorithm in strict mode * force TLS protocols 1.2/1.3 in strict mode Co-Authored-By: Bastien Teinturier <31281497+t-bast@users.noreply.github.com> * Add execution time limit (#1161) * Android: wipe channels table during db migration We already wipe the updates table, and this make upgrading much simpler since we had different structures on android vs mater. * Activate extended channel range queries (#1165) By default we now set the `gossip_queries_ex` feature bit. We also change how we compare feature bits, and will use channel queries (or extended queries) only if the corresponding feature bit is set in both local and remote init messages. * Use guava to compute CRC32C checksums (#1166) CRC32C is not available in JDK 7 which we target on Android.
2019-10-08 13:21:17 +02:00
<!-- needed to compile Scala code on JDK9+ -->
<arg>-nobootcp</arg>
</args>
<jvmArgs>
<jvmArg>-Xmx1024m</jvmArg>
<jvmArg>-Xms1024m</jvmArg>
<jvmArg>-Xss32m</jvmArg>
</jvmArgs>
<scalaCompatVersion>${scala.version.short}</scalaCompatVersion>
</configuration>
2015-08-19 13:57:05 +02:00
<executions>
<execution>
<id>scalac</id>
2015-08-19 13:57:05 +02:00
<goals>
<goal>compile</goal>
<goal>testCompile</goal>
</goals>
</execution>
<execution>
<id>scaladoc</id>
<goals>
<goal>doc-jar</goal>
</goals>
<configuration>
<skip>${maven.test.skip}</skip>
<args>
<arg>-no-link-warnings</arg>
</args>
</configuration>
</execution>
2015-08-19 13:57:05 +02:00
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.2.0</version>
2015-08-19 13:57:05 +02:00
<executions>
<execution>
<id>attach-sources</id>
<goals>
<goal>jar</goal>
</goals>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<version>3.0.0</version>
2015-08-19 13:57:05 +02:00
<executions>
<execution>
<id>add-source</id>
<phase>generate-sources</phase>
<goals>
<goal>add-source</goal>
</goals>
<configuration>
<sources>
<source>src/main/scala</source>
</sources>
</configuration>
</execution>
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
<goals>
<goal>add-test-source</goal>
</goals>
<configuration>
<sources>
<source>src/test/scala</source>
</sources>
</configuration>
</execution>
</executions>
</plugin>
Update Android branch (#746) * Fixed regression in rebroadcast (#713) Fixed regression caused by 2c1811d: we now don't force sending a channel_update at the same time with channel_announcement. This greatly simplifies the rebroadcast logic, and is what caused the integration test to fail. Added proper test on Peer, testing the actor, not only static methods. * Routing sync fixes (#712) * Router: reset sync state on reconnection When we're reconnected to a peer we will start a new sync process and should reset our sync state with that peer. * Ignore 'origin htlc not found' in CLOSING (#708) If we don't have the origin, it means that we already have forwarded the fulfill so that's not a big deal. This can happen if they send a signature containing the fulfill, then fail the channel before we have time to sign it. * Fix handling of born again channels (#717) * Fix handling of born again channels When we receive a recent update for a channel that we had marked as stale we must send a query to the underlying transport, not the origin of the update (which would send the query back to the router) * Replace `update_fee` in commitments (#709) This is a simple optimisation, we don't have to keep all `update_fee`, just the last one. cf BOLT 2: > An update_fee message is sent by the node which is paying the Bitcoin fee. Like any update, it's first committed to the receiver's commitment transaction and then (once acknowledged) committed to the sender's. Unlike an HTLC, update_fee is never closed but simply replaced. * Tests: use bitcoind 0.16.3 (#715) Bitcoind 0.16.0 is no longer available * Make `publishTransaction` idempotent (#711) Bitcoin core returns an error `missing inputs (code: -25)` if the tx that we want to publish has already been published and its output have been spent. When we receive this error, we try to get the tx, in order to know if it is in the blockchain, or if its inputs were spent by another tx. Note: If the outputs of the tx were still unspent, bitcoin core would return "transaction already in block chain (code: -27)" and this is already handled. * Improved eclair-cli (#718) This fixes #695, and also adds the channel point in the default channel output. ```bash $ ./eclair-cli channel 00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46 { "nodeId": "0232e20e7b68b9b673fb25f48322b151a93186bffe4550045040673797ceca43cf", "shortChannelId": "845230006070001", "channelId": "00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46", "state": "NORMAL", "balanceSat": 9858759, "capacitySat": 10000000, "channelPoint": "470eafa146785a21a3eb55f4d327969b511f08cbb61b566537f94ad9564dfd00:1" } ``` * Handle update relay fee in OFFLINE state (#719) Previously it was only possible to update relay fee in NORMAL state, which is not very convenient because most of the time there are always some channels in OFFLINE state. This works like the NORMAL case, except that the new `channel_update` won't be broadcast immediately. It will be sent out next time the channel goes back to NORMAL, in the same `channel_update` that sets the `enable` flag to true. Also added a default handler that properly rejects the CMD_UPDATE_RELAY_FEE command in all other states. * Fixed regression caused by 7a4f175 (#722) When updating relay fee in state OFFLINE, the new channel_update must have the disabled flag on. This caused tests to be flaky, added necessary checks to always make them fail in case that kind of regression happens again. * Logging: use a rolling file appender (#721) * Logging: use a rolling file appender Use one file per day, keep 90 days of logs with a total maximum size capped at 5 Gb * Router: log routing broadcast in debug level only * set version to 0.2-beta6 * set version back to 0.2-SNAPSHOT * Simplify bitcoind version check (#731) Bitcoind returns version as MMmmrr (major, minor, revision), use an int representation and compare it to our minimum version target. * Update scalatest and remove junit runner (#728) * updated to scalatest 3.0.5 * use scalatest runner instead of junit Output is far more readable, and makes console (incl. travis) reports actually usable. Turned off test logs as error reporting is enough to figure out what happens. The only downside is that we can't use junit's categories to group tests, like we did for docker related tests. We could use nested suites, but that seems to be overkill so I just removed the categories. Users will only have the possibility to either skip/run all tests. * update scala-maven-plugin to 3.4.2 NB: This requires maven 3.5.4, which means that we currently need to manually install maven on travis. Also updated Docker java version to 8u181 (8u171 for compiling). * Add instructions for Bitcoin Core 0.17.0 [ci skip] (#732) * Add instructions for Bitcoin Core 0.17.0 [ci skip] Bitcoin Core 0.17.0 deprecates the `signrawtransaction` RPC call, which will be removed in version 0.18.0, you need to enable this call if you want your eclair node to use a 0.1.70 node. * README: add an example of how to use the new bitcoin.conf sections [ci skip] * Only persist trimmed htlcs (#724) We persist htlc data in order to be able to claim htlc outputs in case a revoked tx is published by our counterparty, so only htlcs above remote's `dust_limit` matter. Removed the TODO because we need data to be indexed by commit number so it is ok to write the same htlc data for every commitment it is included in. * set version to 0.2-beta7 * set version to 0.2-SNAPSHOT * Add `htlcMaximumMsat` field to `ChannelUpdate` message (#738) * Add `htlcMaximumMsat` field to `ChannelUpdate` message * added compatibility test with c-lightning * Fix encoding of FinalIncorrectHtlcAmount error message (#740) * set version to 0.2-beta8 * set version to 0.2-SNAPSHOT * Always add 1 block to the `finalCltvExpiry` (#742) This fixes #651. * ignore IntegrationSpec (no server on android) * back to SNAPSHOT * use proper [gs]etNullableLong method for Sqlite
2018-10-25 17:50:48 +02:00
<!-- disable surefire -->
2015-09-08 19:36:57 +02:00
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>2.20</version>
2015-09-08 19:36:57 +02:00
<configuration>
Update Android branch (#746) * Fixed regression in rebroadcast (#713) Fixed regression caused by 2c1811d: we now don't force sending a channel_update at the same time with channel_announcement. This greatly simplifies the rebroadcast logic, and is what caused the integration test to fail. Added proper test on Peer, testing the actor, not only static methods. * Routing sync fixes (#712) * Router: reset sync state on reconnection When we're reconnected to a peer we will start a new sync process and should reset our sync state with that peer. * Ignore 'origin htlc not found' in CLOSING (#708) If we don't have the origin, it means that we already have forwarded the fulfill so that's not a big deal. This can happen if they send a signature containing the fulfill, then fail the channel before we have time to sign it. * Fix handling of born again channels (#717) * Fix handling of born again channels When we receive a recent update for a channel that we had marked as stale we must send a query to the underlying transport, not the origin of the update (which would send the query back to the router) * Replace `update_fee` in commitments (#709) This is a simple optimisation, we don't have to keep all `update_fee`, just the last one. cf BOLT 2: > An update_fee message is sent by the node which is paying the Bitcoin fee. Like any update, it's first committed to the receiver's commitment transaction and then (once acknowledged) committed to the sender's. Unlike an HTLC, update_fee is never closed but simply replaced. * Tests: use bitcoind 0.16.3 (#715) Bitcoind 0.16.0 is no longer available * Make `publishTransaction` idempotent (#711) Bitcoin core returns an error `missing inputs (code: -25)` if the tx that we want to publish has already been published and its output have been spent. When we receive this error, we try to get the tx, in order to know if it is in the blockchain, or if its inputs were spent by another tx. Note: If the outputs of the tx were still unspent, bitcoin core would return "transaction already in block chain (code: -27)" and this is already handled. * Improved eclair-cli (#718) This fixes #695, and also adds the channel point in the default channel output. ```bash $ ./eclair-cli channel 00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46 { "nodeId": "0232e20e7b68b9b673fb25f48322b151a93186bffe4550045040673797ceca43cf", "shortChannelId": "845230006070001", "channelId": "00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46", "state": "NORMAL", "balanceSat": 9858759, "capacitySat": 10000000, "channelPoint": "470eafa146785a21a3eb55f4d327969b511f08cbb61b566537f94ad9564dfd00:1" } ``` * Handle update relay fee in OFFLINE state (#719) Previously it was only possible to update relay fee in NORMAL state, which is not very convenient because most of the time there are always some channels in OFFLINE state. This works like the NORMAL case, except that the new `channel_update` won't be broadcast immediately. It will be sent out next time the channel goes back to NORMAL, in the same `channel_update` that sets the `enable` flag to true. Also added a default handler that properly rejects the CMD_UPDATE_RELAY_FEE command in all other states. * Fixed regression caused by 7a4f175 (#722) When updating relay fee in state OFFLINE, the new channel_update must have the disabled flag on. This caused tests to be flaky, added necessary checks to always make them fail in case that kind of regression happens again. * Logging: use a rolling file appender (#721) * Logging: use a rolling file appender Use one file per day, keep 90 days of logs with a total maximum size capped at 5 Gb * Router: log routing broadcast in debug level only * set version to 0.2-beta6 * set version back to 0.2-SNAPSHOT * Simplify bitcoind version check (#731) Bitcoind returns version as MMmmrr (major, minor, revision), use an int representation and compare it to our minimum version target. * Update scalatest and remove junit runner (#728) * updated to scalatest 3.0.5 * use scalatest runner instead of junit Output is far more readable, and makes console (incl. travis) reports actually usable. Turned off test logs as error reporting is enough to figure out what happens. The only downside is that we can't use junit's categories to group tests, like we did for docker related tests. We could use nested suites, but that seems to be overkill so I just removed the categories. Users will only have the possibility to either skip/run all tests. * update scala-maven-plugin to 3.4.2 NB: This requires maven 3.5.4, which means that we currently need to manually install maven on travis. Also updated Docker java version to 8u181 (8u171 for compiling). * Add instructions for Bitcoin Core 0.17.0 [ci skip] (#732) * Add instructions for Bitcoin Core 0.17.0 [ci skip] Bitcoin Core 0.17.0 deprecates the `signrawtransaction` RPC call, which will be removed in version 0.18.0, you need to enable this call if you want your eclair node to use a 0.1.70 node. * README: add an example of how to use the new bitcoin.conf sections [ci skip] * Only persist trimmed htlcs (#724) We persist htlc data in order to be able to claim htlc outputs in case a revoked tx is published by our counterparty, so only htlcs above remote's `dust_limit` matter. Removed the TODO because we need data to be indexed by commit number so it is ok to write the same htlc data for every commitment it is included in. * set version to 0.2-beta7 * set version to 0.2-SNAPSHOT * Add `htlcMaximumMsat` field to `ChannelUpdate` message (#738) * Add `htlcMaximumMsat` field to `ChannelUpdate` message * added compatibility test with c-lightning * Fix encoding of FinalIncorrectHtlcAmount error message (#740) * set version to 0.2-beta8 * set version to 0.2-SNAPSHOT * Always add 1 block to the `finalCltvExpiry` (#742) This fixes #651. * ignore IntegrationSpec (no server on android) * back to SNAPSHOT * use proper [gs]etNullableLong method for Sqlite
2018-10-25 17:50:48 +02:00
<skipTests>true</skipTests>
</configuration>
</plugin>
<!-- enable scalatest -->
<plugin>
<groupId>org.scalatest</groupId>
<artifactId>scalatest-maven-plugin</artifactId>
<version>2.0.0</version>
<configuration>
Update android branch (#1162) * Update list of commands in eclair-cli help (#1091) * Add missing API endpoints to eclair-cli help * Documentation update (#1092) * Typed amounts (#1088) * Route computation: fix fee check (#1101) Fee check during route computation is: - fee is below maximum value - OR fee is below amout * maximum percentage The second check was buggy and route computation would failed when fees we above maximum value but below maximum percentage of amount being paid. * Publish transactions during transitions (#1089) Follow up to #1082. The goal is to be able to publish transactions only after we have persisted the state. Otherwise we may run into corner cases like [1] where a refund tx has been published, but we haven't kept track of it and generate a different one (with different fees) the next time. As a side effect, we can now remove the special case that we were doing when publishing the funding tx, and remove the `store` function. NB: the new `calling` transition method isn't restricted to publishing transactions but that is the only use case for now. [1] https://github.com/ACINQ/eclair-mobile/issues/206 * Typed cltv expiry (#1104) Untyped cltv expiry was confusing: delta and absolute expiries really need to be handled differently. Even variable names were sometimes misleading. Now the compiler will help us catch errors early. * Extended queries optional (#899) This is the implementation of https://github.com/lightningnetwork/lightning-rfc/pull/557. * Correctly handle multiple channel_range_replies The scheme we use to keep tracks of channel queries with each peer would forget about missing data when several channel_range_replies are sent back for a single channel_range_queries. * RoutingSync: remove peer entry properly * Remove peer entry on our sync map only when we've received a `reply_short_channel_ids_end` message. * Make routing sync test more explicit * Do not send channel queries if we don't want to sync * Router: clean our sync state when we (re)connect to a peer We must clean up leftovers for the previous session and start the sync process again. * Router: reset sync state on reconnection When we're reconnected to a peer we will start a new sync process and should reset our sync state with that peer. * Extended Queries: use TLV format for optional data Optional query extensions now use TLV instead of a custom format. Flags are encoded as varint instead of bytes as originally proposed. With the current proposal they will all fit on a single byte, but will be much easier to extends this way. * TLV Stream: Implement a generic "get" method for TLV fields If a have a TLV stream of type MyTLV which is a subtype of TLV, and MyTLV1 and MYTLV2 are both subtypes of MyTLV then we can use stream.get[MyTLV1] to get the TLV record of type MYTLV1 (if any) in our TLV stream. * Channel range queries: send back node announcements if requested (#1108) This PR adds support for sending back node announcements when replying to channel range queries: - when explicitly requested (bit is set in the optional query flag) - when query flags are not used and a channel announcement is sent (as per the BOLTs) A new configuration option `request-node-announcements` has been added in the `router` section. If set to true, we will request node announcements when we receive a channel id (through channel range queries) that we don't know of. This is a setting that we will probably turn off on mobile devices. * Rework router data structures (#902) Instead of using two separate maps (for channels and channel_updates), we now use a single map, which groups channel+channel_updates. This is also true for data storage, resulting in the removal of the channel_updates table. * Add more numeric utilities to MilliSatoshi (#1103) Add comparisons and postfix operators. Update most of the codebase to leverage those. * Use unsigned comparison for 'maxHtlcValueInFlightMsat' (#1105) * Add a sync whitelist (#954) We will only sync with whilelisted peer. If the whitelist is empty then we sync with everyone. * Move http APIs to subproject eclair-node (#1102) * Fix regression in `Commitments.availableForSend` (#1107) We must consider `nextRemoteCommit` when applicable. This is a regression caused in #784. The core bug only exists when we have a pending unacked `commit_sig`, but since we only send the `AvailableBalanceChanged` event when sending a signature (not when receiving a revocation), actors relying on this event to know the current available balance (e.g. the `Relayer`) will have a wrong value in-between two outgoing sigs. * Bolt4: remove final_expiry_too_soon error message (#1106) It allowed probing attacks and the spec deprecated it in favor of IncorrectOrUnknownPaymentDetails. Also add better support for unknown failure messages. * Fix maven mirror (#1120) * Use Long to back the UInt64 type (#1109) * Define comparison operators between UInt64 and MilliSatoshi * Implement Bolt 11 invoice feature bits (#1121) lightningnetwork/lightning-rfc#656 introduced invoice feature bits as a pre-requisite for AMP and other advanced payment use-cases. * Update docker build (#1123) * Update docker base image to jdk11, update maven to 3.6.2 [ci skip] * Reject expired invoices before payment flow starts (#1117) * Made sync params configurable (#1124) This allows us to choose smaller parameters for tests and reduce cpu requirement during testing. NB: The default value of 3500 for `reply_channel_range` was wrong. Theoretical max is ~2700. * Activate support for variable-length onion (#1087) This is now enabled by default. We forward variable-length onions if we receive some. We accept variable-length payments. However for maximum compatibility with the network, we send payments using legacy payloads. * Add Semaphore CI (#1125) * Router computes network stats (#1116) * Add comments and fix warnings in graph processing * Add small feature to set the htlcMaximumMsat for routing hints (otherwise the graph processing algorithm used a minimum value which slightly reduced the benefits of those routing hints) * Add the computation of network statistics to the router: this will be useful for multi-part payments to decide what thresholds should be used to split a payment * Add monitoring with Kamon (disabled by default) (#1126) For now: - we only track some tasks (especially in the router, but not even `node_announcement` and `channel_update` - all db calls are monitored - kamon is disabled by default * Check funds in millisatoshi when sending/receiving an HTLC (#1128) Instead of satoshi, which could introduce rounding errors. Also, we check first the balance before the max-inflight amount, because it makes more sense in terms of error management. Co-Authored-By: Bastien Teinturier <31281497+t-bast@users.noreply.github.com> * Don't hardcode the channel version (#1129) Instead of hardcoding the channel version when we instantiate the `Commitments` object, we rather define it when the channel is instantiated. This is saner and prepares future usage. * Removed Globals class (#1127) This is a prerequisite to parallelization of tests. * Make tests run in parallel (#1112) There are two level of parallelization: - between test suites (a suite = a test file) - within a suite (depends on tests suites, some rely on sequential execution of tests, some don't) * Add codecov integration to semaphore CI (#1134) * Remove codecov integration from travis CI * Drop support for Java 8 (#1135) We already have Java 7 (for Android) and Java 11. Supporting Java 8 would require crossbuilding, which we are not doing (two recent PRs broke the build on Java 8). * Sphinx: accept invalid downstream errors (#1137) When a downstream node sends us an onion error with an invalid length, we must forward the failure. The recipient won't be able to extract the error but at least it knows the payment failed. * Update string to match on bitcoind while it's indexing (#1138) * Check for bitcoind's getrawtransaction availablilty during startup * Peer: disable kamon * Payment lifecycle refactoring (#1130) * Unify payment events (no more duplication between payment types and events) * Factorize DB and eventStream interactions: this paves the way for sub-payments that shouldn't be stored in the DB nor emit events. * Add more fields to the payments DB: * bolt 11 invoice for sent payment * external id (for app developers) * parent id (AMP) * target node id * fees * route (if success) * failures (if failed) * Re-work the PaymentsDb interface * Clarify use of seconds / milliseconds in DB interfaces -> milliseconds everywhere * Run SQL migrations inside transactions * Improve error handling when we couldn't find all the channels for a supplied route in /sendtoroute API (#1142) * Improve error handling when we couldn't find all the channels for a supplied route in /sendtoroute * Handle fees increases when channel is OFFLINE (#1080) * Add 'close-on-offline-feerate-mismatch' configuration to avoid closing offline channel when the feerate mismatch if over the threshold. * Derive channel keys from the channel funding pubkey (#1097) We now generate a random funding key for each new channel, and use its public key to deterministically derive all channel keys and secrets. This will let us easily recover funds using DLP even if we've lost everything but our seed: we just need to connect to the node we had a channel with, ask them to publish their commit tx, and once we see it on the blockchain we can extract our funding pubkey, recompute channel keys and spend our output. * Add a "funding pubkey path" option to the channel version field This option is checked when we need to compute channel keys. For old channels it won't be set, and we always set it for new ones. * ChannelVersion: make sure that all bits are set to 0 for legacy channels * ChannelVersion: USE_PUBKEY_KEYPATH is set by default * Check if remote funder can handle an updated commit fee when sending HTLC (#1084) If the sender of an htlc isn't the funder, then both sides will have to afford the payment: - the sender needs to be able to afford the htlc amount - the funder needs to be able to afford the greater commit tx fee incurred by the additional htlc output. Fixes #1081. Co-Authored-By: Pierre-Marie Padiou <pm47@users.noreply.github.com> * Fix and expand channel keypath (#1147) * Fix funding pubkey to channel key path computation Channel key path is generated from 8 bytes computed from our funding pubkey, but we extracted 4 uint32 values instead of 2 (last 2 were always 0). We now use 128 bits to derive channel key paths. * Add a channel key path compatibility test This test will fail if we change the way we compute channel key paths, which would break existing channels. * Use the same chain hash reference in all channel updates To save memory, once we check that a channel_update's chain hash matches what we expect we just replace it with a reference to our own chain hash. * Commitments: take HTLC fee into account (#1152) Our balance computation was slightly incorrect. If you want to know how much you can send (or receive), you need to take into account the fact that you'll add a new HTLC which adds weight to the commit tx (and thus adds fees). * Android: add a spray-based API to eclair-node This is a copy of the spray-based API developped by @araspitzu (akka-http does not work for akka 2.3 which we use on the android branch) * HTTP API: add type hints for payment status (#1150) Cleans up the JSON payment status (easier to interpret for callers). * Use "mock" Kamon library Kamon does not work on Android and does not make much sense, so we replace it with a basic Mock implementation that does nothing. * Electrum: improve coin selection (fixes #1146) (#1149) Our previous coin selection would sometimes fail when there was one wallet utxo and and low feerate, because our first pass used a fee estimate that was too high and could sometimes not be met. * Extend funding key path to 256 bits (#1154) Our random funding key path is now 8 * 32 bits plus a 1' (funder) or 0' (fundee). Channel key paths are computed from the sha256 of the funding public key (we take all 256 bits). * Use bitcoin 0.18.1 in the test (#1148) * Upgrade new unit tests to bitcoin 0.18.1 API (#1157) We had 2 open PRs, one that added new tests using the 0.API, one that switched to 0.18.1, when they were merged the new tests failed since they had not been upgraded.... * Update netty dependency to 4.1.32 (#1160) Also: * explicitely set endpoint identification algorithm in strict mode * force TLS protocols 1.2/1.3 in strict mode Co-Authored-By: Bastien Teinturier <31281497+t-bast@users.noreply.github.com> * Add execution time limit (#1161) * Android: wipe channels table during db migration We already wipe the updates table, and this make upgrading much simpler since we had different structures on android vs mater. * Activate extended channel range queries (#1165) By default we now set the `gossip_queries_ex` feature bit. We also change how we compare feature bits, and will use channel queries (or extended queries) only if the corresponding feature bit is set in both local and remote init messages. * Use guava to compute CRC32C checksums (#1166) CRC32C is not available in JDK 7 which we target on Android.
2019-10-08 13:21:17 +02:00
<parallel>true</parallel>
Update Android branch (#746) * Fixed regression in rebroadcast (#713) Fixed regression caused by 2c1811d: we now don't force sending a channel_update at the same time with channel_announcement. This greatly simplifies the rebroadcast logic, and is what caused the integration test to fail. Added proper test on Peer, testing the actor, not only static methods. * Routing sync fixes (#712) * Router: reset sync state on reconnection When we're reconnected to a peer we will start a new sync process and should reset our sync state with that peer. * Ignore 'origin htlc not found' in CLOSING (#708) If we don't have the origin, it means that we already have forwarded the fulfill so that's not a big deal. This can happen if they send a signature containing the fulfill, then fail the channel before we have time to sign it. * Fix handling of born again channels (#717) * Fix handling of born again channels When we receive a recent update for a channel that we had marked as stale we must send a query to the underlying transport, not the origin of the update (which would send the query back to the router) * Replace `update_fee` in commitments (#709) This is a simple optimisation, we don't have to keep all `update_fee`, just the last one. cf BOLT 2: > An update_fee message is sent by the node which is paying the Bitcoin fee. Like any update, it's first committed to the receiver's commitment transaction and then (once acknowledged) committed to the sender's. Unlike an HTLC, update_fee is never closed but simply replaced. * Tests: use bitcoind 0.16.3 (#715) Bitcoind 0.16.0 is no longer available * Make `publishTransaction` idempotent (#711) Bitcoin core returns an error `missing inputs (code: -25)` if the tx that we want to publish has already been published and its output have been spent. When we receive this error, we try to get the tx, in order to know if it is in the blockchain, or if its inputs were spent by another tx. Note: If the outputs of the tx were still unspent, bitcoin core would return "transaction already in block chain (code: -27)" and this is already handled. * Improved eclair-cli (#718) This fixes #695, and also adds the channel point in the default channel output. ```bash $ ./eclair-cli channel 00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46 { "nodeId": "0232e20e7b68b9b673fb25f48322b151a93186bffe4550045040673797ceca43cf", "shortChannelId": "845230006070001", "channelId": "00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46", "state": "NORMAL", "balanceSat": 9858759, "capacitySat": 10000000, "channelPoint": "470eafa146785a21a3eb55f4d327969b511f08cbb61b566537f94ad9564dfd00:1" } ``` * Handle update relay fee in OFFLINE state (#719) Previously it was only possible to update relay fee in NORMAL state, which is not very convenient because most of the time there are always some channels in OFFLINE state. This works like the NORMAL case, except that the new `channel_update` won't be broadcast immediately. It will be sent out next time the channel goes back to NORMAL, in the same `channel_update` that sets the `enable` flag to true. Also added a default handler that properly rejects the CMD_UPDATE_RELAY_FEE command in all other states. * Fixed regression caused by 7a4f175 (#722) When updating relay fee in state OFFLINE, the new channel_update must have the disabled flag on. This caused tests to be flaky, added necessary checks to always make them fail in case that kind of regression happens again. * Logging: use a rolling file appender (#721) * Logging: use a rolling file appender Use one file per day, keep 90 days of logs with a total maximum size capped at 5 Gb * Router: log routing broadcast in debug level only * set version to 0.2-beta6 * set version back to 0.2-SNAPSHOT * Simplify bitcoind version check (#731) Bitcoind returns version as MMmmrr (major, minor, revision), use an int representation and compare it to our minimum version target. * Update scalatest and remove junit runner (#728) * updated to scalatest 3.0.5 * use scalatest runner instead of junit Output is far more readable, and makes console (incl. travis) reports actually usable. Turned off test logs as error reporting is enough to figure out what happens. The only downside is that we can't use junit's categories to group tests, like we did for docker related tests. We could use nested suites, but that seems to be overkill so I just removed the categories. Users will only have the possibility to either skip/run all tests. * update scala-maven-plugin to 3.4.2 NB: This requires maven 3.5.4, which means that we currently need to manually install maven on travis. Also updated Docker java version to 8u181 (8u171 for compiling). * Add instructions for Bitcoin Core 0.17.0 [ci skip] (#732) * Add instructions for Bitcoin Core 0.17.0 [ci skip] Bitcoin Core 0.17.0 deprecates the `signrawtransaction` RPC call, which will be removed in version 0.18.0, you need to enable this call if you want your eclair node to use a 0.1.70 node. * README: add an example of how to use the new bitcoin.conf sections [ci skip] * Only persist trimmed htlcs (#724) We persist htlc data in order to be able to claim htlc outputs in case a revoked tx is published by our counterparty, so only htlcs above remote's `dust_limit` matter. Removed the TODO because we need data to be indexed by commit number so it is ok to write the same htlc data for every commitment it is included in. * set version to 0.2-beta7 * set version to 0.2-SNAPSHOT * Add `htlcMaximumMsat` field to `ChannelUpdate` message (#738) * Add `htlcMaximumMsat` field to `ChannelUpdate` message * added compatibility test with c-lightning * Fix encoding of FinalIncorrectHtlcAmount error message (#740) * set version to 0.2-beta8 * set version to 0.2-SNAPSHOT * Always add 1 block to the `finalCltvExpiry` (#742) This fixes #651. * ignore IntegrationSpec (no server on android) * back to SNAPSHOT * use proper [gs]etNullableLong method for Sqlite
2018-10-25 17:50:48 +02:00
<systemProperties>
<buildDirectory>${project.build.directory}</buildDirectory>
Update Android branch (#746) * Fixed regression in rebroadcast (#713) Fixed regression caused by 2c1811d: we now don't force sending a channel_update at the same time with channel_announcement. This greatly simplifies the rebroadcast logic, and is what caused the integration test to fail. Added proper test on Peer, testing the actor, not only static methods. * Routing sync fixes (#712) * Router: reset sync state on reconnection When we're reconnected to a peer we will start a new sync process and should reset our sync state with that peer. * Ignore 'origin htlc not found' in CLOSING (#708) If we don't have the origin, it means that we already have forwarded the fulfill so that's not a big deal. This can happen if they send a signature containing the fulfill, then fail the channel before we have time to sign it. * Fix handling of born again channels (#717) * Fix handling of born again channels When we receive a recent update for a channel that we had marked as stale we must send a query to the underlying transport, not the origin of the update (which would send the query back to the router) * Replace `update_fee` in commitments (#709) This is a simple optimisation, we don't have to keep all `update_fee`, just the last one. cf BOLT 2: > An update_fee message is sent by the node which is paying the Bitcoin fee. Like any update, it's first committed to the receiver's commitment transaction and then (once acknowledged) committed to the sender's. Unlike an HTLC, update_fee is never closed but simply replaced. * Tests: use bitcoind 0.16.3 (#715) Bitcoind 0.16.0 is no longer available * Make `publishTransaction` idempotent (#711) Bitcoin core returns an error `missing inputs (code: -25)` if the tx that we want to publish has already been published and its output have been spent. When we receive this error, we try to get the tx, in order to know if it is in the blockchain, or if its inputs were spent by another tx. Note: If the outputs of the tx were still unspent, bitcoin core would return "transaction already in block chain (code: -27)" and this is already handled. * Improved eclair-cli (#718) This fixes #695, and also adds the channel point in the default channel output. ```bash $ ./eclair-cli channel 00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46 { "nodeId": "0232e20e7b68b9b673fb25f48322b151a93186bffe4550045040673797ceca43cf", "shortChannelId": "845230006070001", "channelId": "00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46", "state": "NORMAL", "balanceSat": 9858759, "capacitySat": 10000000, "channelPoint": "470eafa146785a21a3eb55f4d327969b511f08cbb61b566537f94ad9564dfd00:1" } ``` * Handle update relay fee in OFFLINE state (#719) Previously it was only possible to update relay fee in NORMAL state, which is not very convenient because most of the time there are always some channels in OFFLINE state. This works like the NORMAL case, except that the new `channel_update` won't be broadcast immediately. It will be sent out next time the channel goes back to NORMAL, in the same `channel_update` that sets the `enable` flag to true. Also added a default handler that properly rejects the CMD_UPDATE_RELAY_FEE command in all other states. * Fixed regression caused by 7a4f175 (#722) When updating relay fee in state OFFLINE, the new channel_update must have the disabled flag on. This caused tests to be flaky, added necessary checks to always make them fail in case that kind of regression happens again. * Logging: use a rolling file appender (#721) * Logging: use a rolling file appender Use one file per day, keep 90 days of logs with a total maximum size capped at 5 Gb * Router: log routing broadcast in debug level only * set version to 0.2-beta6 * set version back to 0.2-SNAPSHOT * Simplify bitcoind version check (#731) Bitcoind returns version as MMmmrr (major, minor, revision), use an int representation and compare it to our minimum version target. * Update scalatest and remove junit runner (#728) * updated to scalatest 3.0.5 * use scalatest runner instead of junit Output is far more readable, and makes console (incl. travis) reports actually usable. Turned off test logs as error reporting is enough to figure out what happens. The only downside is that we can't use junit's categories to group tests, like we did for docker related tests. We could use nested suites, but that seems to be overkill so I just removed the categories. Users will only have the possibility to either skip/run all tests. * update scala-maven-plugin to 3.4.2 NB: This requires maven 3.5.4, which means that we currently need to manually install maven on travis. Also updated Docker java version to 8u181 (8u171 for compiling). * Add instructions for Bitcoin Core 0.17.0 [ci skip] (#732) * Add instructions for Bitcoin Core 0.17.0 [ci skip] Bitcoin Core 0.17.0 deprecates the `signrawtransaction` RPC call, which will be removed in version 0.18.0, you need to enable this call if you want your eclair node to use a 0.1.70 node. * README: add an example of how to use the new bitcoin.conf sections [ci skip] * Only persist trimmed htlcs (#724) We persist htlc data in order to be able to claim htlc outputs in case a revoked tx is published by our counterparty, so only htlcs above remote's `dust_limit` matter. Removed the TODO because we need data to be indexed by commit number so it is ok to write the same htlc data for every commitment it is included in. * set version to 0.2-beta7 * set version to 0.2-SNAPSHOT * Add `htlcMaximumMsat` field to `ChannelUpdate` message (#738) * Add `htlcMaximumMsat` field to `ChannelUpdate` message * added compatibility test with c-lightning * Fix encoding of FinalIncorrectHtlcAmount error message (#740) * set version to 0.2-beta8 * set version to 0.2-SNAPSHOT * Always add 1 block to the `finalCltvExpiry` (#742) This fixes #651. * ignore IntegrationSpec (no server on android) * back to SNAPSHOT * use proper [gs]etNullableLong method for Sqlite
2018-10-25 17:50:48 +02:00
</systemProperties>
<argLine>-Xmx1024m -Dfile.encoding=UTF-8</argLine>
2015-09-08 19:36:57 +02:00
</configuration>
Update Android branch (#746) * Fixed regression in rebroadcast (#713) Fixed regression caused by 2c1811d: we now don't force sending a channel_update at the same time with channel_announcement. This greatly simplifies the rebroadcast logic, and is what caused the integration test to fail. Added proper test on Peer, testing the actor, not only static methods. * Routing sync fixes (#712) * Router: reset sync state on reconnection When we're reconnected to a peer we will start a new sync process and should reset our sync state with that peer. * Ignore 'origin htlc not found' in CLOSING (#708) If we don't have the origin, it means that we already have forwarded the fulfill so that's not a big deal. This can happen if they send a signature containing the fulfill, then fail the channel before we have time to sign it. * Fix handling of born again channels (#717) * Fix handling of born again channels When we receive a recent update for a channel that we had marked as stale we must send a query to the underlying transport, not the origin of the update (which would send the query back to the router) * Replace `update_fee` in commitments (#709) This is a simple optimisation, we don't have to keep all `update_fee`, just the last one. cf BOLT 2: > An update_fee message is sent by the node which is paying the Bitcoin fee. Like any update, it's first committed to the receiver's commitment transaction and then (once acknowledged) committed to the sender's. Unlike an HTLC, update_fee is never closed but simply replaced. * Tests: use bitcoind 0.16.3 (#715) Bitcoind 0.16.0 is no longer available * Make `publishTransaction` idempotent (#711) Bitcoin core returns an error `missing inputs (code: -25)` if the tx that we want to publish has already been published and its output have been spent. When we receive this error, we try to get the tx, in order to know if it is in the blockchain, or if its inputs were spent by another tx. Note: If the outputs of the tx were still unspent, bitcoin core would return "transaction already in block chain (code: -27)" and this is already handled. * Improved eclair-cli (#718) This fixes #695, and also adds the channel point in the default channel output. ```bash $ ./eclair-cli channel 00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46 { "nodeId": "0232e20e7b68b9b673fb25f48322b151a93186bffe4550045040673797ceca43cf", "shortChannelId": "845230006070001", "channelId": "00fd4d56d94af93765561bb6cb081f519b9627d3f455eba3215a7846a1af0e46", "state": "NORMAL", "balanceSat": 9858759, "capacitySat": 10000000, "channelPoint": "470eafa146785a21a3eb55f4d327969b511f08cbb61b566537f94ad9564dfd00:1" } ``` * Handle update relay fee in OFFLINE state (#719) Previously it was only possible to update relay fee in NORMAL state, which is not very convenient because most of the time there are always some channels in OFFLINE state. This works like the NORMAL case, except that the new `channel_update` won't be broadcast immediately. It will be sent out next time the channel goes back to NORMAL, in the same `channel_update` that sets the `enable` flag to true. Also added a default handler that properly rejects the CMD_UPDATE_RELAY_FEE command in all other states. * Fixed regression caused by 7a4f175 (#722) When updating relay fee in state OFFLINE, the new channel_update must have the disabled flag on. This caused tests to be flaky, added necessary checks to always make them fail in case that kind of regression happens again. * Logging: use a rolling file appender (#721) * Logging: use a rolling file appender Use one file per day, keep 90 days of logs with a total maximum size capped at 5 Gb * Router: log routing broadcast in debug level only * set version to 0.2-beta6 * set version back to 0.2-SNAPSHOT * Simplify bitcoind version check (#731) Bitcoind returns version as MMmmrr (major, minor, revision), use an int representation and compare it to our minimum version target. * Update scalatest and remove junit runner (#728) * updated to scalatest 3.0.5 * use scalatest runner instead of junit Output is far more readable, and makes console (incl. travis) reports actually usable. Turned off test logs as error reporting is enough to figure out what happens. The only downside is that we can't use junit's categories to group tests, like we did for docker related tests. We could use nested suites, but that seems to be overkill so I just removed the categories. Users will only have the possibility to either skip/run all tests. * update scala-maven-plugin to 3.4.2 NB: This requires maven 3.5.4, which means that we currently need to manually install maven on travis. Also updated Docker java version to 8u181 (8u171 for compiling). * Add instructions for Bitcoin Core 0.17.0 [ci skip] (#732) * Add instructions for Bitcoin Core 0.17.0 [ci skip] Bitcoin Core 0.17.0 deprecates the `signrawtransaction` RPC call, which will be removed in version 0.18.0, you need to enable this call if you want your eclair node to use a 0.1.70 node. * README: add an example of how to use the new bitcoin.conf sections [ci skip] * Only persist trimmed htlcs (#724) We persist htlc data in order to be able to claim htlc outputs in case a revoked tx is published by our counterparty, so only htlcs above remote's `dust_limit` matter. Removed the TODO because we need data to be indexed by commit number so it is ok to write the same htlc data for every commitment it is included in. * set version to 0.2-beta7 * set version to 0.2-SNAPSHOT * Add `htlcMaximumMsat` field to `ChannelUpdate` message (#738) * Add `htlcMaximumMsat` field to `ChannelUpdate` message * added compatibility test with c-lightning * Fix encoding of FinalIncorrectHtlcAmount error message (#740) * set version to 0.2-beta8 * set version to 0.2-SNAPSHOT * Always add 1 block to the `finalCltvExpiry` (#742) This fixes #651. * ignore IntegrationSpec (no server on android) * back to SNAPSHOT * use proper [gs]etNullableLong method for Sqlite
2018-10-25 17:50:48 +02:00
<executions>
<execution>
<id>test</id>
<goals>
<goal>test</goal>
</goals>
</execution>
</executions>
2015-09-08 19:36:57 +02:00
</plugin>
Merge master into Android (#1002) * Fix eclair-cli to work with equal sign in arguments (#926) * Fix eclair cli argument passing * Modify eclair-cli to work with equals in arguments * Eclair-cli: show usage when wrong params are received * Remove deprecated call from eclair-cli help message [ci skip] * Make Electrum tests pass on windows (#932) There was an obscure Docker error when trying to start an Electrum server in tests. [1] It appears that there is a conflict between Docker and Hyper-V on some range of ports. A workaround is to just change the port we were using. [1] https://github.com/docker/for-win/issues/3171 * API: fix fee rate conversion (#936) Our `open` API calls expects an optional fee rate in satoshi/byte, which is the most widely used unit, but failed to convert to satoshi/kiloweight which is the standard in LN. We also check that the converted fee rate cannot go below 253 satoshi/kiloweight. * Expose the websocket over HTTP GET to work properly with basic auth (#934) * Expose the websocket over HTTP GET * Add test for basic auth over websocket endpoint * Set max payment attempts from configuration (#931) With a default to `5`. * Add a proper payments database (#885) There is no unique identifier for payments in LN protocol. Critically, we can't use `payment_hash` as a unique id because there is no way to ensure unicity at the protocol level. Also, the general case for a "payment" is to be associated to multiple `update_add_htlc`s, because of automated retries. We also routinely retry payments, which means that the same `payment_hash` will be conceptually linked to a list of lists of `update_add_htlc`s. In order to address this, we introduce a payment id, which uniquely identifies a payment, as in a set of sequential `update_add_htlc` managed by a single `PaymentLifecycle` that ends with a `PaymentSent` or `PaymentFailed` outcome. We can then query the api using either `payment_id` or `payment_hash`. The former will return a single payment status, the latter will return a set of payment statuses, each identified by their `payment_id`. * Add a payment identifier * Remove InvalidPaymentHash channel exception * Remove unused 'close' from paymentsDb * Introduce sent_payments in PaymentDB, bump db version * Return the UUID of the ongoing payment in /send API * Add api to query payments by ID * Add 'fallbackAddress' in /receive API * Expose /paymentinfo by paymentHash * Add id column to audit.sent table, add test for db migration * Add invoices to payment DB * Add license header to ExtraDirective.scala * Respond with HTTP 404 if the corresponding invoice/paymentHash was not found. * Left-pad numeric bolt11 tagged fields to have a number of bits multiple of five (bech32 encoding). * Add invoices API * Remove CheckPayment message * GUI: consume UUID reply from payment initiator * API: reply with JSON encoded response if the queried element wasn't found * Return a payment request object in /receive * Remove limit of pending payment requests! * Avoid printing "null" fields when serializing an invoice to json * Add index on paymentDb.sent_payments.payment_hash * Order results in descending order in listPaymentRequest * Electrum: do not persist transaction locks (#953) Locks held on utxos that are used in unpublished funding transactions should not be persisted. If the app is stopped before the funding transaction has been published the channel is forgotten and so should be locks on its funding tx utxos. * Added a timeout for channel open request (#928) Until now, if the peer is unresponsive (typically doesn't respond to `open_channel` or `funding_created`), we waited indefinitely, or until the connection closed. It translated to an API timeout for users, and uncertainty about the state of the channel. This PR: - adds an optional `--openTimeoutSeconds` timeout to the `open` endpoint, that will actively cancel the channel opening if it takes too long before reaching state `WAIT_FOR_FUNDING_CONFIRMED`. - makes the `ask` timeout configurable per request with a new `--timeoutSeconds` - makes the akka http timeout slightly greater than the `ask` timeout Ask timeout is set to 30s by default. * Set `MAX_BUFFERED` to 1,000,000 (#948) Note that this doesn't mean that we will buffer 1M objects in memory: those are just pointers to (mostly) network announcements that already exist in our routing table. Routing table has recently gone over 100K elements (nodes, announcements, updates) and this causes the connection to be closed when peer requests a full initial sync. * Fix Dockerfile maven binary checksum (#956) The Maven 3.6.0 SHA256 checksum was invalid and caused the docker build to fail. * Add channel errors in audit db (#955) We now keep track of all local/remote channel errors in the audit db. * Added simple plugin support (#927) Using org.clapper:classutil library and a very simple `Plugin` interface. * Live channel database backup (#951) * Backup running channel database when needed Every time our channel database needs to be persisted, we create a backup which is always safe to copy even when the system is busy. * Upgrade sqlite-jdbc to 3.27.2.1 * BackupHandler: use a specific bounded mailbox BackupHandler is now private, users have to call BackupHandler.props() which always specifies our custom bounded maibox. * BackupHandler: use a specific threadpool with a single thread * Add backup notification script Once a new backup has been created, call an optional user defined script. * Update readme with bitcoin 0.17 instructions (#958) This has somehow been missed by PR #826. * Backup: explicitely specify move options (#960) * Backup: explicitely specify move options We now specify that we want to atomically overwrite the existing backup file with the new one (fixes a potential issue on Windows). We also publish a specific notification when the backup process has been completed. * Print stack trace when crashing during boot sequence (#949) * Print stack trace when crashing during boot sequence * Use friendly message when db compatibility check fails * ElectrumWallet should not send ready if syncing (#963) This commit is already embedded in version `0.2-android-beta22`. * Channel: Log additional data (#943) * Channel: Log additional data Log local channel parameters, and our peer's open or accept message. This should be enough to recompute keys needed to recover funds in case of unilateral close. * Electrum: make debug logs shorter (#964) * Better handling of closed channels (#944) * Remove closed channels when application starts If the app is stopped just after a channel has transition from CLOSING to CLOSED, when the application starts again if will be restored as CLOSING. This commit checks channel data and remove closed channels instead of restoring them. * Channels Database: tag closed channels but don't delete them Instead we add a new `closed` column that we check when we restore channels. * Document how we check and remove closed channels on startup * Do not print the stacktrace on stderr when there is an error at boot (#966) * Do not print the stacktrace on stdout when there is an error at boot * Fix flaky test in PaymentLifecycleSpec (#967) * Use local random pamentHash for each test in paymentlifecyclespec, intercept the route request before the router. * Rename `eclair.bak` to `eclair.sqlite.bak` (#968) This removes any ambiguity about what the content of the file is about. * Fixed concurrency issue in `IndexedObservableList` (#961) Update map with new indexes after element is removed Fixes #915 * Various fix and improvements in time/timestamp handling (#971) This PR standardizes the way we compute the current time as unix timestamp - Scala's Platform is used and the conversion is done via scala's concurrent.duration facilities - Java's Instant has been replaced due to broken compatibility with android - AuditDB events use milliseconds (fixes #970) - PaymentDB events use milliseconds - Query filters for AuditDB and PaymentDB use seconds * API: Support query by `channelId` or `shortChannelId` everywhere (#969) Add support for querying a channel information by its `shortChannelId`. * Smarter strategy for sending `channel_update`s (#950) The goal is to prevent sending a lot of updates for flappy channels. Instead of sending a disabled `channel_update` after each disconnection, we now wait for a payment to try to route through the channel and only then reply with a disabled `channel_update` and broadcast it on the network. The reason is that in case of a disconnection, if noone cares about that channel then there is no reason to tell everyone about its current (disconnected) state. In addition to that, when switching from `SYNCING`->`NORMAL`, instead of emitting a new `channel_update` with flag=enabled right away, we wait a little bit and send it later. We also don't send a new `channel_update` if it is identical to the previous one (except if the previous one is outdated). This way, if a connection to a peer is unstable and we keep getting disconnected/reconnected, we won't spam the network. The extra delay allows us to remove the change made in #888, which was a workaround in case we generated `channel_update` too quickly. Also, increased refresh interval from 7 days to 10 days. There was no need to be so conservative. Note that on startup we still need to re-send `channel_update` for all channels in order to properly initialize the `Router` and the `Relayer`. Otherwise they won't know about those channels, and e.g. the `Relayer` will return `UnknownNextPeer` errors. But we don't need to create new `channel_update`s in most cases, so this should have little or no impact to gossip because our peers will already know the updates and will filter them out. On the other hand, if some global parameters (like relaying fees) are changed, it will cause the creation a new `channel_update` for all channels. * Fixed overflow issue with max duration (#975) This is a regression caused by #971, because `Duration` has a max value of `Long.MaxValue` *nanoseconds*, not *seconds*. * Use proper closing type in `ChannelClosed` event (#977) There was actually a change introduced by #944 where we used `ClosingType.toString` instead of manually defining types, causing a regression in the audit database. * Update bash autocompletion for eclair-cli (#983) * Update bash autocompletition file to suggest all the endpoints * Update list of commands in eclair-cli help message * Replace `UnknownPaymentHash` and `IncorrectPaymentAmount` with `IncorrectOrUnknownPaymentDetails` (#984) See https://github.com/lightningnetwork/lightning-rfc/pull/516 and https://github.com/lightningnetwork/lightning-rfc/pull/544 * Wireshark dissector support (#981) * Transport: add support for encryption key logging. This is the format the wireshark lightning-dissector uses to be able to decrypt lightning messages. * Enrich test for internal eclair API implementation (fr.acinq.eclair.Eclair.scala) (#938) * Add test to EclairImpl for `/send`, `/allupdates` and `/forceclose/` * Set default chain to "mainnet" (#989) Eclair is now configured to run on mainnet by default. * Set tcp client timeout to 20s (#990) So that it fails before the ask/api time out. * Add bot support for code coverage (codecov) (#982) * Add scoverage-maven-plugin dependency * Update travis build to generate a scoverage report * Add custom codecov configuration to have nice PR comments * Add badge for test coverage in readme * Accept `commit_sig` without changes (#988) LND sometimes sends a new signature without any changes, which is a (harmless) spec violation. Note that the test was previously not failing because it wasn't specific enough. The test now fails and has been ignored. * Ignore subprojects eclair-node/eclair-node-gui in the codecov report (#991) * Use bitcoind fee estimator first (#987) * use bitcoind fee provider first * set default `smooth-feerate-window`=6 * Configuration: increase fee rate mismatch threshold We wil accept fee rates that up to 8x bigger or smaller than our local fee rate * Updated license header (#992) * Release v0.3 (#994) * gui: include javafx native libraries for windows, mac, linux * Release v0.3 * Set version to 0.3.1-SNAPSHOT * Improved test coverage of `io` package (#996) * improved test coverage of `NodeURI` * improved test coverage of `Peer` * Fix TextUI * BackupHandler: use renameTo() on Android Most Path methods are not available at our current API level
2019-05-21 17:56:47 +02:00
<plugin>
<groupId>org.scoverage</groupId>
<artifactId>scoverage-maven-plugin</artifactId>
<version>1.4.0-RC1</version>
<configuration>
<skip>${maven.test.skip}</skip>
Merge master into Android (#1002) * Fix eclair-cli to work with equal sign in arguments (#926) * Fix eclair cli argument passing * Modify eclair-cli to work with equals in arguments * Eclair-cli: show usage when wrong params are received * Remove deprecated call from eclair-cli help message [ci skip] * Make Electrum tests pass on windows (#932) There was an obscure Docker error when trying to start an Electrum server in tests. [1] It appears that there is a conflict between Docker and Hyper-V on some range of ports. A workaround is to just change the port we were using. [1] https://github.com/docker/for-win/issues/3171 * API: fix fee rate conversion (#936) Our `open` API calls expects an optional fee rate in satoshi/byte, which is the most widely used unit, but failed to convert to satoshi/kiloweight which is the standard in LN. We also check that the converted fee rate cannot go below 253 satoshi/kiloweight. * Expose the websocket over HTTP GET to work properly with basic auth (#934) * Expose the websocket over HTTP GET * Add test for basic auth over websocket endpoint * Set max payment attempts from configuration (#931) With a default to `5`. * Add a proper payments database (#885) There is no unique identifier for payments in LN protocol. Critically, we can't use `payment_hash` as a unique id because there is no way to ensure unicity at the protocol level. Also, the general case for a "payment" is to be associated to multiple `update_add_htlc`s, because of automated retries. We also routinely retry payments, which means that the same `payment_hash` will be conceptually linked to a list of lists of `update_add_htlc`s. In order to address this, we introduce a payment id, which uniquely identifies a payment, as in a set of sequential `update_add_htlc` managed by a single `PaymentLifecycle` that ends with a `PaymentSent` or `PaymentFailed` outcome. We can then query the api using either `payment_id` or `payment_hash`. The former will return a single payment status, the latter will return a set of payment statuses, each identified by their `payment_id`. * Add a payment identifier * Remove InvalidPaymentHash channel exception * Remove unused 'close' from paymentsDb * Introduce sent_payments in PaymentDB, bump db version * Return the UUID of the ongoing payment in /send API * Add api to query payments by ID * Add 'fallbackAddress' in /receive API * Expose /paymentinfo by paymentHash * Add id column to audit.sent table, add test for db migration * Add invoices to payment DB * Add license header to ExtraDirective.scala * Respond with HTTP 404 if the corresponding invoice/paymentHash was not found. * Left-pad numeric bolt11 tagged fields to have a number of bits multiple of five (bech32 encoding). * Add invoices API * Remove CheckPayment message * GUI: consume UUID reply from payment initiator * API: reply with JSON encoded response if the queried element wasn't found * Return a payment request object in /receive * Remove limit of pending payment requests! * Avoid printing "null" fields when serializing an invoice to json * Add index on paymentDb.sent_payments.payment_hash * Order results in descending order in listPaymentRequest * Electrum: do not persist transaction locks (#953) Locks held on utxos that are used in unpublished funding transactions should not be persisted. If the app is stopped before the funding transaction has been published the channel is forgotten and so should be locks on its funding tx utxos. * Added a timeout for channel open request (#928) Until now, if the peer is unresponsive (typically doesn't respond to `open_channel` or `funding_created`), we waited indefinitely, or until the connection closed. It translated to an API timeout for users, and uncertainty about the state of the channel. This PR: - adds an optional `--openTimeoutSeconds` timeout to the `open` endpoint, that will actively cancel the channel opening if it takes too long before reaching state `WAIT_FOR_FUNDING_CONFIRMED`. - makes the `ask` timeout configurable per request with a new `--timeoutSeconds` - makes the akka http timeout slightly greater than the `ask` timeout Ask timeout is set to 30s by default. * Set `MAX_BUFFERED` to 1,000,000 (#948) Note that this doesn't mean that we will buffer 1M objects in memory: those are just pointers to (mostly) network announcements that already exist in our routing table. Routing table has recently gone over 100K elements (nodes, announcements, updates) and this causes the connection to be closed when peer requests a full initial sync. * Fix Dockerfile maven binary checksum (#956) The Maven 3.6.0 SHA256 checksum was invalid and caused the docker build to fail. * Add channel errors in audit db (#955) We now keep track of all local/remote channel errors in the audit db. * Added simple plugin support (#927) Using org.clapper:classutil library and a very simple `Plugin` interface. * Live channel database backup (#951) * Backup running channel database when needed Every time our channel database needs to be persisted, we create a backup which is always safe to copy even when the system is busy. * Upgrade sqlite-jdbc to 3.27.2.1 * BackupHandler: use a specific bounded mailbox BackupHandler is now private, users have to call BackupHandler.props() which always specifies our custom bounded maibox. * BackupHandler: use a specific threadpool with a single thread * Add backup notification script Once a new backup has been created, call an optional user defined script. * Update readme with bitcoin 0.17 instructions (#958) This has somehow been missed by PR #826. * Backup: explicitely specify move options (#960) * Backup: explicitely specify move options We now specify that we want to atomically overwrite the existing backup file with the new one (fixes a potential issue on Windows). We also publish a specific notification when the backup process has been completed. * Print stack trace when crashing during boot sequence (#949) * Print stack trace when crashing during boot sequence * Use friendly message when db compatibility check fails * ElectrumWallet should not send ready if syncing (#963) This commit is already embedded in version `0.2-android-beta22`. * Channel: Log additional data (#943) * Channel: Log additional data Log local channel parameters, and our peer's open or accept message. This should be enough to recompute keys needed to recover funds in case of unilateral close. * Electrum: make debug logs shorter (#964) * Better handling of closed channels (#944) * Remove closed channels when application starts If the app is stopped just after a channel has transition from CLOSING to CLOSED, when the application starts again if will be restored as CLOSING. This commit checks channel data and remove closed channels instead of restoring them. * Channels Database: tag closed channels but don't delete them Instead we add a new `closed` column that we check when we restore channels. * Document how we check and remove closed channels on startup * Do not print the stacktrace on stderr when there is an error at boot (#966) * Do not print the stacktrace on stdout when there is an error at boot * Fix flaky test in PaymentLifecycleSpec (#967) * Use local random pamentHash for each test in paymentlifecyclespec, intercept the route request before the router. * Rename `eclair.bak` to `eclair.sqlite.bak` (#968) This removes any ambiguity about what the content of the file is about. * Fixed concurrency issue in `IndexedObservableList` (#961) Update map with new indexes after element is removed Fixes #915 * Various fix and improvements in time/timestamp handling (#971) This PR standardizes the way we compute the current time as unix timestamp - Scala's Platform is used and the conversion is done via scala's concurrent.duration facilities - Java's Instant has been replaced due to broken compatibility with android - AuditDB events use milliseconds (fixes #970) - PaymentDB events use milliseconds - Query filters for AuditDB and PaymentDB use seconds * API: Support query by `channelId` or `shortChannelId` everywhere (#969) Add support for querying a channel information by its `shortChannelId`. * Smarter strategy for sending `channel_update`s (#950) The goal is to prevent sending a lot of updates for flappy channels. Instead of sending a disabled `channel_update` after each disconnection, we now wait for a payment to try to route through the channel and only then reply with a disabled `channel_update` and broadcast it on the network. The reason is that in case of a disconnection, if noone cares about that channel then there is no reason to tell everyone about its current (disconnected) state. In addition to that, when switching from `SYNCING`->`NORMAL`, instead of emitting a new `channel_update` with flag=enabled right away, we wait a little bit and send it later. We also don't send a new `channel_update` if it is identical to the previous one (except if the previous one is outdated). This way, if a connection to a peer is unstable and we keep getting disconnected/reconnected, we won't spam the network. The extra delay allows us to remove the change made in #888, which was a workaround in case we generated `channel_update` too quickly. Also, increased refresh interval from 7 days to 10 days. There was no need to be so conservative. Note that on startup we still need to re-send `channel_update` for all channels in order to properly initialize the `Router` and the `Relayer`. Otherwise they won't know about those channels, and e.g. the `Relayer` will return `UnknownNextPeer` errors. But we don't need to create new `channel_update`s in most cases, so this should have little or no impact to gossip because our peers will already know the updates and will filter them out. On the other hand, if some global parameters (like relaying fees) are changed, it will cause the creation a new `channel_update` for all channels. * Fixed overflow issue with max duration (#975) This is a regression caused by #971, because `Duration` has a max value of `Long.MaxValue` *nanoseconds*, not *seconds*. * Use proper closing type in `ChannelClosed` event (#977) There was actually a change introduced by #944 where we used `ClosingType.toString` instead of manually defining types, causing a regression in the audit database. * Update bash autocompletion for eclair-cli (#983) * Update bash autocompletition file to suggest all the endpoints * Update list of commands in eclair-cli help message * Replace `UnknownPaymentHash` and `IncorrectPaymentAmount` with `IncorrectOrUnknownPaymentDetails` (#984) See https://github.com/lightningnetwork/lightning-rfc/pull/516 and https://github.com/lightningnetwork/lightning-rfc/pull/544 * Wireshark dissector support (#981) * Transport: add support for encryption key logging. This is the format the wireshark lightning-dissector uses to be able to decrypt lightning messages. * Enrich test for internal eclair API implementation (fr.acinq.eclair.Eclair.scala) (#938) * Add test to EclairImpl for `/send`, `/allupdates` and `/forceclose/` * Set default chain to "mainnet" (#989) Eclair is now configured to run on mainnet by default. * Set tcp client timeout to 20s (#990) So that it fails before the ask/api time out. * Add bot support for code coverage (codecov) (#982) * Add scoverage-maven-plugin dependency * Update travis build to generate a scoverage report * Add custom codecov configuration to have nice PR comments * Add badge for test coverage in readme * Accept `commit_sig` without changes (#988) LND sometimes sends a new signature without any changes, which is a (harmless) spec violation. Note that the test was previously not failing because it wasn't specific enough. The test now fails and has been ignored. * Ignore subprojects eclair-node/eclair-node-gui in the codecov report (#991) * Use bitcoind fee estimator first (#987) * use bitcoind fee provider first * set default `smooth-feerate-window`=6 * Configuration: increase fee rate mismatch threshold We wil accept fee rates that up to 8x bigger or smaller than our local fee rate * Updated license header (#992) * Release v0.3 (#994) * gui: include javafx native libraries for windows, mac, linux * Release v0.3 * Set version to 0.3.1-SNAPSHOT * Improved test coverage of `io` package (#996) * improved test coverage of `NodeURI` * improved test coverage of `Peer` * Fix TextUI * BackupHandler: use renameTo() on Android Most Path methods are not available at our current API level
2019-05-21 17:56:47 +02:00
<scalaVersion>${scala.version}</scalaVersion>
</configuration>
</plugin>
2015-08-19 13:57:05 +02:00
</plugins>
</build>
<repositories>
<repository>
<id>sonatype snapshots</id>
<url>https://oss.sonatype.org/content/repositories/snapshots/</url>
</repository>
</repositories>
<dependencies>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
<version>${scala.version}</version>
</dependency>
<dependency>
<groupId>org.scalatest</groupId>
<artifactId>scalatest_${scala.version.short}</artifactId>
<version>3.1.1</version>
2015-08-19 13:57:05 +02:00
<scope>test</scope>
</dependency>
</dependencies>
</project>