mirror of
https://github.com/ElementsProject/lightning.git
synced 2025-02-22 22:45:27 +01:00
55173a56b7
Before this patch we used `int` for error codes. The problem with `int` is that we try to pass it to/from wire and the size of `int` is not defined by the standard. So a sender with 4-byte `int` would write 4 bytes to the wire and a receiver with 2-byte `int` (for example) would read just 2 bytes from the wire. To resolve this: * Introduce an error code type with a known size: `typedef s32 errcode_t`. * Change all error code macros to constants of type `errcode_t`. Constants also play better with gdb - it would visualize the name of the constant instead of the numeric value. * Change all functions that take error codes to take the new type `errcode_t` instead of `int`. * Introduce towire / fromwire functions to send / receive the newly added type `errcode_t` and use it instead of `towire_int()`. In addition: * Remove the now unneeded `towire_int()`. * Replace a hardcoded error code `-2` with a new constant `INVOICE_EXPIRED_DURING_WAIT` (903). Changelog-Changed: The waitinvoice command would now return error code 903 to designate that the invoice expired during wait, instead of the previous -2 |
||
|---|---|---|
| .. | ||
| Makefile | ||
| onion-test-v0.json | ||
| run-amount.c | ||
| run-bigsize.c | ||
| run-bolt11.c | ||
| run-cryptomsg.c | ||
| run-derive_basepoints.c | ||
| run-features.c | ||
| run-funding_tx.c | ||
| run-gossip_rcvd_filter.c | ||
| run-ip_port_parsing.c | ||
| run-json.c | ||
| run-json_remove.c | ||
| run-key_derive.c | ||
| run-lock.c | ||
| run-param.c | ||
| run-softref.c | ||
| run-sphinx.c | ||