Vasil Dimov 55173a56b7 Use dedicated type for error codes ... Before this patch we used `int` for error codes. The problem with `int` is that we try to pass it to/from wire and the size of `int` is not defined by the standard. So a sender with 4-byte `int` would write 4 bytes to the wire and a receiver with 2-byte `int` (for example) would read just 2 bytes from the wire. To resolve this: * Introduce an error code type with a known size: `typedef s32 errcode_t`. * Change all error code macros to constants of type `errcode_t`. Constants also play better with gdb - it would visualize the name of the constant instead of the numeric value. * Change all functions that take error codes to take the new type `errcode_t` instead of `int`. * Introduce towire / fromwire functions to send / receive the newly added type `errcode_t` and use it instead of `towire_int()`. In addition: * Remove the now unneeded `towire_int()`. * Replace a hardcoded error code `-2` with a new constant `INVOICE_EXPIRED_DURING_WAIT` (903). Changelog-Changed: The waitinvoice command would now return error code 903 to designate that the invoice expired during wait, instead of the previous -2		2020-01-31 06:02:47 +00:00
..
.gitignore	wallet: move tests into test/ dir like other unit tests.	2017-12-13 22:46:10 +01:00
Makefile	common: use struct onionreply.	2020-01-23 16:17:42 +10:30
run-db.c	db: Track the data_version in the database	2020-01-02 14:12:59 -06:00
run-wallet.c	Use dedicated type for error codes	2020-01-31 06:02:47 +00:00
test_utils.c	Add enable-autotor-v2 config variable	2019-09-28 00:31:02 +02:00
test_utils.h	fix: a pr2444 introduced valgrind complaint	2019-03-14 16:51:18 +01:00