core-lightning/openingd
Rusty Russell d38cfcf33b lightningd: don't assume zero-length tlv fields will be NULL.
1. We assumed an empty upfront_shutdown_script TLV would become NULL:

	RPC call failed: method: fundchannel, payload: {'id': '022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59', 'amount': 1000000, 'announce': True}, error: {'code': -1, 'message': 'They sent error channel e7c2d5d14462fe269631418fbfc3db327843382e6a2a5a9c2991d2d6ba31d9f5: Unacceptable upfront_shutdown_script ', 'data': {'id': '022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59', 'method': 'fundchannel_start'}}"

2. We were assuming an empty enctlv would become NULL, too.

We should not have done this (there's a semantic difference between
"empty" and not-present for TLVs), so prepare for the change.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2021-07-21 13:27:27 -04:00
..
common.c doc: remove suffix for included-in-master BOLTs. 2021-04-07 14:34:39 +09:30
common.h df: use dev-env flagged upfront shutdown script 2021-01-10 13:44:04 +01:00
dualopend_wire.csv channel leases: pass expected lease rates around in compat form 2021-07-20 13:28:38 -04:00
dualopend_wiregen.c channel leases: pass expected lease rates around in compat form 2021-07-20 13:28:38 -04:00
dualopend_wiregen.h channel leases: pass expected lease rates around in compat form 2021-07-20 13:28:38 -04:00
dualopend.c reestablish_tlvs: don't lose them btw tmpctx cleanup 2021-07-20 13:28:38 -04:00
Makefile liquidity-ads: persist channel blockheight states to disk 2021-07-20 13:28:38 -04:00
openingd_wire.csv openingd: tell lightningd if we get a reestablish. 2021-06-25 13:23:28 +09:30
openingd_wiregen.c liquidity-ads: persist channel blockheight states to disk 2021-07-20 13:28:38 -04:00
openingd_wiregen.h liquidity-ads: persist channel blockheight states to disk 2021-07-20 13:28:38 -04:00
openingd.c lightningd: don't assume zero-length tlv fields will be NULL. 2021-07-21 13:27:27 -04:00