mirror of
https://github.com/ElementsProject/lightning.git
synced 2025-02-22 06:41:44 +01:00
The schema in the docs for the `ConnectNotification` was faulty. I've already fix this in https://github.com/ElementsProject/lightning/pull/7085 The new schema is ``` { "connect" : { "address" : { "address" : "127.0.0.1", "port" : 38012, "type" : "ipv4" }, "direction" : "in", "id" : "022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59" } } ``` The `address` in the `connect` field will be encoded in protobuf as `ConnectAddress`. However, this collides with the `ConnectAddress` that is defined in the `connect` rpc-method. This commit - Updates the schema in `doc/schemas/notification/connect.json` - Changes `msggen` to include an override to `PeerConnect` for any notification typename that starts with `Connect` Both have an `address` field which is a composite type. This results in naming collisions schema's: Updated schema for connect-notification schema for connect notification + overrides Override ConnectAddress to `PeerConnectAddress` in protobuf for notifications |
||
---|---|---|
.. | ||
block_added.request.json | ||
block_added.schema.json | ||
channel_open_failed.request.json | ||
channel_open_failed.schema.json | ||
channel_opened.request.json | ||
channel_opened.schema.json | ||
channel_state_changed.request.json | ||
channel_state_changed.schema.json | ||
connect.request.json | ||
connect.schema.json | ||
custommsg.request.json | ||
custommsg.schema.json |