mirror of
https://github.com/ElementsProject/lightning.git
synced 2025-02-22 14:42:40 +01:00
libwally asserts() when trying to calculate the txid: we report it as invalid elsewhere, but then crash: ``` May 19 20:37:03 c-lightning lightningd[26236]: 2022-05-19T20:37:03.689Z DEBUG lightningd: close_command: timeout = 1 May 19 20:37:04 c-lightning lightningd[26236]: 2022-05-19T20:37:04.689Z UNUSUAL 037f32400c108f8385db94371bfcef08948bc0042069c1ef6f39086cdf23420ee5-chan#91: Peer permanent failure in CHANNELD_SHUTTING_DOWN: Forcibly closed by `close` command timeout May 19 20:37:04 c-lightning lightningd[26236]: 2022-05-19T20:37:04.689Z **BROKEN** 037f32400c108f8385db94371bfcef08948bc0042069c1ef6f39086cdf23420ee5-chan#91: Cannot broadcast our commitment tx: it's invalid! (ancient channel?) May 19 20:37:04 c-lightning lightningd[26236]: lightningd: bitcoin/tx.c:485: wally_txid: Assertion `len == written' failed. May 19 20:37:04 c-lightning lightningd[26236]: lightningd: FATAL SIGNAL 6 (version v0.11.1) May 19 20:37:04 c-lightning lightningd[26236]: 0x45bd01 send_backtrace May 19 20:37:04 c-lightning lightningd[26236]: common/daemon.c:33 May 19 20:37:04 c-lightning lightningd[26236]: 0x45bd8b crashdump May 19 20:37:04 c-lightning lightningd[26236]: common/daemon.c:46 May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f877604bf ??? May 19 20:37:04 c-lightning lightningd[26236]: ???:0 May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f87760438 ??? May 19 20:37:04 c-lightning lightningd[26236]: ???:0 May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f87762039 ??? May 19 20:37:04 c-lightning lightningd[26236]: ???:0 May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f87758be6 ??? May 19 20:37:04 c-lightning lightningd[26236]: ???:0 May 19 20:37:04 c-lightning lightningd[26236]: 0x7f9f87758c91 ??? May 19 20:37:04 c-lightning lightningd[26236]: ???:0 May 19 20:37:04 c-lightning lightningd[26236]: 0x4751b7 wally_txid May 19 20:37:04 c-lightning lightningd[26236]: bitcoin/tx.c:485 May 19 20:37:04 c-lightning lightningd[26236]: 0x4751f4 bitcoin_txid May 19 20:37:04 c-lightning lightningd[26236]: bitcoin/tx.c:496 May 19 20:37:04 c-lightning lightningd[26236]: 0x40bad0 resolve_one_close_command May 19 20:37:04 c-lightning lightningd[26236]: lightningd/closing_control.c:60 May 19 20:37:04 c-lightning lightningd[26236]: 0x40cef3 resolve_close_command May 19 20:37:04 c-lightning lightningd[26236]: lightningd/closing_control.c:82 May 19 20:37:04 c-lightning lightningd[26236]: 0x430355 drop_to_chain May 19 20:37:04 c-lightning lightningd[26236]: lightningd/peer_control.c:286 ``` Fixes: #5277 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
127 lines
3.7 KiB
C
127 lines
3.7 KiB
C
#ifndef LIGHTNING_LIGHTNINGD_PEER_CONTROL_H
|
|
#define LIGHTNING_LIGHTNINGD_PEER_CONTROL_H
|
|
#include "config.h"
|
|
#include <ccan/compiler/compiler.h>
|
|
#include <ccan/crypto/shachain/shachain.h>
|
|
#include <ccan/list/list.h>
|
|
#include <common/channel_config.h>
|
|
#include <common/htlc.h>
|
|
#include <common/json.h>
|
|
#include <common/node_id.h>
|
|
#include <common/wireaddr.h>
|
|
#include <wallet/wallet.h>
|
|
|
|
struct peer_fd;
|
|
struct wally_psbt;
|
|
|
|
struct peer {
|
|
/* Inside ld->peers. */
|
|
struct list_node list;
|
|
|
|
/* Master context */
|
|
struct lightningd *ld;
|
|
|
|
/* Database ID of the peer */
|
|
u64 dbid;
|
|
|
|
/* ID of peer */
|
|
struct node_id id;
|
|
|
|
/* Our channels */
|
|
struct list_head channels;
|
|
|
|
/* Are we connected? */
|
|
bool is_connected;
|
|
|
|
/* Our (only) uncommitted channel, still opening. */
|
|
struct uncommitted_channel *uncommitted_channel;
|
|
|
|
/* Where we connected to, or it connected from. */
|
|
struct wireaddr_internal addr;
|
|
bool connected_incoming;
|
|
|
|
/* They send what they see as our address as remote_addr */
|
|
struct wireaddr *remote_addr;
|
|
|
|
/* We keep a copy of their feature bits */
|
|
const u8 *their_features;
|
|
|
|
/* If we open a channel our direction will be this */
|
|
u8 direction;
|
|
|
|
#if DEVELOPER
|
|
/* Swallow incoming HTLCs (for testing) */
|
|
bool ignore_htlcs;
|
|
#endif
|
|
};
|
|
|
|
struct peer *find_peer_by_dbid(struct lightningd *ld, u64 dbid);
|
|
|
|
struct peer *new_peer(struct lightningd *ld, u64 dbid,
|
|
const struct node_id *id,
|
|
const struct wireaddr_internal *addr,
|
|
bool connected_incoming);
|
|
|
|
/* Last one out deletes peer. Also removes from db. */
|
|
void maybe_delete_peer(struct peer *peer);
|
|
|
|
struct peer *peer_by_id(struct lightningd *ld, const struct node_id *id);
|
|
struct peer *peer_from_json(struct lightningd *ld,
|
|
const char *buffer,
|
|
const jsmntok_t *peeridtok);
|
|
|
|
void peer_connected(struct lightningd *ld, const u8 *msg);
|
|
void peer_disconnect_done(struct lightningd *ld, const u8 *msg);
|
|
void peer_active(struct lightningd *ld, const u8 *msg, int peer_fd);
|
|
|
|
/* Could be configurable. */
|
|
#define OUR_CHANNEL_FLAGS CHANNEL_FLAGS_ANNOUNCE_CHANNEL
|
|
|
|
void channel_errmsg(struct channel *channel,
|
|
struct peer_fd *peer_fd,
|
|
const struct channel_id *channel_id,
|
|
const char *desc,
|
|
bool warning,
|
|
const u8 *err_for_them);
|
|
|
|
u8 *p2wpkh_for_keyidx(const tal_t *ctx, struct lightningd *ld, u64 keyidx);
|
|
|
|
/* We've loaded peers from database, set them going. */
|
|
void setup_peers(struct lightningd *ld);
|
|
|
|
void drop_to_chain(struct lightningd *ld, struct channel *channel, bool cooperative);
|
|
|
|
void channel_watch_funding(struct lightningd *ld, struct channel *channel);
|
|
/* If this channel has a "wrong funding" shutdown, watch that too. */
|
|
void channel_watch_wrong_funding(struct lightningd *ld, struct channel *channel);
|
|
|
|
/* How much can we spend in this channel? */
|
|
struct amount_msat channel_amount_spendable(const struct channel *channel);
|
|
|
|
/* How much can we receive in this channel? */
|
|
struct amount_msat channel_amount_receivable(const struct channel *channel);
|
|
|
|
/* Pull peers, channels and HTLCs from db, and wire them up.
|
|
* Returns any HTLCs we have to resubmit via htlcs_resubmit. */
|
|
struct htlc_in_map *load_channels_from_wallet(struct lightningd *ld);
|
|
|
|
#if DEVELOPER
|
|
struct leak_detect;
|
|
void peer_dev_memleak(struct lightningd *ld, struct leak_detect *leaks);
|
|
#endif /* DEVELOPER */
|
|
|
|
/* Triggered at each new block. */
|
|
void waitblockheight_notify_new_block(struct lightningd *ld,
|
|
u32 block_height);
|
|
|
|
|
|
/* JSON parameter by channel_id or scid */
|
|
struct command_result *
|
|
command_find_channel(struct command *cmd,
|
|
const char *buffer, const jsmntok_t *tok,
|
|
struct channel **channel);
|
|
|
|
/* Ancient (0.7.0 and before) releases could create invalid commitment txs! */
|
|
bool invalid_last_tx(const struct bitcoin_tx *tx);
|
|
|
|
#endif /* LIGHTNING_LIGHTNINGD_PEER_CONTROL_H */
|